With lots of additions overal last year menus become quite busy.
A couple of observations.
1. We have both "Effects - Images" and "Effects - Raster" menus. Do we
keep "Images" submenu for any possible effect not altering contents of
raster images or just embedding/disembedding? If it's emdedding
related only, should we probably then rename submenu?
btw, I'm not really sure that the current way of dealing with
embedding/exporting raster files in SVG document really optimal. See,
opening an arbitrary file I can't tell if an image used there is
embedded or not without looking into source code.There's no indicator
to tell that. An improved hint in status bar could probably be the
first step in the right, IMO, direction. Something like "Embedded
image A x B size in layer N" and "External image A x B size in layer
N". What do you think?
2. Text case altering commands live in "Effects - Text". Should it
probably belong to "Text" menu? As user of applications like Scribus
or OpenOffice.org (sorry, Scribus guys :)) I don't perceive those as
effects --- this is rather altering of text that its look'n'feel. Same
goes for "Replace text..." --- to me it rather belongs to "Edit" or
"Text" menu, not speaking about some kind of clash with "Edit -
I've had some struggle in signals and stuff. I found this in the code:
Why is this connection not saved? Is that not necessary?
It seems to me that this is buggy. When the layer window is deleted, the connection is not disconnected and when the signal is emitted it will call _close with a corrupt "this" value. (this will never happen probably because the button is on the dialog itself, but still)
Thanks for some light on this,
P.S. Why is there a function signal_clicked() to get the signal? In my code I just make the sigc::signal public (see /ui/widget/random.h). Is that bad?
It appears that as of tonight the build is broken due to a missing
dependency. The update to the 2geom code brought in a dependance on gsl.
If someone could look into that and then update configure.ac with a
check for the needed version, that would be helpful. Just FYI, on a
Mac here I have version 1.8.