February 2008 - Inkscape Devel

Re: [Inkscape-devel] Startup crash on OS X
by John Faith 05 Feb '08

05 Feb '08

On Feb 3, 2008 5:39 AM, Niko Kiirala <niko@...1267...> wrote: > Sat, 2 Feb 2008 09:11:51 -0800 > "John Faith" <jfaith7@...400...> kirjoitti: > > > I found that this small change prevents a startup crash on OS X 10.3.9 > > (also added to https://bugs.launchpad.net/inkscape/+bug/185689): > > > > --- inkscape.trunk/src/sp-filter.cpp.orig Sat Dec 22 12:15:36 2007 > > +++ inkscape.trunk/src/sp-filter.cpp.noStartupCrash Sat Feb 2 > > 08:55:03 2008 @@ -110,7 +110,7 @@ sp_filter_init(SPFilter *filter) > > > > filter->_renderer = NULL; > > > > - filter->_image_name = map<gchar *, int, ltstr>(); > > + filter->_image_name.clear(); > > > > filter->filterRes = NumberOptNumber(); > > > > > > While I'm happy that Inkscape can actually run, it's not obvious to me > > why this fixes the crash, nor if this is generaly an acceptable thing > > to do. Could someone possibly test that this does not cause a problem > > on another platform? > > > > By the way, after applying this patch, I have another crash in > > sp-filter.cpp when opening "Help->About Inkscape", so I wonder if > > there's either a std::map problem with gcc 3.3 or memory is getting > > trashed. Random theories welcome :-). > > That was one of the most annoying bugs I've ever had to debug. SPFilter > is not an actual C++ class, so it's not constructed. This means, that > filter->_image_name is not construced either. Before that line you > changed, filter->_image_name has rubbish state and that line is trying > to set it to sensible state. > > So... That line should just call the constructor for > filter->_image_name. I can see, how my original version may be compiled > as 'construct a temporary map and use operator= to copy it to > filter->_image_name'. > Hi Niko, Thanks for the reply. I wonder how the filter struct memory is allocated? As an experiment, I added 2 vars in sp_filter_init(): static SPFilter* filterNew = new SPFilter(); static SPFilter* filterAlloc = (SPFilter*)malloc(sizeof(SPFilter)); , and in gdb saw: (gdb) print filter->_image_name._M_t._M_header $7 = (_Rb_tree_node<std::pair<char* const, int> > *) 0x0 (gdb) print filterNew->_image_name._M_t._M_header $9 = (_Rb_tree_node<std::pair<char* const, int> > *) 0x71a1fe0 (gdb) print filterAlloc->_image_name._M_t._M_header $8 = (_Rb_tree_node<std::pair<char* const, int> > *) 0x0 , which leads me to believe that the filter->_image_name member is not being initialized correctly. I found that changing the SPFilter struct's _image_name from a std::map to a pointer to a std::map and using 'filter->_image_name = new std::map<gchar *, int, ltstr>;' in sp_filter_init() solves my crashing problems; I can now startup and view the About dialog. , John

3 4

simpletransform.py
by Alexandre Prokoudine 05 Feb '08

05 Feb '08

Hi, We seem to have a simpletransform.py extension that isn't installed by default (bug 187838) and has no accompanying .inx. Is it of any use? Why do we have it at all? Alexandre

4 5

Filter Rendering issue
by Josh Andler 04 Feb '08

04 Feb '08

Since we're getting read for full freeze here I figured I'd bring up a bug that I confirmed last night that seems like it should potentially be a blocker imho. There is an example file showing the rendering issue with a few different filters. It appears to be another filter & transformation issue. Anyone else have thoughts? https://bugs.launchpad.net/bugs/188814

1 0

BUG HUNT - Feb 3 - All Done!
by Bryce Harrington 04 Feb '08

04 Feb '08

A surge of fixes has brought us up to 540 / 500, nicely exceeding our bug hunt goal. We'll be proceding into freeze shortly. Pts BugID Assignee Description ------------------------------------------------------------------------ 3 171593 Diederik Snapping menu items and shortcuts 3 168912 Johan Engelen axonometric grid angle changes with... 12 168588 Johan Engelen assertion failed, file sp-conn-end.cpp 3 171783 Bulia Byak rclk on palette should change outline color 3 171710 JonCruz Sum color dragging color inother 3 171292 --- Transparency reduced pdf export 9 168865 Johan Engelen Crashes applying "Path along path" effect... 3 171803 Johan Engelen Angled Guidelines! 12 168570 Johan Engelen Crash when recreating grid using 'redo' 9 178004 Max Albert assert when saving as plain svg 3 170374 --- perspective/warp transformation envelope 6 168574 --- Grid setup truncate significant figures 12 178803 theAdib Save As... -> filetype "PDF via Cairo" crashes 9 178312 Diederik Global 'Enable snapping' option non-functional 9 177891 Johan Engelen feGaussianBlur crashes when setting fill paint 9 174475 Niko Kiirala feImage renderer crashes on non-external image 12 167416 Diederik Shrinking a pattern causes lock-up 9 172778 Johan Engelen Grid settings not respected when reopening doc 6 167640 Bryce Escaped HTML chars - tooltips show incorrectly 12 168751 --- crash rm text from path w/ text cursor active 12 176018 Kees Cook Cairo render prints nothing; bitmap crashes 12 168097 Mental Crash when using clone as clippath 9 179332 Bryce Teeth number in Gears LPE needs tweaking 6 178123 JiHO Template method calls fail for g++3.3/osx 3 168879 --- Advanced french tutorial typos 3 169986 --- Fix location of Swatches menu in tutorial 12 179446 Mental need blend modes in layers dialog 6 168901 theAdib Inkscape Uninstaller deleted other programs? 3 168490 theAdib Catalan language not supported on windows installer 6 179741 Johan Defined Grids cannot be removed 12 179328 Johan Reverse LPE path crashes Inkscape 6 179840 Johan LPE copy problem 6 168249 Bryce --export-dpi ignored if at end of command line 9 177564 Niko Kiirala Segfault on blend filter with fill paint... 6 169071 Niko Kiirala rendering regr. on filtered transformed objects 6 169995 --- 'Save as SVG' button / dialog... 9 168684 Diederik Selection trouble with geometric bounding box 3 167422 Ted Gould major grid lines drawn with minor color 3 178471 Bryce Tooltips missing in the LPEs 6 167132 Ted Gould effect changes inkscape:output_extension 6 178215 Bryce menu icons size in Win32 dev builds is 13X13 12 167898 Michael Grouping section with connectors attached crashes 3 181020 Diederik snap when dragging guides ... 9 179478 Max Albert 3d box tool toolbar doesn't work 9 176646 Max Albert 3d box no redraw after moving 6 179693 Max Albert 3D Tool woes 9 179591 --- Problems saving an imported PDF/AI 9 175726 Niko Kiirala feTurbulence crashes on zooming 9 181663 Gail Font style errors / assert when changing style 6 175398 zeimusu Option to disable tablet support not working 6 181682 Max Albert selection cue option missing from prefs -3 167422 Johan Engelen major grid lines drawn with minor color 3 181380 Diederik "Snap to bounding box edges" - vertical edges 9 181377 Diederik Shapes disappear when snapping nodes to path 6 181995 Niko Kiirala "Neon" filter displayed incorrectly 12 182401 Mental assert crashes in commitUndoable 3 182888 JiHO Inkscape crashes on start on OS X Leopard 3 171086 -- "Align" dialog should remember the dropdown state -9 172778 nightrow Grid settings not respected when reopening doc 9 179982 Johan display grid doc properties docked in multi views 9 183639 Johan LPE crash rotating stitched subpaths assertion 6 184776 Niko Kiirala Inkscape crashes on filter effect usage 9 172778 Johan Grid settings not respected when reopening doc 6 179770 ACSpike Effects broken with error 'invalid tag name' 6 168397 bbyak Setting Font size using combobox in Text toolbar 6 168320 bbyak Font size does not change 6 168377 bbyak f&s lost on text by changing font size by kbd -6 168320 Tom Davidson Font size does not change 9 169057 bbyak Large font sizes crashes/freezes program 6 184499 gustav_b Inkscape Prefs dlg doesn't remember tabs/pgs 9 167500 Diederik Rulers don't align with document 6 174854 bryce SVN doesn't compile without LCMS 9 176608 Ted Gould Effects update on parameter change even without 9 169115 bryce Build issues compiling inkscape 0.45.1 with gcc 4.3 3 168368 bryce `std::isnormal' unknown gcc 3.4.6 solaris 10 3 168969 bryce IRIX: compile error in ucompose.hpp: no std:wstring -9 172778 bryce Grid settings not respected when reopening doc 6 179680 --- Illustrator SVGs open as having no layers at all 6 168959 --- drawing a new polygon changes grayed-out spoke ratio 12 177783 ishmal cairo-ps export creates empty ps files on win32 6 167943 --- pc (pica) and ft (feet) units don't work 6 167464 --- Win2k: File Open in same window won't change window 3 188696 --- Diff for added plurals in src/gradient-context.cpp 12 184376 --- emergency save does not work in trunk ------------------------------------------------------------------------ 540 Goal: 500 http://people.ubuntu.com/~brian/project-graphs/inkscape/plots/inkscape-mont… Note: Points are not given for bugs fixed as invalid, dupe, or worksforme, and only for issues that require code changes to fix (not website, translation, or documentation changes). Note: Scoring for bugs is based on their Importance: Crit=12, High=9, Med=6, Low=3, Undecided=3, Wishlist=3.

1 0

emacs used?
by Michael Yinger 03 Feb '08

03 Feb '08

Anyone use emacs? I'm getting frustrated with Eclipse. -- Mike

2 1

Re: [Inkscape-devel] pdf-input.cpp:544: error: '_preview_output_dev' was not declared in this scope
by Joshua Facemyer / Impressus Art 03 Feb '08

03 Feb '08

Jon A. Cruz wrote: > > On Oct 20, 2007, at 6:49 PM, Joshua Facemyer / Impressus Art wrote: > >> Okay, will the same pdf functionality be present then? (Also, is >> this a workaround to get the thing compiling at a loss of >> functionality, or is it something that should / will be addressed in >> a future update to make it compile in an environment that it should >> without difficulty?) >> > > Someone familiar with the specifics would have to look into it, but I > think it's a work-around in losing a bit of functionality... > > But from what I recall, it's probably due to us using internals of > poppler that are not part of the public API. Get and build poppler > yourself and you might have the needed .h, but use standard packing > and you probably won't. > > Part of me only seeing this recently was that only recently had I > gotten a new enough poppler in macports. I use Gentoo, so my poppler should be "my own" build. Same with Jeff. (Had you figured this out yet, Jeff?) Is it maybe that some switch needs to be passed to poppler when building it? JF

6 18

Startup crash on OS X
by John Faith 03 Feb '08

03 Feb '08

Hello, I found that this small change prevents a startup crash on OS X 10.3.9 (also added to https://bugs.launchpad.net/inkscape/+bug/185689): --- inkscape.trunk/src/sp-filter.cpp.orig Sat Dec 22 12:15:36 2007 +++ inkscape.trunk/src/sp-filter.cpp.noStartupCrash Sat Feb 2 08:55:03 2008 @@ -110,7 +110,7 @@ sp_filter_init(SPFilter *filter) filter->_renderer = NULL; - filter->_image_name = map<gchar *, int, ltstr>(); + filter->_image_name.clear(); filter->filterRes = NumberOptNumber(); While I'm happy that Inkscape can actually run, it's not obvious to me why this fixes the crash, nor if this is generaly an acceptable thing to do. Could someone possibly test that this does not cause a problem on another platform? By the way, after applying this patch, I have another crash in sp-filter.cpp when opening "Help->About Inkscape", so I wonder if there's either a std::map problem with gcc 3.3 or memory is getting trashed. Random theories welcome :-). Thanks!, John

2 1

Inkscape native Mac OS X build & look improvements
by Adam Strzelecki 03 Feb '08

03 Feb '08

Hello, I've recently switched for good to MacOSX (after several years of work with Windows). I'm user and fan Inkscape. On Windows there was pretty well working native build, while it is missing on MacOSX (X11 build is pretty slow and not handy) So I've decided to make it myself and now share my experience with you. Attached the screenshot of my running native OSX (Leopard) version of Inkscape (no, it's not a fake ! ;P) I've used the recipe from http://wiki.inkscape.org/wiki/index.php/CompilingMacOsX with MacPorts. Here are my changes to original MacPorts recipe: 1) I've updated to latest GTK+2 using: (you need to do the same or Inkscape will be crashing every few seconds) port edit gtk2 version 2.12.5 checksums md5 588c7fb3d9ebadf4f5a1ab4c534e4db5 port install gtk2 +quartz 2) I've downgraded boehmgc to 6.8 (latest 7.0 causes Inkscape to hang (never ending loop) on startup) port edit boehmgc version 6.8 distname ${d_name}${version} checksums sha1 6d5def5ba5d29292ba9c76f04df3ec06d3ab3278 3) Applied my own-cooked patch Inkscape_OSX_native_menu_and_toolbars.patch (attached) * src/widgets/toolbox.cpp: removes tb_s, tb_e spacers from the toolbars to they DON'T have ugly underlines (who did invent this anyway, this produces ugly look in most GTK themes where toolbars are 2x inset in the GUI, I believe this should be removed anyway in all builds (platforms)) * src/ige-mac-menu.[c/h]: sources for native Carbon Mac top menu wrapper instead of having the menu inside the window (taken from GIMP sources) * src/interface.cpp: use ige_mac_menu_set_menu_bar on native GTK (Quartz) for menu and return NULL so no menu is displayed in the Window itself * configure.ac: add Carbon checking and libs define required ige-mac- menu * src/Makefile_insert: add Carbon libs and ige-mac-menu sources * removes packaging/macosx/Resources/themes/Clearlooks-Quicksilver- OSX: we should take Leopardish-normal theme instead from: http://www.gnome-look.org/content/show.php/Leopardish?content=65299 which is far more adequate for GTK looking like OSX 4) then normally built with packaging/macosx/osx-build.sh a c b i p 5) fixed Inkscape.app so it is displayed as single Launch bar icon named "Inkscape" by: * removing Contents/Resources/getdisplay.sh & Contents/Resources/ inkscape (we don't need those in native !) * renaming Contents/Resources/inkscape-bin to Contents/Resources/ Inkscape * replacing Contents/MacOS/Inkscape with simple shell script that sets cwd to Inkscape.app and runs Contents/Resources/bin/Inkscape: > #!/bin/sh > PRG="$0" > while [ -h "$PRG" ] ; do > ls=`ls -ld "$PRG"` > link=`expr "$ls" : '.*-> $.*$$'` > if expr "$link" : '/.*' > /dev/null; then > PRG="$link" > else > PRG=`dirname "$PRG"`"/$link" > fi > done > DIR="`dirname $PRG`" > cd $DIR > cd ../.. > exec Contents/Resources/bin/Inkscape 6) Changed GTK theme (with gtk-chtheme) to Leopardish and font "Geneva 11pt" - MacOSX default And the result is Inkscape looking & working like native OSX (Leopard) application: * native look with GTK Leopardish-normal theme * native menus with ige-mac-menu-bar * native Name and application in Launch bar Yet I found some problems while doing those changes: * ige-mac-menu doesn't map properly keyboard shortcuts as it should (as it does with GIMP), those should be mapped with Ctrl<->Cmd transition, while they're not mapped at all with Inkscape * ige-mac-menu trick with returning NULL to avoid display the 2nd menu in the window makes probably some problem with updating the menu in the app in later stages so things like recent files don't show up in the app menu anymore * ige-mac-menu should be extended with Inkscape (bold) menu entries for preferences and application closure (I hope Mac users will know what I mean) * my tricks with Inkscape.app are as dirty as old tricks for X11 version, I believe that proper solution should anyway place final native binary of Inkscape in Contents/Resources/MacOS and map properly path in Contents/Resources for lib, etc, share,.. and so on without intermediate shell scripts (like mine) * toolbox should be set to small icons by default (SVN is set to big icons), unless the Inkscape window will forced to set its minimum height of toolbox height, which results in Inkscape not being resizable vertically on my MacBook at all ! (being too big) * Leopardish-normal theme and "Geneva 11pt" should be set by default in Inkscape.app somehow if no GTK settings (or other GTK installation) are present * ... and finally there's some problem with SVG View repaint, everytime it repaints (when opening or activating Inkscape window) the view is afterward erased by default (grayish) color (???) and then when I move the mouse over the view (which is erased with solid color), the repaints 2nd time, this time the proper output stays on screen. I believe it is problem of Inkscape not GTK+ cos it doesn't happen in any other place but just SVG (Document) view. Anyway my build works pretty well, there're some minor annoyances in some windows (like File open window) however it seems to be pretty stable (doesn't crash) and responsible. I hope it will help you (Developers) to make some time native OSX official builds... maybe 0.46 !? Best regards, -- Adam Strzelecki |: nanoant.com :|

5 11

0.45.1 build failure in helper/sp-marshal.cpp
by Jeremy C. Reed 03 Feb '08

03 Feb '08

Trying to build inkscape-0.45.1 on Linux fails for me. make[2]: Entering directory `/scratch2/pkgsrc/graphics/inkscape/work.puget/inkscape-0.45.1/src' if g++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/freetype2 -pthread -DORBIT2=1 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -DPOTRACE=\"potrace\" -pthread -I/usr/include/gdkmm-2.4 -I/usr/lib/gdkmm-2.4/include -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include -I/usr/include/pangomm-1.4 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairomm-1.0 -I/usr/include/sigc++-2.0 -I/usr/lib/sigc++-2.0/include -I/usr/include/glib/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtkmm-2.4 -I/usr/lib/gtkmm-2.4/include -I/usr/include/atkmm-1.6 -I/usr/include/atk-1.0 -I/usr/include/libxml2 -I/usr/include/gtkspell-2.0 -I../cxxtest -I/usr/include -I/usr/include/freetype2 -Wall -Wformat-security -W -Wpointer-arith -Wcast-align -Wsign-compare -Woverloaded-virtual -Wswitch -Wno-unused-parameter -g -I/usr/include -I/usr/include/freetype2 -MT helper/sp-marshal.o -MD -MP -MF "helper/.deps/sp-marshal.Tpo" \ -c -o helper/sp-marshal.o `test -f 'helper/sp-marshal.cpp' || echo './'`helper/sp-marshal.cpp; \ then mv -f "helper/.deps/sp-marshal.Tpo" "helper/.deps/sp-marshal.Po"; \ else rm -f "helper/.deps/sp-marshal.Tpo"; exit 1; \ fi helper/sp-marshal.cpp:60: error: parse error before `__attribute__' helper/sp-marshal.cpp: In function `void sp_marshal_VOID__POINTER_BOOLEAN(...) ': helper/sp-marshal.cpp:70: error: syntax error before `;' token helper/sp-marshal.cpp:71: error: `closure' undeclared (first use this function) helper/sp-marshal.cpp:71: error: (Each undeclared identifier is reported only once for each function it appears in. helper/sp-marshal.cpp:74: error: parse error before `if' helper/sp-marshal.cpp:79: error: ISO C++ forbids declaration of `data2' with no type helper/sp-marshal.cpp:79: error: conflicting types for `int data2' helper/sp-marshal.cpp:72: error: previous declaration as `void*data2' helper/sp-marshal.cpp:79: error: `param_values' undeclared (first use this function) helper/sp-marshal.cpp:80: error: parse error before `}' token helper/sp-marshal.cpp:84: error: ISO C++ forbids declaration of `data2' with no type ... My gcc is: $ g++ --version | head -1 g++ (GCC) 3.3.5 Is that 3.3.5 not good enough? I also have installed: boehm-gc-6.4 gtkmm-2.12.3 glibmm-2.14.2 glibc-2.3.4 libsigc++-2.1.1 glib2-2.14.5 cairomm-1.4.6 cairo-1.4.12 gtk2+-2.12.5 Jeremy C. Reed p.s. I have one patch for src/seltrans.h - SigC::Connection _sel_changed_connection; - SigC::Connection _sel_modified_connection; + sigc::connection _sel_changed_connection; + sigc::connection _sel_modified_connectio

2 2

Re: [Inkscape-devel] Pencil toolbar
by R M 02 Feb '08

02 Feb '08

> Also: maybe while you're at it, you could also add the tolerance > slider to the controls bar of the tool, which is a very long-standing > feature gap. here's a patch to add the tolerance control to the slider: http://arcsin.org/temp/toolbox.diff one major problem is that it doesn't listen for preference changes and will get out of sync with the tolerance control in the inkscape-preferences panel. I didn't see any obvious way to remedy this. Is there one, or does one need to be written (setup a signal to connect to, to be notified)? rob

4 4