I just did a change to NRRect's default constructor.
Prior to this it was leaving all of its members uninitialized, and
valgrind found that some like this were being checked for 'empty'. So
random behavior could have been seen.
I also did a fix under display, but that was an array index going
below zero, but I think the loop would have exited anyway, so I don't
expect that change to really affect the program.
I'm mainly concerned that some bugs might have been caused by 'new'
NRRect variables being seen as non-empty and now they'll show up as
BTW, these were the first two things I found by getting to run under
Valgrind and seeing what was reported right off the bat. I'll
probably try to actually explore the app a little more under
valgrind, but I think these two were a good start.
Simon Mieth wrote:
> Aaron Spike schrieb:
>> Simon Mieth wrote:
>>> Windows XP SP2, Inkscape daily build from Feb 29 2008:
>>> Java extension and .NET error message
>>> Microsoft Visual C++ Runtime Library
>>> Runtime Error! Inkscape internal error
>> This must be a new issue. Could you please make a backtrace with gdb
>> (there should be instructions on the wiki or website) and post a bug
>> on launchpad?
>> Aaron Spike
> Ok I will try this.
Back in 2004, Peter Moulder added assert_close to nr-matrix.cpp and
used in it several matrix operators in libnr (such as multuplying a
matrix by a scale, etc). All it does is just checks if two matrices
are "close enough".
I am going to remove this assert because:
- what it tests is simply computer arithmetic, not something Inkscape
itself can get wrong. I don't think it can discover any bugs for us.
- used in basic operators, it likely slows the program down for no
Unless there are objections, of course.
Inkscape. Draw Freely.
Not sure if this actually affects anyone, but I ran across a clump of
display/guideline.cpp: In function ‘void sp_guideline_render
display/guideline.cpp:140: warning: passing ‘double’ for argument 3
to ‘void sp_guideline_drawline(SPCanvasBuf*, gint, gint, gint, gint,
eight of those in a row. I'll be fixing them.