June 2011 - Inkscape Devel - Inkscape Mailman

48.1 OK?
by John Culleton 29 Jun '11

29 Jun '11

I know that 48.2 is now the current development product. But are there any show stoppers in 48.1? -- John Culleton "Death Wore Black" Police procedural: http://www.deathworeblack.com/ "Create Book Covers with Scribus" http://booklocker.com/books/4055.html

2 1

libgdl issue
by Jon Cruz 29 Jun '11

29 Jun '11

Hi, in clearing up some warnings, I (as somewhat expected) spotted a potential issue hiding amongst the others. libgdl/gdl-dock-item-grip.c: In function 'gdl_dock_item_grip_expose': libgdl/gdl-dock-item-grip.c:143: warning: assignment from incompatible pointer type libgdl/gdl-dock-item-grip.c:146: warning: passing argument 2 of 'gdk_draw_rectangle' from incompatible pointer type If anyone wants something to poke at a bit, checking this might be good.

3 3

Inkscape CSS class handling
by Abhishek Sharma 29 Jun '11

29 Jun '11

Hello everyone, I just wanted to make sure, that does inkscape handle classes in CSS <style> element inside an SVG. In other words if a <text> element has <text class="one">, then does this text element inherit the properties in class="one" ?? if it does it, may someone tell me where in the codebase could this be found(although I'll be happy with the answer to first question also :) ) -- Regards, Abhishek Sharma

1 0

problems in compiling on windows
by Abhinav Vishwa 28 Jun '11

28 Jun '11

>> I have compiled Inkscape completely according to instructions given on >> this link >> http://wiki.inkscape.org/wiki/index.php/Win32Port >> >> but as given there is no executable in the inkscape directory. >> >> That's why nsis installer is also giving error in creating installer. > > Just a few more details could help. What exactly did you do, and what > was the result? In particular, where there any errors during > compilation? (Compilation should end with a whole lot of things being > copied and then showing the total amount of time spent on the > compilation.) Did you make sure that you have both devlibs and trunk, > and that the paths in mingwenv.bat point to the right locations? Are you > using TDM's gcc? Have you built buildtool? Do you get a build directory? > If so, what does it contain? Etc., etc. I did each and every step as given on the link , I've provided. There weren't any error's in the compilation. yes, I've both devlibs and trunk and here is the mingwenv.bat @echo Setting environment variables for MinGw build of Inkscape IF "%DEVLIBS_PATH%"=="" set DEVLIBS_PATH=c:\devlibs IF "%MINGW_PATH%"=="" set MINGW_PATH=c:\MinGW set MINGW_BIN=%MINGW_PATH%\bin set PKG_CONFIG_PATH=%DEVLIBS_PATH%\lib\pkgconfig set PATH=%MINGW_BIN%;%PATH%;%DEVLIBS_PATH%\bin;%DEVLIBS_PATH%\pytho which points to the right locations.

2 1

Inkscape license + potential problem
by Krzysztof Kosiński 28 Jun '11

28 Jun '11

Hello I am wondering under what license Inkscape actually is. Most source files don't have the full GPL copyright notice which specifies the version, they only say "released under GNU GPL". This would suggest that most of the code is GPLv2+. There are also several files dual-licensed under MPL and GPL. Our Launchpad website states that Inkscape is under GPLv2. However, I encountered a file which is GPLv3 only, apparently copied from GIMP (src/util/expression-evaluator.cpp). If we really are GPLv2, then including this file is not legal, as GPLv2 is not compatible with GPLv3. We would need to change our license to GPLv3 or GPLv3+ to include this file, or contact the original authors for a GPLv2 or BSD license. PS: our Windows devlibs also seem to be in a "gray area", because most of the copyright information is not present, which might break the license terms of the libraries. I'll try to remediate this by adding the license files from each package, once I have some spare time (i.e. not very soon). Regards, Krzysztof

6 5

Any blockers for 0.48.2?
by Josh Andler 27 Jun '11

27 Jun '11

Subject asks the important stuff. :) Cheers, Josh

3 3

problems in compiling on windows
by Abhinav Vishwa 27 Jun '11

27 Jun '11

I have compiled Inkscape completely according to instructions given on this link http://wiki.inkscape.org/wiki/index.php/Win32Port but as given there is no executable in the inkscape directory. That's why nsis installer is also giving error in creating installer.

2 1

New rendering bug with blur filter
by Ivan Louette 27 Jun '11

27 Jun '11

(Sorry, my bitmap was too big at first time) This bug doesn't exist in 0.48.1 I saw it this morning in rev 10355 on Kubuntu Couls someone confirm it before I fill it on Launchpad ? When blur is combined with a Composite "in" some vertical dark lines are shown on rendering and exporting to bitmap. If vertical blur is set to zero the lines change to dots. If a little amount of black is added they disappear (here I decrease luminance and that works too). ivan

3 2

Code cleanup and minor tweaks
by Jon Cruz 27 Jun '11

27 Jun '11

Hi Campbell, I just wanted to thank you for the recent improvement to our codebase, such as in revision 10359. Getting things fixed such as not passing 'false' in to pointers helps in many ways, including reducing the number of odd, hard to reproduce bugs. I also just wanted to point out a few minor style points that could help. One is with the use of "NULL". That is more of a C macro that in C++ has be replaced with the simple use of "0". I've looked into this point with coworkers and others at various points, and can try to dig up more details if you need them. The other point is in using whitespace. I realize that in your recent changes you have been preserving what already existed, but it is helpful if "cleanup" that touched lines left them with nicer spacing also. We have some info on our coding style page, but the gist is to put spaces between things, but not in the middle of things. :-) That is, space around keywords, operators, etc, but not between a function name and its opening paren. For example, this line you touched could be improved by spacing it thusly &&((l!=NULL&&!edge->isEnd(l->id))||l==NULL) && ((l != NULL && !edge->isEnd(l->id)) || l == NULL) Suddenly that makes the logic and the referencing easier to read and follow. It also gives more visibility to areas that could be made clearer with more parenthesis: && (((l != NULL) && !edge->isEnd(l->id)) || (l == 0) ) if I compare those right on top of each other, the legibility change should show up: &&((l!=NULL&&!edge->isEnd(l->id))||l==NULL) && (((l != NULL) && !edge->isEnd(l->id)) || (l == 0) ) Depending on the font, that might even reveal another problem. In general I strongly dislike single-letter literals (except for the common 'i' in for loops, etc). And even worse is the single letter variable 'l'. In fact, in the font I'm typing with at the moment I can not tell the difference between the lower-case-letter-el, the capital-letter-eye and the vertical-bar-pipe-| (lI|). What is worse is some fonts even make the numeral -one indistinguishable. But this is a side rant on a given bad variable. If you happen to be touching enough lines, consider giving it a better name. Anyway, thanks for the help in this area and the opportunity for me to point out to some of the other newer people on the list what sort of tweaks can help our codebase be more legible and maintainable.

3 5

Extensions and Warnings
by Martin Owens 26 Jun '11

26 Jun '11

I'm trying to solve a bug with my deviantArt stash extension. It produces warnings because poxy webkit with bleedin java and god aweful html decide that it's a great idea to shout out to the world a whole bunch of version information, including any javascript errors that happen in the loaded pages. What cute is that I told the inx to load a bash shell which loaded the python script and to dev/null everything. That didn't hack fix it. I tried redirecting sys.stderr to a file, somehow it still manages to come through. Please tell me there is a way to stop inkscape from reporting warnings from python extensions? There is no reason to report warnings to users unless they can be formatted in a nice way and these can't be. Martin,

2 1