Cloned gradient bug fix
by Johan Engelen
Hi all,
I just committed a symptom fix to LP bug #453067.
The root cause is evil to fix, and probably no-one will get to it before
release.
Hope it counts towards the bug score.
regards,
Johan
8 years, 10 months
Re: [Inkscape-devel] GSOC status report - Better support for SVG paints
by Tomasz Boczkowski
> It would be nice to be able to edit the gradient as is done with
> swatches... but this might be involve resurrecting a simplified version
> of the late Gradient editor dialog.
I like the idea. I can do it after I implement hatches.
> One small problem... I had trouble switching back from "Grid" view to
> the "Tree" view as there wasn't an empty place to click on until I
> widened the window a bit.
You can also change the mode using left arrow button at the bottom right
corner.
By the way I'm thinking of leaving some empty space after each palette in
grid mode
to keep palettes separate. It would look like this [1]. An icon could be
added as first element of
each palette. It would have a tooltip set to category name.
[1] https://www.dropbox.com/s/0jltcbm8rqthsi9/newlines.png
On Wed, Jul 23, 2014 at 4:43 PM, Tomasz Boczkowski <penginsbacon@...400...>
wrote:
> > It would be nice to be able to edit the gradient as is done with
> > swatches... but this might be involve resurrecting a simplified version
> > of the late Gradient editor dialog.
>
> I like the idea. I can do it after I implement hatches.
>
> > One small problem... I had trouble switching back from "Grid" view to
> > the "Tree" view as there wasn't an empty place to click on until I
> > widened the window a bit.
>
> You can also change the mode using left arrow button at the bottom right
> corner.
>
> By the way I'm thinking of leaving some empty space after each palette in
> grid mode
> to keep palettes separate. It would look like this [1]. An icon could be
> added as first element of
> each palette. It would have a tooltip set to category name.
>
> [1] https://www.dropbox.com/s/0jltcbm8rqthsi9/newlines.png
>
>
> On Wed, Jul 23, 2014 at 1:43 PM, Tavmjong Bah <tavmjong@...8...> wrote:
>
>> On Tue, 2014-07-22 at 13:19 +0200, Tomasz Boczkowski wrote:
>> > New functions were added to the swatches dialog.
>> >
>> >
>> > The most important is the ability to modify swatches. A swatch
>> > properties
>> > dialog was added. When a swatch in "current document" category is
>> > selected,
>> > "swatch properties" option is active. After clicking it a dialog
>> > appears.
>> > It is possible to change swatch name. Technically it is stored in
>> > title child
>> > element. Swatch preview is displayed at the bottom of the dialog.
>> > Depending
>> > on swatch type different controls can be displayed. For colors a color
>> > notebook
>> > widget is used to change swatch value [1]. Pattern attributes can be
>> > changed
>> > using attribute table widget [2].
>> >
>> >
>> > Gradient support has been added. Gradients having a gradient vector
>> > defined
>> > are displayed in swatches panel [3]. The user can apply gradient to
>> > existing
>> > object. It is linear by default. An exception to this is applying
>> > gradient to
>> > an object with existing radial one.
>>
>> It would be nice to be able to edit the gradient as is done with
>> swatches... but this might be involve resurrecting a simplified version
>> of the late Gradient editor dialog.
>>
>> > All pattern types can be chosen when no item is selected on canvas. In
>> > this case
>> > newly created items will receive selected style.
>>
>> This is all really nice.
>>
>> One small problem... I had trouble switching back from "Grid" view to
>> the "Tree" view as there wasn't an empty place to click on until I
>> widened the window a bit.
>>
>> Tav
>>
>>
>>
>>
>>
>
8 years, 10 months
Different handling of x, y for path vs. text breaking text clipping
by mathog
Hi all,
I'm trying to get clipping on text read in from EMF to work properly and
r13463 (and maybe earlier) is doing something odd in that it is treating
path and text coordinates differently, but ONLY when it reads the SVG
"hot off the press" from the EMF read. If the exact same SVG is first
emitted to a file and then read in directly, it works fine. Here is one
such file(retrieve only directory):
http://saf.bio.caltech.edu/pub/pickup/mangle_clip.svg
that has the clipping more or less right when viewed in Firefox and when
opened in
Inkscape. But when the source EMF file is read directly, the
coordinates of the <text> pieces are transformed and a <transform> tag
is added to the <text>, the coordinates of the <path> draw are not
transformed. Since both reference the same clipping path, this breaks
clipping for text, because the coordinates of the clip-path must match
up with those of the <text> IN the <text>, not AFTER it. If
the text were not being clipped, the transform would not make a
difference (but it is, so it does).
The link above is the output of the following code fragment:
(void) myEnhMetaFileProc(contents,length, &d);
free(contents);
if (d.pDesc){ free( d.pDesc ); }
std::cout << std::endl << d.outsvg << std::endl;
SPDocument *doc = SPDocument::createNewDocFromMem(d.outsvg.c_str(),
strlen(d.outsvg.c_str()), TRUE);
And things go wrong when the SVG as text in memory goes through
createNewDocFromMem but not when the SVG as text in a file goes through
whatever path the usual SVG file open uses.
Does this issue sound familiar to anyone, and if so, what is the
workaround?
Thanks,
David Mathog
mathog@...1176...
Manager, Sequence Analysis Facility, Biology Division, Caltech
8 years, 10 months
Code cleanup in trunk
by Johan Engelen
Hi Markus,
Thanks for the code cleanups in trunk.
One comment: please be careful in removing nullptr checks in trunk.
Although they look unnecessary, we really don't want to (re-)add bugs.
In rev 13460, you removed a this == nullptr check. It's terrible code, I
agree. The problem is that some other bad code may still rely on that
check. I'm not saying that's the case for that particular piece of code,
but I'd rather not remove such checks in trunk until after release.
Small tip for people bughunting, "this" in a class method can be
nullptr. A call through nullptr to non-virtual method will happily pass.
Because we changed code like
f(SPFoo *g) {
if (!g) return;
to
Foo::f() {
if (!this) return;
you may see a check on "this" in the code. If you are sure that all
callers make sure the object is not nullptr, you can remove the check in
experimental.
thanks,
Johan
8 years, 10 months
Re: [Inkscape-devel] GSOC status report - Better support for SVG paints
by Tomasz Boczkowski
New functions were added to the swatches dialog.
The most important is the ability to modify swatches. A swatch properties
dialog was added. When a swatch in "current document" category is selected,
"swatch properties" option is active. After clicking it a dialog appears.
It is possible to change swatch name. Technically it is stored in title
child
element. Swatch preview is displayed at the bottom of the dialog. Depending
on swatch type different controls can be displayed. For colors a color
notebook
widget is used to change swatch value [1]. Pattern attributes can be
changed
using attribute table widget [2].
Gradient support has been added. Gradients having a gradient vector defined
are displayed in swatches panel [3]. The user can apply gradient to existing
object. It is linear by default. An exception to this is applying gradient
to
an object with existing radial one.
All pattern types can be chosen when no item is selected on canvas. In this
case
newly created items will receive selected style.
Regards
Tomasz
[1] https://www.dropbox.com/s/5fb0r9hhdo4w2uc/solid-swatch-properties.mpeg
[2] https://www.dropbox.com/s/54vi1j4ypjdv2mq/pattern-swatch-properties.mpeg
[3] https://www.dropbox.com/s/z998vjvoucbirmg/gradient-support.mpeg
On Fri, Jun 27, 2014 at 11:30 PM, Tomasz Boczkowski <penginsbacon@...400...>
wrote:
> Thank you!
>
> > One quick suggestion, please add Black to the options for background
> > color. :)
> Added.
>
> Tomasz
>
>
> On Fri, Jun 27, 2014 at 9:23 PM, Martin Owens <doctormo@...400...> wrote:
>
>> On Fri, 2014-06-27 at 19:49 +0200, Tomasz Boczkowski wrote:
>> > I've implemented the look and feel options that were planned in
>> > project proposal. [1] Now there are three view modes:
>> > * list, showing tiles with labels divided into categories
>> > * grid, presenting only preview tiles contiguously
>> > * tree, presenting preview tiles divided into categories
>>
>> Nice work Tomasz!
>>
>> Martin,
>>
>>
>>
>
8 years, 10 months
Re: [Inkscape-devel] New swatches dialog and questions
by Tomasz Boczkowski
Thanks!
> It would also have been nice to be able to change multiple swatches at
> the same time as it might have been if last years color GSOC project had
> been finished.
How can this be done? Are there any mockups from last year available?
> The Fill and Stroke dialog could use a rethinking. I really don't like
> that clicking on the Swatch icon automatically creates a new swatch.
The "swatch" tab can be moved to the color notebook and display
solid color swatches. It would behave similar to the patterns tab.
> We should also be displaying gradients in the swatches dialog.
No problem.
> Same thing with clicking on the Pattern icon.
I'm afraid I didn't get the point. After clicking the pattern icon
a list of patterns is displayed and no new pattern is created.
> It might be interesting to think on how
> the Fill and Stroke tabs could be integrated with the new Swatches
> dialog.
I fully agree. Especially when solid colors, gradients and patterns
are equally treated as swatches. My first mockups from this project
included a modified fill and stroke interface [1]. They were rejected
and replaced by integration of pattern preview widget in a fill and stroke
tab. At those time, the mockups didn't involve the swatches dialog.
Do you think this idea is worth considering again?
Tomasz
[1] https://www.dropbox.com/s/l2w3ybeozmzix73/integration.png
On Sun, Jul 13, 2014 at 1:45 PM, Tomasz Boczkowski <penginsbacon@...400...>
wrote:
> Thanks!
>
> > It would also have been nice to be able to change multiple swatches at
> > the same time as it might have been if last years color GSOC project had
> > been finished.
>
> How can this be done? Are there any mockups from last year available?
>
> > The Fill and Stroke dialog could use a rethinking. I really don't like
> > that clicking on the Swatch icon automatically creates a new swatch.
>
> The "swatch" tab can be moved to the color notebook and display
> solid color swatches. It would behave similar to the patterns tab.
>
> > We should also be displaying gradients in the swatches dialog.
>
> No problem.
>
> > Same thing with clicking on the Pattern icon.
>
> I'm afraid I didn't get the point. After clicking the pattern icon
> a list of patterns is displayed and no new pattern is created.
>
> > It might be interesting to think on how
> > the Fill and Stroke tabs could be integrated with the new Swatches
> > dialog.
>
> I fully agree. Especially when solid colors, gradients and patterns
> are equally treated as swatches. My first mockups from this project
> included a modified fill and stroke interface [1]. They were rejected
> and replaced by integration of pattern preview widget in a fill and stroke
> tab. At those time, the mockups didn't involve the swatches dialog.
> Do you think this idea is worth considering again?
>
> Tomasz
>
> [1] https://www.dropbox.com/s/l2w3ybeozmzix73/integration.png
>
>
> On Thu, Jul 10, 2014 at 5:02 PM, Tavmjong Bah <tavmjong@...8...> wrote:
>
>> On Wed, 2014-07-09 at 18:57 +0200, Tomasz Boczkowski wrote:
>> > There's one more issue that I would like to consult.
>> >
>> >
>> > 4) There's a number of palettes provided with inkscape. If they are
>> > all displayed in tree mode, they occupy a lot of
>> > space in swatches dialog [1]. It can be quite uncomfortable to use
>> > "Ubuntu" and "Current document" palettes
>> > at the same time. In grid view mode, when all categories are collapsed
>> > into one, the situation is even worse [2].
>>
>> Yes, this is a big problem.
>>
>> > I can think of three solutions:
>> > * Leave tree mode [1] as is and in grid mode [2] display only expanded
>> > palettes. To enhance discoverability
>> > it would be possible to expand and close palettes from popup menu
>> > [3]
>>
>> I like the way the tree mode keeps the palettes separate. I prefer this
>> to the grid mode.
>>
>> > * Use the popup menu [3] to choose palettes that are shown in swatches
>> > dialog. If a category is shown it can
>> > further be expanded or collapsed.
>>
>> There is a discoverablity issue here.
>>
>> > * Share a TreeModel behind swatches dialog between: patterns panel in
>> > fill and stroke dialog, color chooser bar
>> > at the bottom of the screen and swatches dialog. Add a dialog to
>> > choose active palettes, as shown in [4]. The
>> > solution is similar to GIMP behaviour.
>>
>> Sharing the TreeModel is a good idea, but I am not sure about the dialog
>> to choose the palette.
>>
>> > Which of them do you like most?
>>
>> What about adding a fourth option "Choose Palettes" to Tree, Grid, List
>> that would be like your Palettes dialog
>>
>> > In third case we have a data model common to a number of dialogs. How
>> > can I implement creating and sharing
>> > the object? What comes to my mind is making the data model a
>> > singleton, or associating it with SPDesktop
>> > object. Are there other possibilities?
>>
>> Singleton would be fine, I think.
>>
>> Tav
>>
>>
>>
>> > [1] https://www.dropbox.com/s/5tfjj0ih62fxl03/swatches_categories1.png
>> > [2] https://www.dropbox.com/s/5675of3vfi926pt/swatches_categories2.png
>> > [3] https://www.dropbox.com/s/q16h3ecqhkn1pso/swatches_categories3.png
>> > [4] https://www.dropbox.com/s/v245xz3m1o82jch/palettes_dialog.png
>>
>>
>>
>
8 years, 10 months
Re: [Inkscape-devel] Inkscape 0.48.5 Released
by Jared Meidal
Got it working now.
I'm not sure if I fixed this or someone else. The news article was set to be published, but the publish time was future in my timezone. I moved it back 6hrs and the link on the homepage works for me now. (This also messed up the RSS feed until the link began to work again.)
--Jared
>
> Message: 3
> Date: Fri, 18 Jul 2014 15:46:52 -0700 (PDT)
> From: alvinpenner <penner@...1856...>
> Subject: Re: [Inkscape-devel] Inkscape 0.48.5 Released
> To: inkscape-devel(a)lists.sourceforge.net
> Message-ID: <1405723612463-4971012.post@...2730...>
> Content-Type: text/plain; charset=us-ascii
>
> glad to hear it!
>
> just writing to note that, on the site:
> http://www.inkscape.org/en/news/2014/07/
>
> the link that says "Inkscape 0.48.5 Released" does not work.
>
> Alvin
8 years, 10 months
two new icons propose
by Jabiertxo Arraiza Cenoz
Hi to all.
Because GTK declare obsolete "yes" and "no" icons, and "accept" and
"cancel" icons are handled by his label -so you can not change his label
to a custom text i think-, I propose the creation of two icons in the
icon files of inkscape.
I want particulary to use in the new LPE parameter "Toggle Button", now
is used in experimental branch -Simplify LPE-. For this LPE I'm using
"system-run" and "process-stop" GTK default icons, but i think is better
a toogled button for example like bullets here[1].
http://www.inkscape.org/en/develop/next-release/
Any problem to add it? I could do it but maybe we can ask for on
inkscape-user list.
Regards, Jabier.
8 years, 10 months
