- Inkscape Devel - Inkscape Mailman

Cppify Branch Review
by Markus Engel 19 Sep '13

19 Sep '13

Hi everyone, have you worked your way through my changes yet? Any comments? :) Krzysztof, you wanted to do the review? Regards, Markus

5 13

[ Recolor ] Status Report
by Arshdeep Singh 19 Sep '13

19 Sep '13

Hi all, Sorry for not being able to give a report for the past two weeks. I was in regular touch with my mentor though, as well as Josh. The project stands as such: 1.) The nodes are added to the wheel when a new object is added to the active selection. 2.) Removal of nodes is a tricky issue. We are working on that currently. 3.) Updating of objects on the canvas was achieved earlier on. That snippet has to be used for active editing after the removal issue is solved. >From discussions with my mentor and Josh, we all concur that the project can only achieve its first half into completion in the given time frame. Namely, the part of the tool where we could save color schemes does not seem feasible to implement in the remaining time frame. -- Arshdeep Singh Third Year, Computer Engineering Delhi Technological University Ph: +91-9654115614 https://sites.google.com/site/adsingh1729/home

1 0

Please don't neglect the release notes
by Josh Andler 19 Sep '13

19 Sep '13

If you've committed any noteworthy changes please make sure everything is reflected there. This goes for GSoC projects as well. Here's the link http://wiki.inkscape.org/wiki/index.php/Release_notes/0.49 , it's preferred if the people who created the features/changes are the ones to describe them. Cheers, Josh

4 3

Mac OS X 0.48.4 RC5
by Valerio Aimale 19 Sep '13

19 Sep '13

For Mtn Lion: http://rapidshare.com/files/1406366642/Inkscape-r0.48.4-r9943-10.8%2B-x86_6… For Lion: http://rapidshare.com/files/2591591009/Inkscape-r-10.7%2B-x86_64_RC5.dmg fixed: - restored drag&drop, it was a problem with the pasteboard fix, not the menu integration. - further editing of the keymapping for menu accelerators. Hopefully it will cover most of the cases. Regarding pasting into text fields, that is something we might learn to live with for the time being. Valerio

7 13

Pixbuf vs Cairo Surface
by Martin Owens 19 Sep '13

19 Sep '13

https://bugs.launchpad.net/inkscape/+bug/871563/comments/12 Hey KK, Your message above in that bug report is a little cryptic because the current code and the patches previous suggested use pixbufs, while you talk about cairo surfaces. Are you saying that the pixbuf code should be removed and replaced with dealing directly in cairo surfaces? I'm a little confused because the bug is about pasting objects, and I can only assume that we get a pointer to a block of data when someone pastes things in and we stuff that into an image object of some kind. Could you explain what you mean? Martin,

3 10

new website: coding style
by Johan Engelen 18 Sep '13

18 Sep '13

Hi all, There are some errors in the coding style page I believe. Two big issues: namespace Inkscape { namespace UI { Sandwich make_sandwich(int x); int make_a_mess(float y); } } instead of namespace Inkscape { namespace UI { Sandwich make_sandwich(int x); int make_a_mess(float y); } } For these kind of forward declarations, I think it is much clearer to indent. Not for class definitions etc. And switch (a) { case 1: do_one(); break; instead of switch (a) { case 1: { do_one(); break; } ... default: break; } Thanks for the changes, Johan (I look forward to the release of the new site!)

4 4

[Templates] Report
by Jan Darowski 18 Sep '13

18 Sep '13

Hi! This week I added loading procedural templates into my widget so they could be listed next to the static templates. This required some changes in the current NewFromTemplate code but it's functionality remains unchanged. Slagvi, Jan Darowski

3 7

Filter Display and Cache
by Martin Owens 17 Sep '13

17 Sep '13

Hey Devs, I've just pushed r12525 which should fix an error where moving filtered items wasn't using the right bbox. http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12525 What concerns me is two things: That this was effecting text elements, but not other items suggests that _bbox and _item_bbox were different for text but not for other items. Which is odd and should probably be fixed too. The other is that I've removed the now unused compute_drawbox. It mentioned converting to user units and I may have inadvertently hurt something there by using area_enlarge instead. Any unit people want to confirm this is safe or unsafe? And I didn't even get to fix the original bug I was after. ;-) Best Regards, Martin Owens

3 2

Re: [Inkscape-devel] Trunk compiled with extensions and program-preffix or suffix
by Markus Engel 17 Sep '13

17 Sep '13

> Any body know how to get inkscape extensions workingin a trunk configured with program-preffix or program-sufix. > I only want to have full working both 0.48.3 and myown version of main trunk. If is another way... > I test symlinks from inkscape to jtx-inkscape and noresult. > Thanks in advance Jabier. Hello Jabier, I think for testing it's best if you install your trunkinkscape into a separate folder. Let's say you've got your sources in/home/jabier/Inkscape/trunk, then you should build it like that: ./autogen.sh ./configure --prefix=/home/jabier/Inkscape/trunk_install make make install You can then run src/inkscape and it will find the filesin your local trunk_install directory. I hope I got you right. Regards, Markus

2 1

Trunk compiled with extensions and program-preffix or suffix
by Jabiertxo Arraiza Cenoz 17 Sep '13

17 Sep '13

Hello. Any body know how to get inkscape extensions working in a trunk configured with program-preffix or program-sufix. I only want to have full working both 0.48.3 and my own version of main trunk. If is another way... I test symlinks from inkscape to jtx-inkscape and no result. Thanks in advance Jabier.

1 0

Gimp Watch
by Martin Owens 17 Sep '13

17 Sep '13

Hey Devs, I'm going to keep an eye on this gimp project: http://funding.openinitiative.com/funding/1578/ The important thing to note for any crowd funding campaign is how easily it is to get the information to fans (in our case, users). If Gimp can reach out to their genuine user base and get artists into the feature, then they stand a chance. OTOH if they can only communicate to other developers, or a selection of users who are fanatical. Then the funding will be hard to raise. This is an important question campaigns like this will face if we want them to be successful. Best Regards, Martin Owens

1 0

[Units] Bug Fixes
by Matthew Petroff 16 Sep '13

16 Sep '13

I've spent the past two weeks fixing bugs in my viewBox based document unit implementation, and just about everything is working properly now. http://www.mpetroff.net/archives/2013/09/15/bug-fixes/ -Matthew

3 4

Mac OS X Build 0.48.4 RC1
by Valerio Aimale 16 Sep '13

16 Sep '13

This is a good build that is close to being a release: For Mountain Lion http://rapidshare.com/files/4204947016/Inkscape-r0.48.4-r9943-10.8%2B-x86_6… For Lion: http://rapidshare.com/files/3505176415/Inkscape-r0.48.4-r9943-10.7%2B-x86_6… - the menu should be all working but the "Open Recent" submenu. No matter which item is selected, the top open is always opened. This is a bug between gtk/gtk_recent_menu_manager() and gtk-mac-integration. Needs more analysis, not an easy fix. - Quit, About and Preferences menu items moved under the app menu. - python should be fully working now on Lion and Mountain Lion - uniconvertor/sk1libs installed and fixed The sk1libs/utilsfs.py line return ['/'] really should be return ['/System/Library/Fonts', '/Library/Fonts', os.path.expanduser("~/Library/Fonts")] - no more noise on the terminal stderr - bunch of improvements and changes in the build system

8 27

Fix for blocker bug #953992, Imported pattern fill disappers while transforming (regression)
by Diederik van Lierop 14 Sep '13

14 Sep '13

Hi devs, I might just have fixed this blocker bug: https://bugs.launchpad.net/inkscape/+bug/953992; well at least the problem cannot be reproduced and I haven't noticed any new regressions, but I am not sure if this fix is correct. Let me try to explain: When a pattern is imported, e.g. from Adobe Illustrator, then it might have a view box set. This is just fine, as this viewbox is accounted for by Inkscape. Now when an object that uses this pattern is moved, a new pattern is introduced to account for the translation. So we now have: object -> mother pattern (with transform) -> child pattern (as imported) The child pattern has a view box set, but the current code only considered the viewbox of the newly introduced mother pattern... which didn't have a viewbox set. This is why the pattern wasn't drawn. I've modified the code to consider the viewbox of the child pattern instead. This works for the files attached to the bug report, and doesn't seem to break anything. However, isn't this all a bit too fragile? What if both the mother pattern and child pattern have a view box set? Is there a teeny-tiny wibbly-wobbly subset of documents in which this can actually occur? ;-). BTW, our stock patterns do not have a viewbox, and neither do patterns generated from objects. This is why this bug was only visible for imported patterns. Also, this bug was introduced when moving to the new cairo rendered in which a significant part of pattern rendering code (in sp-pattern.cpp) was modified. Thanks, Diederik

2 1

Patch review needed for bug #1127103 (Colour change on blurred elements with a transform) (blocker)
by su_v 14 Sep '13

14 Sep '13

It would be great if someone familiar with the rendering of SVG filter effects and colorspaces for SVG filters could review the latest patch in - Bug #1127103 “Colour change on blurred elements with a transform” <https://bugs.launchpad.net/inkscape/+bug/1127103> Summary: Blurred objects which have a 'matrix()' transformation, or are inside a container with such a 'matrix()' transformation, may render with a different (darker) shade of the original color, depending on whether or not the filter definition of the blur has the style property 'color-interpolation-filters:sRGB' added: - with 'color-interpolation-filters:sRGB': original color - without 'color-interpolation-filters:sRGB': darker shade of color Affects: - transformed blurred objects in documents created with stable versions - transformed objects blurred via 'Fill & Stroke' with current trunk Does not affect: - transformed objects blurred via Filter Editor with current trunk Proposed patch: Comments by patch author: "I think the best thing we can do is set a defautl render colorspace. (…) i made the change for use sRGB instead linearRGB by default. Now the file opens OK but im not sure about others problems. Tav has some post about linearRGB in filters..." Direct link to proposed diff: <https://bugs.launchpad.net/inkscape/+bug/1127103/+attachment/3813130/+files…>

2 1

Opening Adobe SVG: Fix for 166371
by Martin Owens 14 Sep '13

14 Sep '13

Hey Devs, I really do need some other developers to go over the proposed fix for 166371. I'd like to know it's not a crazy fix considering what it does if a file fails to load. https://code.launchpad.net/~doctormo/inkscape/fix166371/+merge/185064 Don't worry, it's not a large change. Best Regards, Martin Owens

5 13

Fixed 1215575
by Johan Engelen 12 Sep '13

12 Sep '13

Hi all, I reverted the change that created bug 1215575. Thanks for confirming the fix, (also for the related bugs mentioned in that report?) Cheers, Johan

2 1

Windows build fail
by Johan Engelen 11 Sep '13

11 Sep '13

Hi all, compilation of /src/ui/clipboard.cpp fails on Windows: Make error line 298: problem compiling: src/ui/clipboard.cpp: In member function 'Glib::ustring Inkscape::UI::ClipboardManagerImpl::_getBestTarget()': src/ui/clipboard.cpp:1245:20: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp:1253:16: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp: In member function 'void Inkscape::UI::ClipboardManagerImpl::_setClipboardTargets()': src/ui/clipboard.cpp:1317:42: error: 'CLIPBOARD_WIN32_EMF_MIME' was not declared in this scope Thanks for fixing. -Johan

2 1

Review lastFromClipboard
by Jabiertxo Arraiza Cenoz 11 Sep '13

11 Sep '13

Thanks for the review Krzysztof. Anybody confirm about first point? If is wrong with no manual XML modification... Second point. Any body can help me? Third point is bad because i like the strokes like the original, I dislike force the style to black and always filled. If is posibol to continue with it i need a better name...you are welcome. Hi, Jabier. El lun, 09-09-2013 a las 15:54 +0000, Krzysztof Kosinski escribió: > Review: Disapprove > > 1. This feature is misleadingly named. It will apply the first stroke shape encountered in the defs. As far as I know, there is no guarantee on the order of defs. > > 2. The line "if (pattern == (const gchar *)"M 0,0 1,0") continue;" is wrong - you can't test for pointer equality even when one of the strings is constant. > > 3. Confusing control flow around the "shape_applied" variable. It should default to false and be set to true inside the if. -- https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… You are the owner of lp:~jabiertxof/inkscape/lastFromClipboard.

2 4

Release and Website
by Martin Owens 11 Sep '13

11 Sep '13

Hey Devs, I noticed the render bug was patched, how long do we think we'll have before we do a new release? As for the release of the staging website, I'm still planning on releasing what ever content we have in Novemeber 14th to live. I figure everyone will be happy with it by then. It'd be nice to get a new release ready for then too, but that might be too short notice considering all the changes and probable other bugs. Thoughts? Martin Owens

9 20

Propose to merge "lastFromClipboard"
by Jabiertxo Arraiza Cenoz 09 Sep '13

09 Sep '13

Hi to all. I just propose to merge my new little branch. For more details, see: https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… Add a dropdown item to the path stroke list in pen/cil mode. It get the last applied path from the clipboard, making unnecesary retain the desired path in the clipboard. Best regards, Jabier.

1 0

Propose to merge
by Jabiertxo Arraiza Cenoz 09 Sep '13

09 Sep '13

Hi to all. I just propose to merge my new little branch. For more details, see: https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… Add a dropdown item to the path stroke list in pen/cil mode. It get the last applied path from the clipboard, making unnecesary retain the desired path in the clipboard. Best regards, Jabier.

1 0

[GSOC] The end is in sight.
by Tavmjong Bah 09 Sep '13

09 Sep '13

Hi, The GSOC coding period will end in two weeks. (The suggested 'pencils down' date is the 16th with the final date the 23rd.) Now is the time for students and mentors to agree on what tasks need to be finished for a final pass. We have the expectation that your code will be ready for check-in. It is better to have a smaller set of features done that are well tested than a larger set with bugs! Mentors must submit final evaluations by the 27th. Passing students need to submit code samples to Google after the final evaluation. Good luck, Tav

1 0

cannot compile rev 12501 (Windows XP)
by alvinpenner 07 Sep '13

07 Sep '13

attempting to compile rev 12501 I get the messages: Make error line 298: problem compiling: src/ui/clipboard.cpp: In member function 'Glib::ustring Inkscape::UI::ClipboardManagerImpl::_getBestTarget()': src/ui/clipboard.cpp:1245:20: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp:1253:16: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp: In member function 'void Inkscape::UI::ClipboardManagerImpl::_setClipboardTargets()': src/ui/clipboard.cpp:1317:42: error: 'CLIPBOARD_WIN32_EMF_MIME' was not declared in this scope rev 12496 compiled normally. Alvin Penner -- View this message in context: http://inkscape.13.x6.nabble.com/cannot-compile-rev-12501-Windows-XP-tp4967… Sent from the Inkscape - Dev mailing list archive at Nabble.com.

3 2

Re: [Inkscape-devel] [cairo] Tentative patch for downscaling in Cairo
by Tavmjong Bah 05 Sep '13

05 Sep '13

On Thu, 2013-09-05 at 16:17 +0100, Chris Wilson wrote: > On Sun, Mar 31, 2013 at 05:03:36AM +0200, Krzysztof Kosiński wrote: > > Hello > > > > I had a look at how complex would it be to add correct downscaling to > > Cairo now that Pixman supports convolution filters. It turns out it > > this is rather easy. Here is an initial, minimal attempt. It uses > > convolution filters only if the image is being downscaled by more than > > half a pixel in at least one dimension. > > > > Some discussion: > > > > 1. The sampling and reconstruction kernels are picked in a way that > > gives comparable quality when upscaling and downscaling. I paired box > > sampling with bilinear reconstruction and impulse (point) sampling > > with box reconstruction. This gives the expected result for NEAREST > > filter. BEST filter uses Lanczos3 for both kernels. > > > > 2. Subsampling bits are always set to 1, since this doesn't seem to > > affect quality at all. > > > > 3. I am not sure whether this code works correctly for matrices with a > > skew component. It should be OK for any combination of scale, rotation > > and translation. > > > > 4. This patch causes new failures in the test suite: > > - recording-surface*: possibly an effect of improved quality. > > - surface-pattern-scale-down*, surface-pattern-big-scale-down: the > > reference images should be updated. > > - pthread-same-source: I have no idea why this is failing, since this > > test shouldn't even trigger the new code. > > - large-source-roi: this test attempts to downscale an image which is > > 30000 pixels wide down to 7 pixels. The filter parameters seem to be > > created correctly, but they might trigger an overflow somewhere in the > > convolution code; the output rectangle is white instead of red, as if > > nothing was drawn. > > - device-offset-scale: there are subtle differences which look like > > convolution-related smoothing; I'm not sure whether this is OK or not. > > > > Note that master currently fails many more tests, I only listed new > > failures cause by this patch. > > Merged to cairo-1.13, many thanks. > -Chris Excellent!

1 0