- Inkscape Devel - Inkscape Mailman

Trunk is broken enough to merit complaining
by Josh Andler 29 Jan '14

29 Jan '14

Hey All, Thankfully it's been a while since this has been an issue, but it seems that a reminder is needed. The only real rule we tend to have for committing to trunk is "don't break trunk". Unfortunately, trunk is currently pretty broken when trying to work with imported bitmaps. If whomever broke it can get back to fixing it, it would be greatly appreciated. In the future, just remember, if you won't have the free time within 1 day to fix something you might have accidentally broken... please wait to commit it until you do. If you can not figure out an appropriate fix, please revert the changes and work via patches in the tracker or in a branch until you can figure it out (so others can help test). Cheers, Josh

3 2

Re: [Inkscape-devel] Trunk is broken enough to merit complaining
by mathog 29 Jan '14

29 Jan '14

> Thankfully it's been a while since this has been an issue, but it > seems that a reminder is needed. The only real rule we tend to have > for committing to trunk is "don't break trunk". Unfortunately, trunk > is currently pretty broken when trying to work with imported bitmaps. > If whomever broke it can get back to fixing it, it would be greatly > appreciated. It's more broken than that, unfortunately, since on my Ubuntu test machine the inkscape binaries from 12978 on no longer even get to the point where they put any graphics on the screen. The reason it is crashing is complex enough that it really is above and beyond the call of duty for other developers to have to figure it out. (For instance, the failure mode is different in the debugger than outside of it.) So, Martin, please pull out all of the image changes from around 12939 through 12978 and test them for a while in a separate branch. Before resubmitting them to trunk, please have people test your branch on other platforms. Or at the very least run valgrind on it and make sure there are no (new) memory access issues in the code you are adding. (Admittedly this is a bit of a pain since there are already so many memory issues in Inkscape.) These image changes must have worked on Martin's machine, presumably because the memory problems didn't happen to blow up anything there, but they are show stoppers for me. Thanks, David Mathog mathog@...1176... Manager, Sequence Analysis Facility, Biology Division, Caltech

1 0

Writing Tests for URI
by Martin Owens 29 Jan '14

29 Jan '14

Hi devs, I want to write a test suite for uri.h/uri.cpp; I had a look to see if there are existing tests for the code and I admit I find myself a little confused. There's a directory called cxxtest which contains tests and then there are *-test.h files in the actual codebase. My feeling is to use extract-uri-test.h, copy it for a new uri-test.h file. But this might be wrong. New URI functionality includes: dealing with data uri, getting full path name (previous work) and further intergration between it and io/uristream.cpp to feed that lovely data in transparently when needed. Should conclude with the ability to quickly move any href from attribute to workable data. Martin,

2 1

Bug Hunt for 0.91
by Bryce Harrington 29 Jan '14

29 Jan '14

Welcome to the first bug hunt for the 0.91 release. This hunt focuses on regression bugs. Traditionally, we specify a point target for us to reach, and award us points based on the severity of the bug: 3, 6, 9, or 12 points for low, medium, high, and critical. This bug hunt's goal is 500 points worth of bugs from the following list: http://tinyurl.com/bughunt91a You'll note a few dozen regressions were already fixed, so we'll count that as a (207 point) headstart on the effort. Here's a couple more links to list only the open or closed bugs: http://tinyurl.com/bughunt91a-open http://tinyurl.com/bughunt91a-closed [I'll write a launchpadlib script to calculate the score from the latter list, unless someone's ambitious and beats me to it!] We only give points for true bug fixes - not bugs simply closed due to being dupes, invalid, works-for-me, or whatnot. Once the bug is fixed in the mainline branch, set its status to Fix Committed, and it'll tally as a fixed regression. Bug Hunt Goal: 500 points Current: 207 points If you're not a developer, you can still help by seeing if you can reproduce the bug yourself, and posting your findings. If you have an idea on how to fix the bug, but don't have the time to do it yourself, then outlining your thoughts on the bug may help junior developers pick it up and implement the changes. If you're an experienced developer, consider posting an invitation to an IRC bug party for the time period you'll be working, if you're willing to help pilot junior developers and sponsor their patches. I will be posting scoring updates a couple times a week until we're done. Bryce

4 9

Cairo and ISO C++
by Tavmjong Bah 28 Jan '14

28 Jan '14

Hi, There is a proposal before the ISO C++ standards group for a technical specification for 2D graphics based on the Cairo API.[1] It seems to have gained some traction. My question here is what is missing in the Cairo API that would be useful for rendering SVG? Tav [1] http://isocpp.org/files/papers/N3888.pdf

3 3

Strange Error
by Arshdeep Singh 26 Jan '14

26 Jan '14

Hi, I participated is GSoC 2013 and wrote code for Inkscape. I was working in WIndows last year and sometime around December I decided to port my branch to Linux (Ubuntu 12.10 , in my case) . Strangely, I am caught up with this error, which doesn't trouble me at all in my Windows branch: "ui/dialog/dialog-manager.o: In function `Inkscape::UI::Dialog::RecolorArtwork::getInstance()': /home/arshdeep/Desktop/InkS-Repo/recolor/src/./ui/dialog/recolor-artwork.h:38: undefined reference to `Inkscape::UI::Dialog::RecolorArtwork::RecolorArtwork()' collect2: error: ld returned 1 exit status " This happens only when I am associating a dialog box of the tool that I made last year thorugh the codeline: " registerFactory("RecolorArtwork", &create<RecolorArtwork, FloatingBehavior>); " inside of dialog-manager.cpp. The RecolorArtwork class is mirrored directly from FillAndStroke class and I can't pin point why this error crops up ? If someone can help , please do so. -- Arshdeep Singh Third Year, Computer Engineering Delhi Technological University Ph: +91-9654115614 https://sites.google.com/site/adsingh1729/home

1 1

Simple String Handling
by Martin Owens 25 Jan '14

25 Jan '14

Hi devs, I've tried out the following patch: http://paste.ubuntu.com/6809633/ And it's not working. The path which used to work well, it now being overwritten with garbage data before the file can be opened. As if the reference has been freed. I'm sure it's something simple to do with those consts or gchar types. Any ideas? Example output: ** (inkscape:4946): WARNING **: Can't open file: /home/doctormo/D\x89 \x99 (doesn't exist) ** (inkscape:4946): WARNING **: Can't get document for referenced URI: inner.svg#bar Martin,

3 3

Removal of popt
by Krzysztof Kosiński 24 Jan '14

24 Jan '14

Hello The bug which is keeping us with popt has been recently fixed. https://bugzilla.gnome.org/show_bug.cgi?id=722025 This means we can remove several kb of code and remove one of our dependencies by changing command line parsing from popt to GOption. Since the bug was Windows-specific, we can do this once the next stable version of glib is released. Regards, Krzysztof

4 5

Re: [Inkscape-devel] Why is the position of this line of code so touchy?
by Krzysztof Kosiński 24 Jan '14

24 Jan '14

2014/1/24 mathog <mathog@...1176...>: >> This line is completely equivalent to replacing it with a call to >> cairo_save and adding a call to cairo_restore at the very end of the >> containing scope. >> >> You cannot move this line into a different function, because then the >> destructor (and hence cairo_restore) gets called when decorateItem() >> returns. > > Except my code ONLY works if it is moved into another function! That's what > is driving me nuts. I will have to trace this code thoroughly, as there > must be a dangling transformation or an extra cairo_restore or cairo_save > somewhere. Please post a more complete listing of the good and the malfunctioning version of your code. I'm sure we'll find the problem then. The "call, line1, line2" etc. descriptions in your initial e-mail are a little insufficient to figure out what is going on. > I guess. I am not a fan of implicit side effects unless there is absolutely > no way around it. Here > > dc.save() > blah > dc.restore() > > would have worked, and it would have been immediately apparent to a > maintenance programmer what was going on. Or is the ::Save stuff in there > to clean up in case there is an exception and the code jumps to a handler, > without ever returning from these functions? You can add an early return and forget about adding the cleanup code, there can be an exception, or you can simply forget about adding he restore(). The ::Save object ensures proper cleanup in all of those possibilities. Regards, Krzysztof

1 0

C++ explanation please
by mathog 24 Jan '14

24 Jan '14

Sometimes it is hard to shake off decades of C programming, so please bear with. In src/display/drawing-context.h near the top one finds: class DrawingContext : boost::noncopyable { public: class Save { public: Save(); Save(DrawingContext &ct); ~Save(); void save(DrawingContext &ct); private: DrawingContext *_ct; }; and in drawing-context.cpp those methods all use ct and _ct for the variable names. Which is all fine and would be no issue at all, except that below the lines just cited in drawing-context.h every place one finds a reference to ct or _ct it is a cairo_t or a cairo_t*, not a DrawingContext. Can somebody please explain why it is considered helpful in C++ to use "ct" to mean two different things like this in the one header file? The disadvantage of doing it the way it is now is that when somebody like me encounters _ct elsewhere in src/display, and looks for it like this: grep '[\* ]_ct[; {]' src/display/*.h it finds two definitions: DrawingContext *_ct; and cairo_t *_ct; with the end result that one must read the file to figure out what is actually going on. Had the first set used "DC"/"_DC", for instance, there would have been no confusion, and the second step would have been eliminated. Thanks, David Mathog mathog@...1176... Manager, Sequence Analysis Facility, Biology Division, Caltech

4 5