- Inkscape Devel - Inkscape Mailman

Fix for blocker bug #953992, Imported pattern fill disappers while transforming (regression)
by Diederik van Lierop 14 Sep '13

14 Sep '13

Hi devs, I might just have fixed this blocker bug: https://bugs.launchpad.net/inkscape/+bug/953992; well at least the problem cannot be reproduced and I haven't noticed any new regressions, but I am not sure if this fix is correct. Let me try to explain: When a pattern is imported, e.g. from Adobe Illustrator, then it might have a view box set. This is just fine, as this viewbox is accounted for by Inkscape. Now when an object that uses this pattern is moved, a new pattern is introduced to account for the translation. So we now have: object -> mother pattern (with transform) -> child pattern (as imported) The child pattern has a view box set, but the current code only considered the viewbox of the newly introduced mother pattern... which didn't have a viewbox set. This is why the pattern wasn't drawn. I've modified the code to consider the viewbox of the child pattern instead. This works for the files attached to the bug report, and doesn't seem to break anything. However, isn't this all a bit too fragile? What if both the mother pattern and child pattern have a view box set? Is there a teeny-tiny wibbly-wobbly subset of documents in which this can actually occur? ;-). BTW, our stock patterns do not have a viewbox, and neither do patterns generated from objects. This is why this bug was only visible for imported patterns. Also, this bug was introduced when moving to the new cairo rendered in which a significant part of pattern rendering code (in sp-pattern.cpp) was modified. Thanks, Diederik

2 1

Patch review needed for bug #1127103 (Colour change on blurred elements with a transform) (blocker)
by su_v 14 Sep '13

14 Sep '13

It would be great if someone familiar with the rendering of SVG filter effects and colorspaces for SVG filters could review the latest patch in - Bug #1127103 “Colour change on blurred elements with a transform” <https://bugs.launchpad.net/inkscape/+bug/1127103> Summary: Blurred objects which have a 'matrix()' transformation, or are inside a container with such a 'matrix()' transformation, may render with a different (darker) shade of the original color, depending on whether or not the filter definition of the blur has the style property 'color-interpolation-filters:sRGB' added: - with 'color-interpolation-filters:sRGB': original color - without 'color-interpolation-filters:sRGB': darker shade of color Affects: - transformed blurred objects in documents created with stable versions - transformed objects blurred via 'Fill & Stroke' with current trunk Does not affect: - transformed objects blurred via Filter Editor with current trunk Proposed patch: Comments by patch author: "I think the best thing we can do is set a defautl render colorspace. (…) i made the change for use sRGB instead linearRGB by default. Now the file opens OK but im not sure about others problems. Tav has some post about linearRGB in filters..." Direct link to proposed diff: <https://bugs.launchpad.net/inkscape/+bug/1127103/+attachment/3813130/+files…>

2 1

Opening Adobe SVG: Fix for 166371
by Martin Owens 14 Sep '13

14 Sep '13

Hey Devs, I really do need some other developers to go over the proposed fix for 166371. I'd like to know it's not a crazy fix considering what it does if a file fails to load. https://code.launchpad.net/~doctormo/inkscape/fix166371/+merge/185064 Don't worry, it's not a large change. Best Regards, Martin Owens

5 13

Fixed 1215575
by Johan Engelen 12 Sep '13

12 Sep '13

Hi all, I reverted the change that created bug 1215575. Thanks for confirming the fix, (also for the related bugs mentioned in that report?) Cheers, Johan

2 1

Windows build fail
by Johan Engelen 11 Sep '13

11 Sep '13

Hi all, compilation of /src/ui/clipboard.cpp fails on Windows: Make error line 298: problem compiling: src/ui/clipboard.cpp: In member function 'Glib::ustring Inkscape::UI::ClipboardManagerImpl::_getBestTarget()': src/ui/clipboard.cpp:1245:20: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp:1253:16: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp: In member function 'void Inkscape::UI::ClipboardManagerImpl::_setClipboardTargets()': src/ui/clipboard.cpp:1317:42: error: 'CLIPBOARD_WIN32_EMF_MIME' was not declared in this scope Thanks for fixing. -Johan

2 1

Review lastFromClipboard
by Jabiertxo Arraiza Cenoz 11 Sep '13

11 Sep '13

Thanks for the review Krzysztof. Anybody confirm about first point? If is wrong with no manual XML modification... Second point. Any body can help me? Third point is bad because i like the strokes like the original, I dislike force the style to black and always filled. If is posibol to continue with it i need a better name...you are welcome. Hi, Jabier. El lun, 09-09-2013 a las 15:54 +0000, Krzysztof Kosinski escribió: > Review: Disapprove > > 1. This feature is misleadingly named. It will apply the first stroke shape encountered in the defs. As far as I know, there is no guarantee on the order of defs. > > 2. The line "if (pattern == (const gchar *)"M 0,0 1,0") continue;" is wrong - you can't test for pointer equality even when one of the strings is constant. > > 3. Confusing control flow around the "shape_applied" variable. It should default to false and be set to true inside the if. -- https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… You are the owner of lp:~jabiertxof/inkscape/lastFromClipboard.

2 4

Release and Website
by Martin Owens 11 Sep '13

11 Sep '13

Hey Devs, I noticed the render bug was patched, how long do we think we'll have before we do a new release? As for the release of the staging website, I'm still planning on releasing what ever content we have in Novemeber 14th to live. I figure everyone will be happy with it by then. It'd be nice to get a new release ready for then too, but that might be too short notice considering all the changes and probable other bugs. Thoughts? Martin Owens

9 20

Propose to merge "lastFromClipboard"
by Jabiertxo Arraiza Cenoz 09 Sep '13

09 Sep '13

Hi to all. I just propose to merge my new little branch. For more details, see: https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… Add a dropdown item to the path stroke list in pen/cil mode. It get the last applied path from the clipboard, making unnecesary retain the desired path in the clipboard. Best regards, Jabier.

1 0

Propose to merge
by Jabiertxo Arraiza Cenoz 09 Sep '13

09 Sep '13

Hi to all. I just propose to merge my new little branch. For more details, see: https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… Add a dropdown item to the path stroke list in pen/cil mode. It get the last applied path from the clipboard, making unnecesary retain the desired path in the clipboard. Best regards, Jabier.

1 0

[GSOC] The end is in sight.
by Tavmjong Bah 09 Sep '13

09 Sep '13

Hi, The GSOC coding period will end in two weeks. (The suggested 'pencils down' date is the 16th with the final date the 23rd.) Now is the time for students and mentors to agree on what tasks need to be finished for a final pass. We have the expectation that your code will be ready for check-in. It is better to have a smaller set of features done that are well tested than a larger set with bugs! Mentors must submit final evaluations by the 27th. Passing students need to submit code samples to Google after the final evaluation. Good luck, Tav

1 0