- Inkscape Devel - Inkscape Mailman

Opening Adobe SVG: Fix for 166371
by Martin Owens 14 Sep '13

14 Sep '13

Hey Devs, I really do need some other developers to go over the proposed fix for 166371. I'd like to know it's not a crazy fix considering what it does if a file fails to load. https://code.launchpad.net/~doctormo/inkscape/fix166371/+merge/185064 Don't worry, it's not a large change. Best Regards, Martin Owens

5 13

Fixed 1215575
by Johan Engelen 12 Sep '13

12 Sep '13

Hi all, I reverted the change that created bug 1215575. Thanks for confirming the fix, (also for the related bugs mentioned in that report?) Cheers, Johan

2 1

Windows build fail
by Johan Engelen 11 Sep '13

11 Sep '13

Hi all, compilation of /src/ui/clipboard.cpp fails on Windows: Make error line 298: problem compiling: src/ui/clipboard.cpp: In member function 'Glib::ustring Inkscape::UI::ClipboardManagerImpl::_getBestTarget()': src/ui/clipboard.cpp:1245:20: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp:1253:16: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp: In member function 'void Inkscape::UI::ClipboardManagerImpl::_setClipboardTargets()': src/ui/clipboard.cpp:1317:42: error: 'CLIPBOARD_WIN32_EMF_MIME' was not declared in this scope Thanks for fixing. -Johan

2 1

Review lastFromClipboard
by Jabiertxo Arraiza Cenoz 11 Sep '13

11 Sep '13

Thanks for the review Krzysztof. Anybody confirm about first point? If is wrong with no manual XML modification... Second point. Any body can help me? Third point is bad because i like the strokes like the original, I dislike force the style to black and always filled. If is posibol to continue with it i need a better name...you are welcome. Hi, Jabier. El lun, 09-09-2013 a las 15:54 +0000, Krzysztof Kosinski escribió: > Review: Disapprove > > 1. This feature is misleadingly named. It will apply the first stroke shape encountered in the defs. As far as I know, there is no guarantee on the order of defs. > > 2. The line "if (pattern == (const gchar *)"M 0,0 1,0") continue;" is wrong - you can't test for pointer equality even when one of the strings is constant. > > 3. Confusing control flow around the "shape_applied" variable. It should default to false and be set to true inside the if. -- https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… You are the owner of lp:~jabiertxof/inkscape/lastFromClipboard.

2 4

Release and Website
by Martin Owens 11 Sep '13

11 Sep '13

Hey Devs, I noticed the render bug was patched, how long do we think we'll have before we do a new release? As for the release of the staging website, I'm still planning on releasing what ever content we have in Novemeber 14th to live. I figure everyone will be happy with it by then. It'd be nice to get a new release ready for then too, but that might be too short notice considering all the changes and probable other bugs. Thoughts? Martin Owens

9 20

Propose to merge "lastFromClipboard"
by Jabiertxo Arraiza Cenoz 09 Sep '13

09 Sep '13

Hi to all. I just propose to merge my new little branch. For more details, see: https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… Add a dropdown item to the path stroke list in pen/cil mode. It get the last applied path from the clipboard, making unnecesary retain the desired path in the clipboard. Best regards, Jabier.

1 0

Propose to merge
by Jabiertxo Arraiza Cenoz 09 Sep '13

09 Sep '13

Hi to all. I just propose to merge my new little branch. For more details, see: https://code.launchpad.net/~jabiertxof/inkscape/lastFromClipboard/+merge/18… Add a dropdown item to the path stroke list in pen/cil mode. It get the last applied path from the clipboard, making unnecesary retain the desired path in the clipboard. Best regards, Jabier.

1 0

[GSOC] The end is in sight.
by Tavmjong Bah 09 Sep '13

09 Sep '13

Hi, The GSOC coding period will end in two weeks. (The suggested 'pencils down' date is the 16th with the final date the 23rd.) Now is the time for students and mentors to agree on what tasks need to be finished for a final pass. We have the expectation that your code will be ready for check-in. It is better to have a smaller set of features done that are well tested than a larger set with bugs! Mentors must submit final evaluations by the 27th. Passing students need to submit code samples to Google after the final evaluation. Good luck, Tav

1 0

cannot compile rev 12501 (Windows XP)
by alvinpenner 07 Sep '13

07 Sep '13

attempting to compile rev 12501 I get the messages: Make error line 298: problem compiling: src/ui/clipboard.cpp: In member function 'Glib::ustring Inkscape::UI::ClipboardManagerImpl::_getBestTarget()': src/ui/clipboard.cpp:1245:20: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp:1253:16: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope src/ui/clipboard.cpp: In member function 'void Inkscape::UI::ClipboardManagerImpl::_setClipboardTargets()': src/ui/clipboard.cpp:1317:42: error: 'CLIPBOARD_WIN32_EMF_MIME' was not declared in this scope rev 12496 compiled normally. Alvin Penner -- View this message in context: http://inkscape.13.x6.nabble.com/cannot-compile-rev-12501-Windows-XP-tp4967… Sent from the Inkscape - Dev mailing list archive at Nabble.com.

3 2

Re: [Inkscape-devel] [cairo] Tentative patch for downscaling in Cairo
by Tavmjong Bah 05 Sep '13

05 Sep '13

On Thu, 2013-09-05 at 16:17 +0100, Chris Wilson wrote: > On Sun, Mar 31, 2013 at 05:03:36AM +0200, Krzysztof Kosiński wrote: > > Hello > > > > I had a look at how complex would it be to add correct downscaling to > > Cairo now that Pixman supports convolution filters. It turns out it > > this is rather easy. Here is an initial, minimal attempt. It uses > > convolution filters only if the image is being downscaled by more than > > half a pixel in at least one dimension. > > > > Some discussion: > > > > 1. The sampling and reconstruction kernels are picked in a way that > > gives comparable quality when upscaling and downscaling. I paired box > > sampling with bilinear reconstruction and impulse (point) sampling > > with box reconstruction. This gives the expected result for NEAREST > > filter. BEST filter uses Lanczos3 for both kernels. > > > > 2. Subsampling bits are always set to 1, since this doesn't seem to > > affect quality at all. > > > > 3. I am not sure whether this code works correctly for matrices with a > > skew component. It should be OK for any combination of scale, rotation > > and translation. > > > > 4. This patch causes new failures in the test suite: > > - recording-surface*: possibly an effect of improved quality. > > - surface-pattern-scale-down*, surface-pattern-big-scale-down: the > > reference images should be updated. > > - pthread-same-source: I have no idea why this is failing, since this > > test shouldn't even trigger the new code. > > - large-source-roi: this test attempts to downscale an image which is > > 30000 pixels wide down to 7 pixels. The filter parameters seem to be > > created correctly, but they might trigger an overflow somewhere in the > > convolution code; the output rectangle is white instead of red, as if > > nothing was drawn. > > - device-offset-scale: there are subtle differences which look like > > convolution-related smoothing; I'm not sure whether this is OK or not. > > > > Note that master currently fails many more tests, I only listed new > > failures cause by this patch. > > Merged to cairo-1.13, many thanks. > -Chris Excellent!

1 0