- Inkscape Devel - Inkscape Mailman

Any blockers for 0.48.2?
by Josh Andler 27 Jun '11

27 Jun '11

Subject asks the important stuff. :) Cheers, Josh

3 3

problems in compiling on windows
by Abhinav Vishwa 27 Jun '11

27 Jun '11

I have compiled Inkscape completely according to instructions given on this link http://wiki.inkscape.org/wiki/index.php/Win32Port but as given there is no executable in the inkscape directory. That's why nsis installer is also giving error in creating installer.

2 1

New rendering bug with blur filter
by Ivan Louette 27 Jun '11

27 Jun '11

(Sorry, my bitmap was too big at first time) This bug doesn't exist in 0.48.1 I saw it this morning in rev 10355 on Kubuntu Couls someone confirm it before I fill it on Launchpad ? When blur is combined with a Composite "in" some vertical dark lines are shown on rendering and exporting to bitmap. If vertical blur is set to zero the lines change to dots. If a little amount of black is added they disappear (here I decrease luminance and that works too). ivan

3 2

Code cleanup and minor tweaks
by Jon Cruz 27 Jun '11

27 Jun '11

Hi Campbell, I just wanted to thank you for the recent improvement to our codebase, such as in revision 10359. Getting things fixed such as not passing 'false' in to pointers helps in many ways, including reducing the number of odd, hard to reproduce bugs. I also just wanted to point out a few minor style points that could help. One is with the use of "NULL". That is more of a C macro that in C++ has be replaced with the simple use of "0". I've looked into this point with coworkers and others at various points, and can try to dig up more details if you need them. The other point is in using whitespace. I realize that in your recent changes you have been preserving what already existed, but it is helpful if "cleanup" that touched lines left them with nicer spacing also. We have some info on our coding style page, but the gist is to put spaces between things, but not in the middle of things. :-) That is, space around keywords, operators, etc, but not between a function name and its opening paren. For example, this line you touched could be improved by spacing it thusly &&((l!=NULL&&!edge->isEnd(l->id))||l==NULL) && ((l != NULL && !edge->isEnd(l->id)) || l == NULL) Suddenly that makes the logic and the referencing easier to read and follow. It also gives more visibility to areas that could be made clearer with more parenthesis: && (((l != NULL) && !edge->isEnd(l->id)) || (l == 0) ) if I compare those right on top of each other, the legibility change should show up: &&((l!=NULL&&!edge->isEnd(l->id))||l==NULL) && (((l != NULL) && !edge->isEnd(l->id)) || (l == 0) ) Depending on the font, that might even reveal another problem. In general I strongly dislike single-letter literals (except for the common 'i' in for loops, etc). And even worse is the single letter variable 'l'. In fact, in the font I'm typing with at the moment I can not tell the difference between the lower-case-letter-el, the capital-letter-eye and the vertical-bar-pipe-| (lI|). What is worse is some fonts even make the numeral -one indistinguishable. But this is a side rant on a given bad variable. If you happen to be touching enough lines, consider giving it a better name. Anyway, thanks for the help in this area and the opportunity for me to point out to some of the other newer people on the list what sort of tweaks can help our codebase be more legible and maintainable.

3 5

Extensions and Warnings
by Martin Owens 26 Jun '11

26 Jun '11

I'm trying to solve a bug with my deviantArt stash extension. It produces warnings because poxy webkit with bleedin java and god aweful html decide that it's a great idea to shout out to the world a whole bunch of version information, including any javascript errors that happen in the loaded pages. What cute is that I told the inx to load a bash shell which loaded the python script and to dev/null everything. That didn't hack fix it. I tried redirecting sys.stderr to a file, somehow it still manages to come through. Please tell me there is a way to stop inkscape from reporting warnings from python extensions? There is no reason to report warnings to users unless they can be formatted in a nice way and these can't be. Martin,

2 1

New rendering bug with blur filter
by Ivan Louette 25 Jun '11

25 Jun '11

This bug doesn't exist in 0.48.1 I saw it this morning in rev 10355 on Kubuntu Couls someone confirm it before I fill it on Launchpad ? When blur is combined with a Composite "in" some vertical dark lines are shown on rendering and exporting to bitmap. If vertical blur is set to zero the lines change to dots. If a little amount of black is added they disappear (here I decrease luminance and that works too). ivan

1 0

Build and Devlibs
by Yann Papouin 25 Jun '11

25 Jun '11

Hi, It seems that 3 DLLs are not copied from the mingw/bin directory for the dist target, I had to copy them myself : libgcc_s_dw2-1.dll libpthread-2.dll libstdc++-6.dll Yann.

3 4

Typo/Bug in sp-attribute-widget.cpp
by Campbell Barton 25 Jun '11

25 Jun '11

In function: sp_attribute_widget_object_modified if (flags && SP_OBJECT_MODIFIED_FLAG) { Shouldn't this be '&' not '&&' ? -- - Campbell

2 2

Now the cairo branch is merged...
by Joel Holdsworth 24 Jun '11

24 Jun '11

...would a release be in order? I remember we were longing for Cairo back in 2006! This branch merge is a very big deal! Joel

6 7

Font fall back support for inkscape
by Abhishek Sharma 24 Jun '11

24 Jun '11

Hello everybody, I am a selected candidate for GSoC 2011 and contributed to inkscape in GSoC 2010 as well. I am looking to start the development of font fall back support in inkscape. As discussed with my mentor Tavmjong its a required item and shall be very helpful to inkscape. And as all the readers of this mail might have guessed, I am writing this mail to have the inputs of inskcape developers on this. I would love to have your comments which can help me answer questions like - Where to look into the code, What to change, What to add should it be anew class or an added functionality to a pre-existing class, questions of these sort. Waiting earnestly for all of your responses :) -- Regards, Abhishek Sharma

6 10