- Inkscape Devel - Inkscape Mailman

Idea: Get rid of some .h files by using static signal binding
by Krzysztof Kosiński 21 Feb '09

21 Feb '09

Right now every dialog, extension, etc. has to have a header file - otherwise it's unusable. The underlying issue for dialogs is that there must be an action defined to open them. This means either including the dialog header in verbs.cpp, or wherever the dialog is used. I stumbled over OpenBabel sources some time ago and this gave me the following idea. We put this in some file, e.g. action-manager.h: class ActionManager { ... typedef ActionVector std::vector<Glib::RefPtr<Gtk::Action> >; class GetActionsMarshaller { ... bool marshal(InType x) { _actions.push_back(x); } OutType value() { return _actions; } ActionVector _actions; } ... static ActionManager *get() { static ActionManager *am = new ActionManager(); return am; } Glib::RefPtr<Gtk::ActionGroup> get_document_action_group(Glib::ustring name) { Glib::RefPtr<Gtk::ActionGroup> ag = Gtk::ActionGroup::create(name); ActionVector actions = signal_get_actions.emit(); for(ActionVector::iterator i = actions.begin(); i != actions.end(); ++i) { ag.add(*i); } return ag; } sigc::signal<Glib::RefPtr<Gtk::Action>, GetActionsMarshaller> signal_get_actions; friend class GetActionsMarshaller; }; template<typename T> class ActionManagerEntry { ActionManagerEntry() { ActionManager::get()->signal_get_actions.bind(sigc::ptr_fun(T::create)); } }; Then in the dialog file we put this: class ShowSomeDialogAction : public Gtk::Action { ... virtual void on_activate() { SomeDialog::show(); } static Glib::RefPtr<Gtk::Action> create() { return Glib::RefPtr<Gtk::Action>(new ShowSomeDialogAction); } } ActionManagerEntry<ShowSomeDialog> ame_show_some_dialog; And to construct the action group we do this: ActionManager *am = ActionManager::get(); Glib::RefPtr<Gtk::ActionGroup> document_actions = am->get_document_action_group(document_name); What happens here: Each ActionManagerEntry adds a callback to the ActionManager object. This way, the actions are not actually created until GTK is initialized and a document is opened. When we want to create an action group for a document, we send the get_actions signal. The GetActionsMarshaller class marshals the responses we get from the registered callbacks and creates a vector of actions, which are then added to an action group and returned. A similar approach can also be used to get rid of headers and centralized initialization for e.g. extensions What do you think of this approach? On one hand, it scatters the action definitions across many files, but on the other it removes the need for centralized initialization and improves modularity (everything pertaining to a given dialog is in one file, including its actions). Regards, Krzysztof Kosiński -- View this message in context: http://www.nabble.com/Idea%3A-Get-rid-of-some-.h-files-by-using-static-sign… Sent from the Inkscape - Dev mailing list archive at Nabble.com.

1 0

Generic cascading in libcroco
by Robert Staudinger 20 Feb '09

20 Feb '09

Hello, I've finally gotten around to add a generic interface to the libcroco selection engine. Pretty much just exchanging libxml calls to invocations on an vtable provided by the API consumer. On top of that I reinstated the libxml-based API and made sure the tests (the selection engine is only used by test5) work as before. Are you inkscapers still interested in eventually using upstream libcroco? Your internal copy seems to have deviated pretty much from upstream, it would be good if we could at least exchange fixes, things were not quite obvious looking at the raw rdiff. We (Thomas Wood + yours truly) actually tried to extract just the selection engine patch(es) from your svn repository, but it proved quite hard to make any sense of it. My branch is at http://bzr-playground.gnome.org/~robsta/libccss-selection-engine/ but will go to trunk within the next few days, as the tests already work as they should. Best, Rob

3 3

cruft in prefs
by bulia byak 20 Feb '09

20 Feb '09

The "Latency skew" and "Pre-render named icons" options make absolutely zero sense for the user. Especially the former. For the latter, I can at least guess that it's something to do with icons. With "skew", I'm totally at a loss. What latency? Where? When? Tooltip only exacerbates the confusion. Can we please remove them and never, never again add such "options for the developers" to the UI? -- bulia byak Inkscape. Draw Freely. http://www.inkscape.org

6 11

Online Vector Editor
by Josh Andler 20 Feb '09

20 Feb '09

Just passing it on because I found it "interesting". http://www.aviary.com/tools/raven Cheers, Josh

3 3

NEW: spell checker
by bulia byak 20 Feb '09

20 Feb '09

There's now a built-in spell checker. Press Ctrl+Alt+K or choose Text > Check spelling to check all visible text objects in your document (they need not be selected) in turn, going top-to-bottom and left-to-right. Once a misspelled word is found, a red frame around it is displayed, and the object with the misspelling is selected; if you are in Text tool, it also places the text cursor at the beginning of the misspelled word. In the dialog, you can choose one of the listed suggestions and Accept it (this button is disabled unless you choose something in the list); Ignore the word for the rest of this session; or Add the word to the local dictionary. Also, since the dialog does not lock Inkscape's window, you can simply edit the word with Text tool. Once you edit it to something acceptable to the speller, it will automatically turn off the red frame and continue checking the document. On Linux, you need to install Aspell and its dictionaries for the languages you want to check. On Windows, for now, only English dictionary is included with Inkscape builds. My questions: - how do you want to select the language - in the prefs or right in the spellcheck dialog? - should I make this compiled conditionally on linux - will anyone want to compile without spellchecker? - what other languages to include with windows installer? we could take all, but it's many megabytes... -- bulia byak Inkscape. Draw Freely. http://www.inkscape.org

7 15

OpenMP, encouraging developers, etc
by NoviceNotes℠ 19 Feb '09

19 Feb '09

Admirable Inkscape Developers, and fellow Inkscape Enthusiasts: I'm writing as a proponent of best practices, respecting copyright ownership and ethical use of content, whenever I can not claim it as my own. I realize you are busy with real development issues, and this looks like a long-winded message (it is, sorry), but I imagine you are the proper contact for addressing this proposal. Having just read the the "OpenMP Is Coming" news byte at inkscape.org [ http://inkscape.org/archive.php?lang=en&year=2009&month=01 ] , I would like to make myself available to you-- not as an expert in multi-processor; multi-threading efficiency maximization for the application-- but as an additional resource for propagating information about Inkscape. I seek authorization-- ideally the blessing of Inkscape developers and primary contributors-- to publish an article (on my own web site, available at http://NoviceNotes.Net . NoviceNotes℠) containing text copied, verbatim (or, as recommended), from the aforementioned "News" section of Inkscape.org . Because I use Inkscape daily, usually for multiple, separate design or illustrative tasks, I have a vested interest in the gainful advancement of the Inkscape project. I appreciate your need for the most accommodating crew in the development team complement. Rest assured that I would not burden the team on my own whimsy; that my proposed use of inkscape.org content is bourne of a primary intent to act as an asset-- a disseminating agent, bolstering Inkscape's list of proponents. I have no interest in exploiting Inkscape that I might enjoy the privilege of association, favoring integrity over content padded in that ubiquitous manner. Please take a moment to read the article I wrote on Geany, a GTK+ text editor which I use quite often, as my enthusiasm for Inkscape inspires a similar viewpoint: http://tinyurl.com/NoviceNotes-on-Geany I hope this note reaches the appropriate party. I look forward to a reply. Respectfully, Jeff Sabarese Author: NoviceNotes.Net -- For beginner Web Technologists, and pros, their fees well-spent, For entertainment mixed in tutelage, I strive at NoviceNotes.Net

1 0

Fwd: [CREATE] Categorizing resources
by Jon Phillips 19 Feb '09

19 Feb '09

Here is an interesting proposal about how to handle resources. Please join the Create mailing list if you are interested in this and/or for Inkscape. It is a nice way to handle a quick way of organizing resources. Jon ---------- Forwarded message ---------- From: Aurimas Juška <aurimas.juska@...400...> Date: Wed, Feb 18, 2009 at 12:25 PM Subject: Re: [CREATE] Categorizing resources To: CREATE@...626... Hi, Resource tagging is now available in GIMP development version. Before it is released, I think it would be good to discuss possibilities how tags could be shared between applications and also how tagging could be implemented in other applications. Common (standardized?) tag storage format Currently GIMP tags storage format is minimalistic, but seems to work quite well. Tags are stored in a tags.xml file which can be easily understood and edited manually: <?xml version='1.0' encoding='UTF-8'?> <tags> <resource identifier="/home/auris/gimp/trunk/build/share/gimp/2.0/brushes/confetti.gih" checksum="d136b60fdd9cf41693a485a329b32e95"> <tag>aaa</tag> </resource> </tags> Resources are mapped with entries in tags.xml using: * identifier - filename for resources stored on disk. Easy to understand, but can be different between computers and platforms. * checksum - uniquely represent resource. However, how checksum is calculated (which data from resource is used, algorithm) seem hard to standardize. Useless when user wants to edit tags.xml manually (or with a simple script). Currently identifier is used primarily to identify resources, and checksum is only used when identifier can't match actual resource file (file rename/move). Tag is a text string which cannot contain separator characters, newlines, tabs, etc. There is no additional information stored with a tag, such as language. However, tags provided with GIMP can be translated into various languages. Localized version is installed in user's home directory on the first run but is not changed when switched to a different language later. In order to make format useful for other applications and external tag editors as well, is there anything that should be added/removed ? It would be good, as always, to keep the format simple as possible. Common GUI elements It might be good for user if similar GUI element would be used for similar purposes. There is a small PDF available which shows more detail how tagging GUI elements work in GIMP: http://sites.google.com/site/aurijusk/gimp-resource-tagging/tagging.pdf?att… Code reuse for implementation, etc. Some code could probably could be used as starting point. It might be possible to put some functionality in places where multiple applications could take advantage of it. Best regards, Aurimas Juška _______________________________________________ CREATE mailing list CREATE@...626... http://lists.freedesktop.org/mailman/listinfo/create -- Jon Phillips http://rejon.org/

1 0

Re: [Inkscape-devel] [libcroco-list] Generic cascading in libcroco
by Robert Staudinger 19 Feb '09

19 Feb '09

On Thu, Feb 19, 2009 at 4:55 PM, Dodji Seketeli <dodji@...45...> wrote: > Hello, > > Robert Staudinger a écrit : > > [...] > >> I've finally gotten around to add a generic interface to the libcroco >> selection engine. Pretty much just exchanging libxml calls to >> invocations on an vtable provided by the API consumer. >> >> On top of that I reinstated the libxml-based API and made sure the >> tests (the selection engine is only used by test5) work as before. > > Sounds great ! Thanks for that. > >> Are you inkscapers still interested in eventually using upstream >> libcroco? Your internal copy seems to have deviated pretty much from >> upstream, it would be good if we could at least exchange fixes, things >> were not quite obvious looking at the raw rdiff. We (Thomas Wood + >> yours truly) actually tried to extract just the selection engine >> patch(es) from your svn repository, but it proved quite hard to make >> any sense of it. > > I don't know for inkscape, but I'll happily review the patch of that > feature if you for instance submit it to the libcroco bugzilla. > > >> My branch is at >> http://bzr-playground.gnome.org/~robsta/libccss-selection-engine/ >> but will go to trunk within the next few days, as the tests already >> work as they should. > > Could, would it be possible to extract a patch from that and slam it to > bugzilla so that I can have a chance to review it ? I don't intend to > nitpick, do not worry :) It's just to add some more eyeballs to the game :) http://bugzilla.gnome.org/show_bug.cgi?id=572454 - R

1 0

Filters top-level menu?
by Felipe Sanches 18 Feb '09

18 Feb '09

On Wed, Feb 18, 2009 at 3:52 PM, bulia byak <buliabyak@...400...> wrote: > On Wed, Feb 18, 2009 at 1:45 PM, Felipe Sanches > <felipe.sanches@...400...> wrote: >> svn update; make; sudo make install >> >> And I still have the filters submenu inside extensions top level menu. >> And the list of pre-built filters does not appear at the filters top level menu. > > ah - and let me guess - the menus are not in English? Yes, they are in brazillian portuguese. And I guess prokoudine uses russian... Juca

3 3

Filters top-level menu?
by bulia byak 18 Feb '09

18 Feb '09

I think filters are sufficiently complex, different from everything else, and have enough support in Inkscape now, so they deserve to be treated more like a top-level entity. In particular, I propose to add a new menu, Filters, before Effects. It would contain: - All the submenus with preset filter that are now in Effects > Filters. Ivan Louette is working on a huge and exciting expansion of that hierarchy, adding lots of powerful new filters. It's obviously too deeply hidden now, it deserves more visibility as one of the most important 0.47 additions. - The "Filter Effects..." dialog command which I propose to rename to "Build Filters" or "Filter Builder" or something like that. The current name is not very descriptive and even a bit misleading due to the word "effects" which refers to too many too different things in Inkscape (once again, let me reiterate my old wish: rename "Effects" menu to "Extensions", that is what they are!). The typical workflow would be to first choose one of the presets, then if needed, go to the Filter Builder to adjust the preset or start a new filter from scratch. - The Remove Filter command. Thoughts? -- bulia byak Inkscape. Draw Freely. http://www.inkscape.org

8 15