- Inkscape Devel - Inkscape Mailman

Quad PPC from IBM
by Kees Cook 02 Oct '06

02 Oct '06

IBM donated a quad-proc PPC for Inkscape testing. I've finally overcome the weird console problems it was having, and got Ubuntu Dapper installed on it. Bryce and I are going to get Crucible running on it shortly, but until then (and after), anyone who's interested in getting an account on it, please email me your SSH pub key and desired account name. Doing "make -j6" it took about 3min40sec to do a full recompile. :) -- Kees Cook @outflux.net

4 6

WEBFORM Khmer translation (km)
by Khoem Sokhem 02 Oct '06

02 Oct '06

Message from Inkscape submission form Please note, that the submitter may not read this list. CC your answer to the submitter name: Khoem Sokhem email: khoemsokhem@...1503... submitted the following: Hi, I would like khmer translation to be added in SVN Server. And I don\'t know how to upload file to server. Now Khmer translation is almost finished 100%. Thanks, Sokhem

2 1

Cairo changes breaking build
by Jon A. Cruz 02 Oct '06

02 Oct '06

I've hit problems with the Cairo changes from r13107 breaking the build. Specifically, PANGO_GLYPH_EMPTY is undeclared, as is PANGO_GLYPH_UNKNOWN_FLAG. I have cairo 1.2 and pango1-dev 1.10.0 The one value appears to have been added to Pango 1.11.4, and then hidden in 1.11.6. There are also several other warnings that need to get cleaned up at some point, but the build breakage is the main problem for me. I'd hack something in, but I'm not sure of the "proper" fix in this case.

1 0

Re: [Inkscape-devel] inkscape and SVG Tiny
by Jon A. Cruz 02 Oct '06

02 Oct '06

On Sep 30, 2006, at 3:38 AM, Andy Fitzsimon wrote: > > The toolbar should be vertically collapsible with a ^ button leading > to other options > also, the commands bar should also horizontally collapse with > > leading to other options... We'll mainly need some widget to wrap a spinbutton in a menuitem. Then we can finish a transition to stock GTK menubars and get exactly that functionality.

3 5

Re: [Inkscape-devel] Please clean up console output
by Johan Engelen 01 Oct '06

01 Oct '06

> -----Original Message----- > From: bulia byak [mailto:buliabyak@...400...] > Sent: donderdag 28 september 2006 4:23 > > 3. Three "(inkscape:12772): GLib-GObject-CRITICAL **: > g_object_set_qdata_full: assertion `quark > 0' failed" > warnings when I run Inkscape with a query, for example > "inkscape -W file.svg". Two of the errors were indeed spawned by paramnotebook.cpp. I fixed the bug (something with tooltips). After quite a search: the third error is not caused by my code but by event-log.cpp. Newing SPDocumentPrivate() causes the error => Member 'Inkscape::EventLog event_log;' causes the error => and finally "_event_list_store ( Gtk::TreeStore::create(_columns) )" is the cause of the error. The code should be changed to create the TreeStore only if there is a UI which can actually call Undo/Redo. Because I am not familiar with the EventLog (mental proposed a better name: 'HistoryLog'), I hope the author can look into this. I tried to correct it but it started becoming a nasty hack; I gave up for now. Side note: we should make it clear to windows developers to enable the console. I vote for enabling it standard in the SVN's makefiles, and disable it for the pre-compiled distributions. I think people who are keen enough to compile their own Inkscape can also cope with a console screen. This should prevent some of the errors being missed. However, since I never use inkscape from the commandline, I still would have missed some of the errors caused by my code... Now back to work on the axonometric grid :-) - Johan

3 2

my PHAdfxRMA
by Eloi Mikesell 01 Oct '06

01 Oct '06

Good day, AMBzzIEN CIAzzLIS VIAzzGRA VALzzIUM Econnomize over 50 % with http://www.luhunjetionkderunjde.com _____ Floyd guessed right, which was a good thing since an instant after we remaining strength to crawl out onto the ground. Dropped with a groan handful of false fingernails. I popped my eyes at these-then

1 0

boolean operation loose mask/clip-path too
by Popolon 30 Sep '06

30 Sep '06

Here is another patch to resolve the issue (to apply after the previous one, that is already commited to SVN) : https://sourceforge.net/tracker/index.php?func=detail&aid=1568462&group_id=… I also made a patch to apply to 0.44.1 that correct the 3 clip-mask/boolean bug (boolean + simplify + object2path): http://popolon.org/inkscape/patchs/fix_mask_clip-path_for_bool-simplify-obj…

1 0

better patch for mask loose
by Popolon 30 Sep '06

30 Sep '06

The patch attached I just attached in bug #1562520 corrects it and corrects bug #1561034 too in a better way. it also free a string that was not freed in the bug #1561034 patched function that lead me to wrong patch. <https://sourceforge.net/tracker/?func=detail&atid=604306&aid=1562520&group_…> There are nothing in guide line about comment and cast. I do a cast (gchar *) for a temporary 'gchar *' from a 'const gchar *' given by attribute() function. And about comment : in src/path-chemistery.cpp there are C style single line comments: /* foo bar */ but in src/splivarot.cpp there are c++ comments: // foo bar and some time not spaced text and c++ style comments //foo bar Is there no project to add something about that in coding style guide?

1 0

a little more on the blur crash
by Jon A. Cruz 30 Sep '06

30 Sep '06

I managed to track down more on that crash problem. down in desktop-style.cpp, things seem to have some issues right after this: SPGaussianBlur * b = new SPGaussianBlur(); I added this, and see a warning. if ( !SP_IS_GAUSSIANBLUR(b) ) { g_warning("problem with gaussian blur object"); } I'd sprinkled some of those debug messages starting at the point where I'd seen the lockups on OS X, and then moved things back until I'd gotten there. So I think the new call there is not getting all needed items setup. Given the "TODO" comment right above that, I think this is the right point to change things. I'm not familiar with the filter code enough, and the other object creation that doesn't use new has a bit more context for creating things. So I think I'm at the point where I've done what I can tonight.

1 0

[PATCH] bug in FileSaveDialog
by Kees Cook 30 Sep '06

30 Sep '06

I know inkscape is normally a patch-first-talk-later place, but I haven't done a "serious" commit to SVN in a while, so I thought I'd see what people thought of this patch... Here is the problem: in Ubuntu Edgy (glib 2.12.3) the filedialog throws an error if you give it a _file_ rather than a _path_ in set_current_folder(). src/file.cpp expected (at one time) to give the dialog a full path, not a directory, but at some point the logic slowly changed. This patch restores the logic of letting the dialog specify a full path name. (And as such, the "drawing.svg", "drawing-1.svg" default names re-appear too.) Example scenario: - start without ~/.inkscape dir and without any ~/drawing*.svg files - open inkscape - draw anything - click "save" expected results: put in home directory, with "drawing.svg" already in the filename entry box. - click "OK" - open new inkscape window - draw anything - click "save" expected results: put in home directory, with "drawing-1.svg" - click on "Filesystem" and scroll to "tmp". - click "OK" - switch back to first window - Select "File/Save As..." expected results: put in home directory, with "drawing.svg" already in the filename entry box. Thoughts? Index: src/ui/dialog/filedialog.h =================================================================== --- src/ui/dialog/filedialog.h (revision 13104) +++ src/ui/dialog/filedialog.h (working copy) @@ -172,6 +172,10 @@ */ virtual void change_title(const Glib::ustring& title) =0; + /** + * Change the default save path location. + */ + virtual void change_path(const Glib::ustring& path) =0; }; //FileSaveDialog Index: src/ui/dialog/filedialog.cpp =================================================================== --- src/ui/dialog/filedialog.cpp (revision 13104) +++ src/ui/dialog/filedialog.cpp (working copy) @@ -1138,6 +1138,7 @@ Glib::ustring getFilename(); void change_title(const Glib::ustring& title); + void change_path(const Glib::ustring& dir); private: @@ -1355,7 +1356,7 @@ // leaving a trailing backslash on the directory name leads to the infamous // double-directory bug on win32 if (len != 0 && udir[len - 1] == '\\') udir.erase(len - 1); - set_current_folder(udir.c_str()); + myFilename = udir; } //###### Add the file types menu @@ -1455,10 +1456,7 @@ bool FileSaveDialogImpl::show() { - Glib::ustring s = Glib::filename_to_utf8 (get_current_folder()); - if (s.length() == 0) - s = getcwd (NULL, 0); - set_current_folder(Glib::filename_from_utf8(s)); //hack to force initial dir listing + change_path(myFilename); set_modal (TRUE); //Window sp_transientize((GtkWidget *)gobj()); //Make transient gint b = run(); //Dialog @@ -1519,6 +1517,24 @@ this->set_title(title); } +/** + * Change the default save path location. + */ +void +FileSaveDialogImpl::change_path(const Glib::ustring& path) +{ + myFilename = path; + if (Glib::file_test(myFilename, Glib::FILE_TEST_IS_DIR)) { + //fprintf(stderr,"set_current_folder(%s)\n",myFilename.c_str()); + set_current_folder(myFilename); + } else { + //fprintf(stderr,"set_filename(%s)\n",myFilename.c_str()); + set_filename(myFilename); + Glib::ustring basename = Glib::path_get_basename(myFilename); + //fprintf(stderr,"set_current_name(%s)\n",basename.c_str()); + set_current_name(basename); + } +} Index: src/file.cpp =================================================================== --- src/file.cpp (revision 13104) +++ src/file.cpp (working copy) @@ -589,7 +589,8 @@ save_loc.append(formatBuf); } } else { - save_loc = Glib::path_get_dirname(doc->uri); + save_loc = Glib::build_filename(Glib::path_get_dirname(doc->uri), + Glib::path_get_basename(doc->uri)); } // convert save_loc from utf-8 to locale @@ -615,6 +616,8 @@ (char const *) _("Select file to save to"), default_extension ); + else + saveDialogInstance->change_path(save_loc); saveDialogInstance->change_title(dialog_title); bool success = saveDialogInstance->show(); @@ -640,7 +643,7 @@ if (success) prefs_set_recent_file(SP_DOCUMENT_URI(doc), SP_DOCUMENT_NAME(doc)); - save_path = fileName; + save_path = Glib::path_get_dirname(fileName); prefs_set_string_attribute("dialogs.save_as", "path", save_path.c_str()); return success; -- Kees Cook @outflux.net

1 0