Re: [Inkscape-devel] 0.92 release
by Josh Andler
0.91 was the first time we had an experimental branch, but I'm not against
it again.
I would also like to hear from Jabier if he thinks something is a review
away from inclusion this cycle or if he thinks it's better to defer his
branches for 0.92.
Cheers,
Josh
On May 5, 2016 12:15 AM, "Alex Valavanis" <valavanisalex@...400...> wrote:
OK, this all sounds very promising. Unfortunately, I won't be
available to join in the IRC meeting tomorrow, but by the sounds of
things, we're not awaiting any new urgent feature additions. Can I
suggest, therefore, that we move into Feature Freeze as soon as
possible, and concentrate on bug fixing ready for release? As in
previous cycles, we could start an experimental branch for features
that can wait until after 0.92.
AV
On 5 May 2016 at 07:59, Josh Andler <scislac@...400...> wrote:
> I've worked with SUV for the past half dozen years or so on figuring out
> release blocker stuff. I'm willing to take it on even if there is no
> interest on SUV's end to help determine such things. I will draft a
release
> plan tomorrow morning (as I had previously offered to) and send it to you
> Bryce for your review and edits and I will begin reviewing for blocker
bugs
> in the tracker after that.
>
> Cheers,
> Josh
>
> On May 4, 2016 9:08 PM, "Bryce Harrington" <bryce@...961...>
> wrote:
>>
>> On Wed, May 04, 2016 at 03:57:51PM +0200, Tavmjong Bah wrote:
>> > On Wed, 2016-05-04 at 09:04 -0400, Martin Owens wrote:
>> > > On Wed, 2016-05-04 at 14:27 +0200, Tavmjong Bah wrote:
>> > > >
>> > > > We should discuss this on Friday's IRC meeting.
>> > > Friday's meeting is a board meeting isn't it? I thought developer
>> > > decisions like releases were more developer consensus on mailing list
>> > > type things and less board responsibility.
>> > >
>> > > (or is this just convenient discussion space?)
>> >
>> > Yes, it is not the board's duty to make developer decisions. But I
>> > think the board does have the responsibility to aid (and prod) the
>> > developers to make decisions when needed as well as to support the
>> > execution of those decisions (e.g. fund a dedicated hackfest).
>> >
>> > (it is also a convenient discussion space)
>>
>> You're both right, and I do agree that having a meeting to get things
>> going with the release is a great idea.
>>
>> Traditionally we've often encouraged non-board-specific technical
>> discussions to happen immediately following the board meeting. What if
>> we had a short board meeting for say 20-30 min, and then a second
>> followup meeting specifically to focus on release coordination
>> discussions?
>>
>> Sounds like we've crested the hill on the cmake work (we still need to
>> do a comparison between the automake-generated dist and the cmake dist,
>> to see if we're missing anything important). Once we're comfortable
>> with what's in the dist, I can cut an alpha release - possibly as early
>> as this weekend. I'm prepared to do a series of (bi-weekly?)
>> pre-releases as we work towards the final release. Next step would be
>> to start gathering a list of release blockers and recruit owners for
>> getting those items examined; I would love it if someone could volunteer
>> to coordinate/manage the release blocker bugfixing work.
>>
>> Bryce
>>
>>
>>
------------------------------------------------------------------------------
>> Find and fix application performance issues faster with Applications
>> Manager
>> Applications Manager provides deep performance insights into multiple
>> tiers of
>> your business applications. It resolves application problems quickly and
>> reduces your MTTR. Get your free trial!
>> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
>> _______________________________________________
>> Inkscape-devel mailing list
>> Inkscape-devel(a)lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>
>
>
------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications
Manager
> Applications Manager provides deep performance insights into multiple
tiers
> of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> Inkscape-devel mailing list
> Inkscape-devel(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>
6 years, 9 months
Re: [Inkscape-devel] [UI] Name for a new function
by jelle
> 2. Re: [UI] Name for a new function (Brynn)
> 3. Re: [UI] Name for a new function (Jabiertxo Arraiza Cenoz)
>
>
As far as I can understand from all this what it does is create a polygon
from the outline of a stroke. If so wouldn't "outline from stroke", "path
from stroke" or "stroke to filled path" not be a better description? Would
also be nice if that could happen without destroying the original.
The "deconstruct object" sounds more like cutting a path to ribbons from
node to node. Something like "segmentate path" might actually be quite
handy come to think of it. In combination with a "weld nodes" that is.
True, is obtainable with the node editor as well but I like those one
click options without keyboard switches.
If the circle has no stroke, it is no more than logical it disappears.
Cheers,
Jelle
>
> Message: 2
> Date: Sat, 7 May 2016 03:36:19 -0600
> From: "Brynn" <brynn@...3133...>
> Subject: Re: [Inkscape-devel] [UI] Name for a new function
> To: "Inkscape-Devel" <inkscape-devel(a)lists.sourceforge.net>
> Message-ID: <B40A8BBF0C4A40EF9E338A385BCE416B@...3282...>
> Content-Type: text/plain; format=flowed; charset="utf-8";
> reply-type=original
>
> Seeing how it works would help understanding. From a simple user:
>
> "deconstruct object" sounds like breaking up any object to individual
> pieces, maybe like Ungroup, or Break Apart. And I can't imagine how
> "stroke
> to fill" fits with either of those. ("stroke to fill" sounds like some
> kind
> of a stripe pattern)
>
> All best :-)
> brynn
>
> ____________________________
> From: C R
> Sent: Saturday, May 07, 2016 3:13 AM
> To: Olof Bjarnason
> Cc: Inkscape Devel List
> Subject: Re: [Inkscape-devel] [UI] Name for a new function
>
>
> Yes please draw some use case diagrams.
> (And I like the renaming too. I'm still much more of a user than a
> developer
> of inkscape and that name (stroke to path) has annoyed me for years!)
>
>
> Will do! And yes, I'm going to recommend renaming it as well. It's always
> been a bit of a sticking point in my head as well.
>
>
> -C
>
>
>
> On 7 May 2016 11:03, "C R" <cajhne@...400...> wrote:
>
> I think stroke to path is already a naming convention for a very similar
> functionality, so I will keep this name if possible if the feature is not
> too different. If a user will receive most of the time the same result I
> will try to keep it to avoid confusion. Having too many features with
> similar behaviours could be frustrating.
>
>
> Agreed. This is my main reason for proposing a modification to the
> behaviour
> of Stroke to Path (We can think about renaming it later, however that
> may be
> confusing to our current user base. As a daily user, I'm all for
> changing it
> to "Strike to Fill", which is what Stroke to Path actually does.
>
> I would strongly suggest not to create a new menu option if the
> behaviour is
> not too different from the expected one if we think the users are going
> to
> keep using it as they were doing before.
>
>
> To clarify:
> 1. Make a red circle with a black stroke
> 2. Path > Stroke to Path
>
>
> Watch the red circle vanish
>
>
> Note that I didn't ask Inkscape to throw away the fill, it just does it
> because there is no shape to contain it anymore.
> Since we have Paint Order in trunk now, this is even more of an issue;
> you
> don't want Stroke to Path to throw away everything you did to make that
> shape look the way it is, which may include a stack of LPEs and markers,
> not
> to mention the fill may include a complex gradient that you have to copy
> and
> paste-in-place to recover. The way it has worked has always been a major
> workflow bottleneck, and Jabier's new function fixes the problem
> entirely.
>
>
> Would folks like to see some use case and work flow diagrams?
> If so, I can have them ready tomorrow.
>
>
> -C
>
>
>
>
>
>
>
>
>
> Otherwise, reading the feature explanation, "decompose object" or
> "deconstruct object"sounds self-explanatory to me.
>
>
> I don't have an answer, but I would raise some questions about how we
> think
> it is going to be used: what is the purpose, what is the expected outcome
> and I would compare to the stroke to path option to ensure that are
> enough
> different.
>
>
> :)
>
>
>
> On Sat, May 7, 2016 at 10:20 AM, Olof Bjarnason
> <olof.bjarnason@...400...>
> wrote:
>
>
>
>
>
>
>
>
>
> Mvh
>
>
>
>
> /Olof
> -----------------
> ?r du systemutvecklare?
> Spana in https://cilamp.se
>
>
>
>
> On 7 May 2016 at 10:14, C R <cajhne@...400...> wrote:
>
> Basicly, this is how Stroke to Fill should work.
>
>
> How it works now:
> Ctrl+Alt+C > Stroke to Path
>
>
> Result: stroke is indeed converted to path, but the fill and all other
> parts
> of the selection that are not strokes vanish. If any LPEs are applied to
> the
> path they are thrown out as well (you need to convert object to path
> before
> this operation to preserve the appearance).
>
>
>
>
> How it should work (this "deconstruct" alternative):
> Ctrl+Alt+C > Stroke to Path
>
>
> Result: All LPE's applied to stroke, then the stroke is converted to
> path.
>
>
> My thought is, if we use the convention that a fill is only turned into
> an
> object if there is a fill set on the object, then we can please anyone
> who
> prefers the old behaviour. All they have to do is get rid of the fill
> colour
> on the object before applying Stroke to Path.
>
>
> The current way it's handled is counter-intuitive. Most of the time, all
> you
> want to do is convert the outline to a fill, not throw away tons of data.
> The point is to preserve appearance, and the Jabier's new function does
> this
> much much better.
>
>
> Thanks, that is a good explanation. However the wording "stroke to path"
> isn't that clear to me.
>
>
> Now that I understand what is going on I think "deconstruct" is actually
> a
> quite good albeit little techy word for the operation. "Decompose"?
> "Path to
> fills"?
>
>
> The end result is a bunch of filled paths, and the input is what
> exactly? I
> think "X to Y" is a good but then the X and the Y should be closer to
> what
> the operation is actually doing ;)
>
>
>
>
>
> My 2p.
> -C
>
>
>
>
>
>
>
>
>
>
>
>
> On Sat, May 7, 2016 at 9:03 AM, Olof Bjarnason <olof.bjarnason@...400...>
> wrote:
>
> Is there any image giving an example of what the command does...? Like
> before/after with arrows and descriptive text?
>
>
> It's kind of hard to understand what is happening from the very brief
> description at the top of that thread...
>
>
>
>
>
>
> Mvh
>
>
>
>
> /Olof
> -----------------
> ?r du systemutvecklare?
> Spana in https://cilamp.se
>
>
>
>
> On 7 May 2016 at 09:53, Jabiertxo Arraiza Cenoz
> <jabier.arraiza@...2893...>
> wrote:
>
> Hi to all UI power!
> I Just to know a name for the patch https://bugs.launchpad.net/inkscape
> /+bug/1556592
>
> See the ScislaC proposal on #5
> Bryce like "Deconstruct object", me too.
>
> Is ok the name? Another one?
>
> Cheers, Jabier.
>
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications
> Manager
> Applications Manager provides deep performance insights into multiple
> tiers
> of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> Inkscape-devel mailing list
> Inkscape-devel(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>
>
>
>
>
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications
> Manager
> Applications Manager provides deep performance insights into multiple
> tiers
> of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> Inkscape-devel mailing list
> Inkscape-devel(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications
> Manager
> Applications Manager provides deep performance insights into multiple
> tiers
> of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> Inkscape-devel mailing list
> Inkscape-devel(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>
>
>
>
>
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications
> Manager
> Applications Manager provides deep performance insights into multiple
> tiers
> of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
>
>
>
> _______________________________________________
> Inkscape-devel mailing list
> Inkscape-devel(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>
>
>
>
> ------------------------------
>
> Message: 3
> Date: Sat, 07 May 2016 11:53:57 +0200
> From: Jabiertxo Arraiza Cenoz <jabier.arraiza@...2893...>
> Subject: Re: [Inkscape-devel] [UI] Name for a new function
> To: C R <cajhne@...400...>, Olof Bjarnason <olof.bjarnason@...400...>
> Cc: Inkscape Devel List <inkscape-devel(a)lists.sourceforge.net>
> Message-ID: <1462614837.14732.13.camel@...2893...>
> Content-Type: text/plain; charset="utf-8"
>
> I just read the thread.
> Olof, the new feature convert the selected items to paths, maybe groups
> if have more than one propertye o fill|stroke|marker.
> It also retain new paint order.
>
> So I try to solve one question and now have more :)
> In the meet with Josh in IRC he tell is better retain the old stroke to
> path (?renaming it?) to old users and add a new item (down stroke to
> path) to ?deconstruct object?
>
> In my point of view, personal only, I think a feature to convert a
> "stroke to fill/path" is unnecesary, because "deconstruct object" do
> the same with objects with only strokes/markers.
>
> Cheers, Jabier.
>
>
> El s?b, 07-05-2016 a las 10:13 +0100, C R escribi?:
>> >
>> >
>> > Yes please draw some use case diagrams.
>> >
>> (And I like the renaming too. I'm still much more of a user than a
>> >
>> > developer of inkscape and that name (stroke to path) has annoyed me
>> > for
>> > years!)
>> >
>> Will do! And yes, I'm going to recommend renaming it as well. It's
>> always
>> been a bit of a sticking point in my head as well.
>>
>> -C
>>
>>
>>
>> >
>> > On 7 May 2016 11:03, "C R" <cajhne@...400...> wrote:
>> >
>> > I think stroke to path is already a naming convention for a very
>> > similar
>> > >
>> > > functionality, so I will keep this name if possible if the
>> > > feature is not
>> > > too different. If a user will receive most of the time the same
>> > > result I
>> > > will try to keep it to avoid confusion. Having too many features
>> > > with
>> > > similar behaviours could be frustrating.
>> > >
>> > Agreed. This is my main reason for proposing a modification to the
>> > behaviour of Stroke to Path (We can think about renaming it later,
>> > however
>> > that may be confusing to our current user base. As a daily user,
>> > I'm all
>> > for changing it to "Strike to Fill", which is what Stroke to Path
>> > actually
>> > does.
>> >
>> >
>> > >
>> > > I would strongly suggest not to create a new menu option if the
>> > > behaviour
>> > > is not too different from the expected one if we think the users
>> > > are going
>> > > to keep using it as they were doing before.
>> > >
>> > To clarify:
>> > 1. Make a red circle with a black stroke
>> > 2. Path > Stroke to Path
>> >
>> > Watch the red circle vanish
>> >
>> > Note that I didn't ask Inkscape to throw away the fill, it just
>> > does it
>> > because there is no shape to contain it anymore.
>> > Since we have Paint Order in trunk now, this is even more of an
>> > issue; you
>> > don't want Stroke to Path to throw away everything you did to make
>> > that
>> > shape look the way it is, which may include a stack of LPEs and
>> > markers,
>> > not to mention the fill may include a complex gradient that you
>> > have to
>> > copy and paste-in-place to recover. The way it has worked has
>> > always been a
>> > major workflow bottleneck, and Jabier's new function fixes the
>> > problem
>> > entirely.
>> >
>> > Would folks like to see some use case and work flow diagrams?
>> > If so, I can have them ready tomorrow.
>> >
>> > -C
>> >
>> >
>> >
>> >
>> >
>> > >
>> > >
>> > >
>> > > Otherwise, reading the feature explanation, "decompose object" or
>> > > "deconstruct object"sounds self-explanatory to me.
>> > >
>> > > I don't have an answer, but I would raise some questions about
>> > > how we
>> > > think it is going to be used: what is the purpose, what is the
>> > > expected
>> > > outcome and I would compare to the stroke to path option to
>> > > ensure that are
>> > > enough different.
>> > >
>> > > :)
>> > >
>> > > On Sat, May 7, 2016 at 10:20 AM, Olof Bjarnason <olof.bjarnason@...1354...
>> > > mail.com
>> > > >
>> > > > wrote:
>> > > >
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > Mvh
>> > > >
>> > > >
>> > > > /Olof
>> > > > -----------------
>> > > > ?r du systemutvecklare?
>> > > > Spana in https://cilamp.se
>> > > >
>> > > >
>> > > > On 7 May 2016 at 10:14, C R <cajhne@...400...> wrote:
>> > > >
>> > > > >
>> > > > > Basicly, this is how Stroke to Fill should work.
>> > > > >
>> > > > > How it works now:
>> > > > > Ctrl+Alt+C > Stroke to Path
>> > > > >
>> > > > > Result: stroke is indeed converted to path, but the fill and
>> > > > > all other
>> > > > > parts of the selection that are not strokes vanish. If any
>> > > > > LPEs are applied
>> > > > > to the path they are thrown out as well (you need to convert
>> > > > > object to path
>> > > > > before this operation to preserve the appearance).
>> > > > >
>> > > > >
>> > > > > How it should work (this "deconstruct" alternative):
>> > > > > Ctrl+Alt+C > Stroke to Path
>> > > > >
>> > > > > Result: All LPE's applied to stroke, then the stroke is
>> > > > > converted to
>> > > > > path.
>> > > > >
>> > > > > My thought is, if we use the convention that a fill is only
>> > > > > turned into
>> > > > > an object if there is a fill set on the object, then we can
>> > > > > please anyone
>> > > > > who prefers the old behaviour. All they have to do is get rid
>> > > > > of the fill
>> > > > > colour on the object before applying Stroke to Path.
>> > > > >
>> > > > > The current way it's handled is counter-intuitive. Most of
>> > > > > the time,
>> > > > > all you want to do is convert the outline to a fill, not
>> > > > > throw away tons of
>> > > > > data. The point is to preserve appearance, and the Jabier's
>> > > > > new function
>> > > > > does this much much better.
>> > > > >
>> > > > Thanks, that is a good explanation. However the wording "stroke
>> > > > to path"
>> > > > isn't that clear to me.
>> > > >
>> > > > Now that I understand what is going on I think "deconstruct" is
>> > > > actually
>> > > > a quite good albeit little techy word for the operation.
>> > > > "Decompose"? "Path
>> > > > to fills"?
>> > > >
>> > > > The end result is a bunch of filled paths, and the input is
>> > > > what
>> > > > exactly? I think "X to Y" is a good but then the X and the Y
>> > > > should be
>> > > > closer to what the operation is actually doing ;)
>> > > >
>> > > >
>> > > >
>> > > > >
>> > > > >
>> > > > > My 2p.
>> > > > > -C
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > > On Sat, May 7, 2016 at 9:03 AM, Olof Bjarnason <
>> > > > > olof.bjarnason@...400...> wrote:
>> > > > >
>> > > > > >
>> > > > > > Is there any image giving an example of what the command
>> > > > > > does...? Like
>> > > > > > before/after with arrows and descriptive text?
>> > > > > >
>> > > > > > It's kind of hard to understand what is happening from the
>> > > > > > very brief
>> > > > > > description at the top of that thread...
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > > Mvh
>> > > > > >
>> > > > > >
>> > > > > > /Olof
>> > > > > > -----------------
>> > > > > > ?r du systemutvecklare?
>> > > > > > Spana in https://cilamp.se
>> > > > > >
>> > > > > >
>> > > > > > On 7 May 2016 at 09:53, Jabiertxo Arraiza Cenoz <
>> > > > > > jabier.arraiza@...2893...> wrote:
>> > > > > >
>> > > > > > >
>> > > > > > > Hi to all UI power!
>> > > > > > > I Just to know a name for the patch
>> > > > > > > https://bugs.launchpad.net/inkscape/+bug/1556592
>> <https://bugs.launchpad.net/inkscape/+bug/1556592>
>> > > > > > >
>> > > > > > > See the ScislaC proposal on #5
>> > > > > > > Bryce like "Deconstruct object", me too.
>> > > > > > >
>> > > > > > > Is ok the name? Another one?
>> > > > > > >
>> > > > > > > Cheers, Jabier.
>> > > > > > >
>> > > > > > > -------------------------------------------------------
>> > > > > > > -----------------------
>> > > > > > > Find and fix application performance issues faster with
>> > > > > > > Applications
>> > > > > > > Manager
>> > > > > > > Applications Manager provides deep performance insights
>> > > > > > > into multiple
>> > > > > > > tiers of
>> > > > > > > your business applications. It resolves application
>> > > > > > > problems quickly
>> > > > > > > and
>> > > > > > > reduces your MTTR. Get your free trial!
>> > > > > > > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
>> > > > > > > _______________________________________________
>> > > > > > > Inkscape-devel mailing list
>> > > > > > > Inkscape-devel(a)lists.sourceforge.net
>> > > > > > > https://lists.sourceforge.net/lists/listinfo/inkscape-dev
>> > > > > > > el
>> > > > > > >
>> > > > > > >
>> > > > > >
>> > > > > > ---------------------------------------------------------
>> > > > > > ---------------------
>> > > > > > Find and fix application performance issues faster with
>> > > > > > Applications
>> > > > > > Manager
>> > > > > > Applications Manager provides deep performance insights
>> > > > > > into multiple
>> > > > > > tiers of
>> > > > > > your business applications. It resolves application
>> > > > > > problems quickly
>> > > > > > and
>> > > > > > reduces your MTTR. Get your free trial!
>> > > > > > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
>> > > > > > _______________________________________________
>> > > > > > Inkscape-devel mailing list
>> > > > > > Inkscape-devel(a)lists.sourceforge.net
>> > > > > > https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>> > > > > >
>> > > > > >
>> > > >
>> > > > -------------------------------------------------------------
>> > > > -----------------
>> > > > Find and fix application performance issues faster with
>> > > > Applications
>> > > > Manager
>> > > > Applications Manager provides deep performance insights into
>> > > > multiple
>> > > > tiers of
>> > > > your business applications. It resolves application problems
>> > > > quickly and
>> > > > reduces your MTTR. Get your free trial!
>> > > > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
>> > > > _______________________________________________
>> > > > Inkscape-devel mailing list
>> > > > Inkscape-devel(a)lists.sourceforge.net
>> > > > https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>> > > >
>> > > >
>> -------------------------------------------------------------------
>> -----------
>> Find and fix application performance issues faster with Applications
>> Manager
>> Applications Manager provides deep performance insights into multiple
>> tiers of
>> your business applications. It resolves application problems quickly
>> and
>> reduces your MTTR. Get your free trial!
>> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
>> _______________________________________________
>> Inkscape-devel mailing list
>> Inkscape-devel(a)lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>
6 years, 9 months
Re: [Inkscape-devel] TempGString to simplify common pattern in code..?
by Jon A. Cruz
Glib and gtk are c, but there are c++ wrapper layers we are using: Glibmm and Gtkmm.
Check for those names
Sent from my mobile device.
-------- Original message --------
From: Olof Bjarnason <olof.bjarnason@...400...>
Date: 5/6/2016 07:54 (GMT-08:00)
To: "Jon A. Cruz" <jon@...18...>
Cc: Inkscape Devel List <inkscape-devel(a)lists.sourceforge.net>
Subject: Re: [Inkscape-devel] TempGString to simplify common pattern in code..?
OK, I read up a little on GLib and GTK+.
Both are (pure) C libraries, so I fail to see how they could provide a RAII idiom? Last time I checked, C didn't have constructors/destructors...? Or maybe there is some pre-processor magic to make it happen...?
std::string is nice (I would prefer it in fact) but it wouldn't call g_free automatically when the gchar* variable goes out of scope.
Mvh
/Olof-----------------Är du systemutvecklare?Spana in https://cilamp.se
On 6 May 2016 at 15:51, Olof Bjarnason <olof.bjarnason@...400...> wrote:
Yeah, of course if there already exists a solution / pattern then that would be preferrable...
(I have only looked at cases for deallocating gchar* using g_free, I do not know what encoding is used inside the strings, and a TempGString object would be agnostic to the encoding anyway.)
Anyone know if there is a RAII type for string handling in GLib? My google fu fails me on this atm.
Mvh
/Olof-----------------Är du systemutvecklare?Spana in https://cilamp.se
On 6 May 2016 at 15:40, Jon A. Cruz <jon@...18...> wrote:
This sounds like something that should already be covered by gtkmm or even std::string. Usually it's better to look first to existing solutions before inventing our own wheel.
IIRC Glib::ustring should cover the cases where we have content that is guaranteed to be UTF-8. (Keep in mind that gtk+ apps have to keep track of three different encodings and not get them mixed up.
For strings that are potentially different encodings we can use std::string.
For content that looked like a string but is actually a byte sequence, we can use std::vector<char> or std::vector<uint8_t>
On Fri, May 6, 2016, at 05:38 AM, Olof Bjarnason wrote:
Does anyone want to voice an opinion on this one or should I just go ahead and do it? What about using implicit casting, you OK with that?
I think reviewing it should be fairly straight-forward as it's almost a regex search-replace operation (just almost heh).
BTW I noticed there is a paste option on the web site too, so here it is:
https://inkscape.org/en/paste/9559/
--
Jon A. Cruz
jon@...18...
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel
6 years, 9 months
TempGString to simplify common pattern in code..?
by Olof Bjarnason
Hi guys!
One thing I noticed while browsing around Inkscape source, was the pattern
"allocate temp gtk string, call some api, deallocate temp string".
I think it makes sense to make a small "TempGString" class that captures
this (RAII) pattern, and deallocates the string on going out of scope. This
would have some advantages compared to current approach:
1) string would be freed regardless of how the code exits the block
(exceptions e.g.)
2) 2 lines instead of 3
3) easier on the eyes
Sample before-after code snippet:
Before:
if (!qname_prefix(code).id()) {
gchar *svg_name = g_strconcat(prefix, ":", g_quark_to_string(code),
NULL);
repr->setCodeUnsafe(g_quark_from_string(svg_name));
g_free(svg_name);
}
After:
if (!qname_prefix(code).id()) {
TempGString svg_name(g_strconcat(prefix, ":", g_quark_to_string(code),
NULL));
repr->setCodeUnsafe(g_quark_from_string(svg_name));
}
Syntax highlighted version available here: http://pastebin.com/t7p0TVfj
The constructor takes the freshly allocated string, and the destructor
calls g_free on it. There is an operator overload so that contexts that
expect ordinary pointers to gchar* gets what it want. This automagic
casting is a point I'm a bit ambivalent about myself; I wouldn't mind
having an accessor function "get_gchar_ptr()" or similar just to be super
explicit, thoughts on that?
I don't think this would break anything, however it might be that I'm
ignorant to some weird behaviour of ghar* or glib/gtk?
On a convention/code style notion, I looked through the code for RAII
(worst abbreviation for something so clear/simple semantically) and noticed
it's used in a couple other places, however I've still been wary of
introducing this refactoring to the code base as I don't know if you guys
would like it.
The pattern occurs on at least 140 places in the code base.
Cheers,
/Olof
6 years, 9 months
Style Dialog Design [UI]
by Kamalpreet Grewal
Talking about CSS support in Inkscape, a style dialog box will be
added during GSoC this year. A design has already been proposed by
Tavmjong at [1]. Some discussions have been done in thread 'Style
Dialog'.
We need a review of the design for the style dialog from the interface
team. Which options should be available in it? How it should behave
when a user interacts with it?
Any modifications in the design are most welcome.
[1]: http://wiki.inkscape.org/wiki/index.php/Style_Editor
--
Kamalpreet Kaur Grewal
Blog: http://kamalpreetgrewal.com/
6 years, 9 months
Credits Page
by Martin Owens
Docs and Developers,
There's a new credits page on the website, it documents the full list
of people who help do documentation, translations and website work:
https://inkscape.org/en/credits/
It could be expanded to include regular lp:inkscape codebase too, since
the lists are dynamic and most are generated from bzr logs.
Best Regards, Martin Owens
6 years, 9 months
Draft UI Team text
by Martin Owens
This is the draft text for our new ui team:
https://inkscape.org/en/paste/9553/
Originally drafted by Xavir, this is a re-drafted version 2.
Please leave your comments on the page if possible, or here if not.
Best Regards, Martin Owens
6 years, 9 months
