- Inkscape Devel - Inkscape Mailman

[patch] Fix the relocatable build
by Mike Hearn 28 Apr '04

28 Apr '04

Firstly, thanks for integrating the binary relocatability patch! This will help not only the autopackage team but win32 porters as well. Having said that, you now have to remember that you can't use the C preprocessor to build paths anymore. Here is a patch to fix the CVS relocatable build. thanks -mike Index: src/dialogs/stroke-style.cpp =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/dialogs/stroke-style.cpp,v retrieving revision 1.39 diff -u -r1.39 stroke-style.cpp --- src/dialogs/stroke-style.cpp 25 Apr 2004 22:18:20 -0000 1.39 +++ src/dialogs/stroke-style.cpp 28 Apr 2004 19:55:23 -0000 @@ -789,15 +789,18 @@ static unsigned int edoc = FALSE; /* Try to load from document */ if (!edoc && !doc) { - if (g_file_test(INKSCAPE_MARKERSDIR "/markers.svg", G_FILE_TEST_IS_REGULAR)) { - doc = sp_document_new(INKSCAPE_MARKERSDIR "/markers.svg", FALSE, FALSE); + char *markers_file = g_build_filename(INKSCAPE_MARKERSDIR, "/markers.svg", NULL); + if (g_file_test(markers_file, G_FILE_TEST_IS_REGULAR)) { + doc = sp_document_new(markers_file, FALSE, FALSE); } - if ( !doc && g_file_test( INKSCAPE_MARKERSDIR "/markers.svg", + if ( !doc && g_file_test( markers_file, G_FILE_TEST_IS_REGULAR) ) { - doc = sp_document_new( INKSCAPE_MARKERSDIR "/markers.svg", + doc = sp_document_new( markers_file, FALSE, FALSE ); } + g_free(markers_file); + if (doc) { unsigned int visionkey; sp_document_ensure_up_to_date(doc); @@ -909,15 +912,17 @@ } /* Try to load from document */ if (!edoc && !doc) { - if (g_file_test(INKSCAPE_MARKERSDIR "/markers.svg", G_FILE_TEST_IS_REGULAR)) { - doc = sp_document_new(INKSCAPE_MARKERSDIR "/markers.svg", FALSE, FALSE); + char *markers = g_build_filename(INKSCAPE_MARKERSDIR, "/markers.svg", NULL); + if (g_file_test(markers, G_FILE_TEST_IS_REGULAR)) { + doc = sp_document_new(markers, FALSE, FALSE); } - if ( !doc && g_file_test( INKSCAPE_MARKERSDIR "/markers.svg", + if ( !doc && g_file_test( markers, G_FILE_TEST_IS_REGULAR) ) { - doc = sp_document_new( INKSCAPE_MARKERSDIR "/markers.svg", + doc = sp_document_new( markers, FALSE, FALSE ); } + g_free(markers); if (doc) { sp_document_ensure_up_to_date(doc); } else { @@ -951,15 +956,18 @@ /* Try to load from document */ if (!edoc && !doc) { - if (g_file_test(INKSCAPE_MARKERSDIR "/markers.svg", G_FILE_TEST_IS_REGULAR)) { - doc = sp_document_new(INKSCAPE_MARKERSDIR "/markers.svg", FALSE, FALSE); + char *marker = g_build_filename(INKSCAPE_MARKERSDIR, "/markers.svg", NULL); + if (g_file_test(marker, G_FILE_TEST_IS_REGULAR)) { + doc = sp_document_new(marker, FALSE, FALSE); } - if ( !doc && g_file_test( INKSCAPE_MARKERSDIR "/markers.svg", + if ( !doc && g_file_test( marker, G_FILE_TEST_IS_REGULAR) ) { - doc = sp_document_new( INKSCAPE_MARKERSDIR "/markers.svg", + doc = sp_document_new( marker, FALSE, FALSE ); } + g_free(marker); + if (doc) { sp_document_ensure_up_to_date(doc); } else { @@ -1216,21 +1224,24 @@ tb = NULL; + char *path = g_build_filename(INKSCAPE_PIXMAPDIR, "/join_miter.xpm", NULL); tb = sp_stroke_radio_button(tb, INKSCAPE_STOCK_JOIN_MITER, - INKSCAPE_PIXMAPDIR "/join_miter.xpm", - hb, spw, "join", "miter"); + path, hb, spw, "join", "miter"); + g_free(path); gtk_tooltips_set_tip(tt, tb, _("Miter join"), NULL); + path = g_build_filename(INKSCAPE_PIXMAPDIR, "/join_round.xpm", NULL); tb = sp_stroke_radio_button(tb, INKSCAPE_STOCK_JOIN_ROUND, - INKSCAPE_PIXMAPDIR "/join_round.xpm", - hb, spw, "join", "round"); + path, hb, spw, "join", "round"); gtk_tooltips_set_tip(tt, tb, _("Round join"), NULL); + g_free(path); + path = g_build_filename(INKSCAPE_PIXMAPDIR, "/join_bevel.xpm", NULL); tb = sp_stroke_radio_button(tb, INKSCAPE_STOCK_JOIN_BEVEL, - INKSCAPE_PIXMAPDIR "/join_bevel.xpm", - hb, spw, "join", "bevel"); + path, hb, spw, "join", "bevel"); gtk_tooltips_set_tip(tt, tb, _("Bevel join"), NULL); - + g_free(path); + i++; /* Miterlimit */ @@ -1259,20 +1270,24 @@ hb = spw_hbox(t, 3, 1, i); tb = NULL; + + path = g_build_filename(INKSCAPE_PIXMAPDIR, "/cap_butt.xpm", NULL); tb = sp_stroke_radio_button(tb, INKSCAPE_STOCK_CAP_BUTT, - INKSCAPE_PIXMAPDIR "/cap_butt.xpm", - hb, spw, "cap", "butt"); + path, hb, spw, "cap", "butt"); gtk_tooltips_set_tip(tt, tb, _("Butt cap"), NULL); + g_free(path); + path = g_build_filename(INKSCAPE_PIXMAPDIR, "/cap_round.xpm", NULL); tb = sp_stroke_radio_button(tb, INKSCAPE_STOCK_CAP_ROUND, - INKSCAPE_PIXMAPDIR "/cap_round.xpm", - hb, spw, "cap", "round"); + path, hb, spw, "cap", "round"); gtk_tooltips_set_tip(tt, tb, _("Round cap"), NULL); + g_free(path); + path = g_build_filename(INKSCAPE_PIXMAPDIR, "/cap_square.xpm", NULL); tb = sp_stroke_radio_button(tb, INKSCAPE_STOCK_CAP_SQUARE, - INKSCAPE_PIXMAPDIR "/cap_square.xpm", - hb, spw, "cap", "square"); + path, hb, spw, "cap", "square"); gtk_tooltips_set_tip(tt, tb, _("Square cap"), NULL); + g_free(path); i++;

1 0

News from the Scribus World
by Peter Linnell 28 Apr '04

28 Apr '04

Hi all, Since 1.1.6 was released, we have begun the long and winding road to Scribus 1.2. Some updates: Last night's CVS release, contains new code to speed up image rendering. It *is* noticeably faster. Anyone using CVS, is encouraged to update and test. There is a Roadmap document for 1.2 and 1.3+ which has been posted to www.scribus.net Those who who might be interested in tackling some of these tasks are invited to join in. Slashdot visited again, based on a review of 1.1.6 from madpenguin.com. This led another discussion on dot.kde.org here: http://dot.kde.org/1083054064/ as well as stories on newsforge.com and others. In related news, the Inkscape team marches towards their next release. The current cvs version has a new feature called the "clone tool". It harder to describe, than to use, but it is an innovative way of editing. Also, there is a new project being launched called "Open Clipart. I have posted a story on the front of www.scribus.net with details. Scribus users are encouraged to support this new endeavor. Cheers, Peter

1 0

RE: win32 Calligraphy Tool
by bulia byak 28 Apr '04

28 Apr '04

>Is there anything written on "mass" and "drag" for instance or on the >rationale behind what the tool is doing? My guess is as good as yours. The original author of the tool is not active in Inkscape. I agree that the tool is pretty useless, but let it be until we have a better replacement. _________________________________________________________________ MSN Premium: Up to 11 personalized e-mail addresses and 2 months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

3 2

RE: [Inkscape-devel] Quick Observation / Inquiry
by bulia byak 28 Apr '04

28 Apr '04

>1) Observation: > One of the nicer features of Sodipodi's interface was the ability to >quickly >zoom in on a selection, as that is one of the most frequently done >operations. You can still hit '3' in Inkscape, but is this not one of the >features that might qualify for a RMB entry? RMB == right mouse button? Anyway, feel free to submit a patch. _________________________________________________________________ Add photos to your e-mail with MSN Premium. Get 2 months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

1 0

Re: [Inkscape-devel] Problem with the GTK file selector in KDE
by bulia byak 28 Apr '04

28 Apr '04

> > OK, the difference between the 2004-04-10 05:00 (good) and the > > 2004-04-10 06:00 (bad) versions are in inkscape.cpp and in main.cpp. > > Downgrading inkscape.cpp in the 06 tree to the 05 version does not > > solve the problem, but downgrading main.cpp DOES. > >Ok, so it's locale related, I've probed exporting LC_NUMERIC="C" >manually and it worked fine. The previous code set that manually to (and >it advertised that not doing it will mess up things, btw). Great work >Mr. Biro. Thanks for finding this out. I wonder what functions might be affected by the non-C locale, now that we removed all printfs? Judjing by the program behavior, it fails when reading SVG from files. We don't seem to have scanf() in XML reading code, only atof(). Is atof locale-broken also, as is printf? If so what should we use instead? > >Thanks. > > > >------------------------------------------------------- >This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek >For a limited time only, get FREE Ground shipping on all orders of $35 >or more. Hurry up and shop folks, this offer expires April 30th! >http://www.thinkgeek.com/freeshipping/?cpg=12297 >_______________________________________________ >Inkscape-devel mailing list >Inkscape-devel(a)lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/inkscape-devel _________________________________________________________________ Is your PC infected? Get a FREE online computer virus scan from McAfee� Security. http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

3 2

Quick Observation / Inquiry
by Dan Ostrowski 28 Apr '04

28 Apr '04

Hello. I've been following Inkscape development for a while now. I was also on the Sodipodi list. 1) Observation: One of the nicer features of Sodipodi's interface was the ability to quickly zoom in on a selection, as that is one of the most frequently done operations. You can still hit '3' in Inkscape, but is this not one of the features that might qualify for a RMB entry? If no, I understand you get a lot of UI suggestions, but I figured I'd throw this one out there. It seems to be a logical fit. 2) Inquiry: What are the plans, if any, for patterns in Inkscape? Every couple days I say to myself "Hey, I just need to go in there and hack up some pattern support...", and yet... Lauris did not comment a lot of his files very well and the myriad of SP/NR_long_names_of_pointers shoved together in structs makes my eyes cross. Is anyone on the development team interested in patterns? There's a sp-pattern* file subset, but nothing seems to be done with it... It's SUCH a crucial feature is it on the radar at all? Thanks so much for a reply and Thanks so much for your development work, Dan Ostrowski

3 7

Re: [Inkscape-devel] Problem with the GTK file selector in KDE
by Arpad Biro 27 Apr '04

27 Apr '04

Hi, OK, the difference between the 2004-04-10 05:00 (good) and the 2004-04-10 06:00 (bad) versions are in inkscape.cpp and in main.cpp. Downgrading inkscape.cpp in the 06 tree to the 05 version does not solve the problem, but downgrading main.cpp DOES. main.cpp diff attached Arpad Biro __________________________________ Do you Yahoo!? Win a $20,000 Career Makeover at Yahoo! HotJobs http://hotjobs.sweepstakes.yahoo.com/careermakeover

3 2

Re: [Inkscape-devel] Problem with the GTK file selector in KDE
by bulia byak 27 Apr '04

27 Apr '04

>For me, it's not just buttons, but also menu icons, SVG documents, >and more. Looks like something very basic is broken. Since I cannot reproduce this, I would appreciate if you could find out the exact point in time when this started to happen. Use backdated CVS checkouts (the -D switch) to find the most recent date on which the CVS was is OK (maybe pre-0.38?), and also the first date on which it is broken. Then we can make a diff between these two dates to figure out the reason. If you manage to find the day of breakage and if that day's diff is big (which is possible, given the rate of checkins we're having on average), try to narrow it down to a few hours. For example: cvs -d:ext:a_b@...318...:/cvsroot/inkscape checkout -D"2004-04-04 12:00" inkscape will give you the CVS as it was on that date at midday. _________________________________________________________________ FREE pop-up blocking with the new MSN Toolbar get it now! http://toolbar.msn.com/go/onm00200415ave/direct/01/

3 3

Re: [Inkscape-devel] selection NULLness
by bulia byak 27 Apr '04

27 Apr '04

>which means that the SP_DT_SELECTION macro will give an assertion failure >if it doesn't return a non-NULL selection. I've then removed defensive >checks from callers of SP_DT_SELECTION. Everything seems ok so far. Here's a crash that seems to be caused by selection==NULL: http://sourceforge.net/tracker/index.php?func=detail&aid=942149&group_id=93… _________________________________________________________________ MSN Premium: Up to 11 personalized e-mail addresses and 2 months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

3 4

Re: [Inkscape-devel] Problem with the GTK file selector in KDE
by bulia byak 27 Apr '04

27 Apr '04

>So, in addition to determining when the offending code was checked in, >we should look at the specific compiler/build configuration of the >people experiencing problems. Likely, given that some people have no problem with RPMs (compiled elsewhere) but their own builds are broken. So whoever has or does not have this problem, please report your compiler version and, if non-standard, compilation flags. Mine is g++ (GCC) 3.3.2 (Mandrake Linux 10.0 3.3.2-3mdk) works ok. _________________________________________________________________ STOP MORE SPAM with the MSN Premium and get 2 months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

3 2