- Inkscape Devel - Inkscape Mailman

Release
by Ted Gould 27 Mar '04

27 Mar '04

Hey, Bulia noted on chat the other night that we're getting awful close to the 10% metric on bugs. We discussed, and I think it was generally accepted, that we should feature freeze for a release shortly. Peter has disabled the guideline locking until a GUI can be developed and Mental has moved the AST code on to its own branch. Currently in SF I see that we have 33 bugs out of 252 filed, so we need to fix eight of them. Ironically, we have 8 high level bugs - so I think that fixing those should be our target for the release. They are: 915374 - Command Line Printing doesnt work 914611 - inkview crash on startup 911772 - Extension Saving 911237 - export/save must warn when overwriting file 866103 - non-well-formed preferences.xml causes data loss 857316 - win32: non-english locales: font style matching broken 857311 - win32: correct output SVG of numerics is locale-dependent 852976 - win32: mouse becoming unresponsive I can definitely finish 911772 here shortly. 911237 won't be a big deal, I can do it, but someone else is welcome. Anyone want to grab these bugs for the release? --Ted

2 1

RE: [Inkscape-devel] Release
by bulia byak 27 Mar '04

27 Mar '04

>Also, I got distcheck to pass - so we're good there also. I haven't >looked through the release notes recently - how are they doing? Rather well, but they need an intro paragraph summarizing the focus of the release (bugfixing). Also the Known Problems may benefit from a few more items - please try to think what are the most annoying unsolved problems that remain. _________________________________________________________________ Tired of spam? Get advanced junk mail protection with MSN Premium http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

3 2

Inkscape 0.38 Status
by Bryce Harrington 27 Mar '04

27 Mar '04

Here's the updated stats for today: 2/18 2/28 3/ 8 3/18 3/27 Goal ---- ---- ---- ---- ---- ---- 1. Bugs 841633-896992 52 33 28 17 12 9 2. Open/Total Bug Ratio 33% 24% 25% 16% 13% 10% Bryce

1 0

Re: [Inkscape-devel] more on win32 locale
by bulia byak 27 Mar '04

27 Mar '04

>>Please resend this patch in diff -u format as were the previous ones. >see attached file Thanks, applied _________________________________________________________________ Free yourself from those irritating pop-up ads with MSn Premium. Get 2months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

1 0

RE: [Inkscape-devel] Principles of Design Graphics
by bulia byak 27 Mar '04

27 Mar '04

>In the "Elements and Principles of Design" tutorial", the Principles of >Design graphics are all absent. Should this be so? Try pinging Jon Phillips who is the author of this tutorial. _________________________________________________________________ Tired of spam? Get advanced junk mail protection with MSN Premium http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

1 0

multistop gradient editor
by bulia byak 27 Mar '04

27 Mar '04

Thanks to John Cliff, we now have a redesigned gradient editor that can handle any number of gradient stops in a gradient. I decided to commit this now because it's an important improvement which is orthogonal to everything else, so it is unlikely to cause any bugs in the existing code (although the new code itself may contain bugs, of course). The new editor is not as convenient yet as it could be; drawing gradient stops as draggable notches on the gradient strip is in our plans. Still, even as it is now, the editor is perfectly usable. Please test and share your experience. _________________________________________________________________ MSN Premium: Up to 11 personalized e-mail addresses and 2 months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

1 0

RE: [Inkscape-devel] simplify (rect --> path) ???
by bulia byak 26 Mar '04

26 Mar '04

>I think simplify should keep the element as it is. An rectangle should >keep as a rectangle etc. This is not possible. A simplification is, by definition, a distortion. It may remove nodes and change their coordinates. On the other hand, a rect is, by definition, precisely a rect, mathematically correct without any distortions. You can't have it both ways :) Thanks for the patches, I will now review them. _________________________________________________________________ MSN Premium: Up to 11 personalized e-mail addresses and 2 months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht…

1 0

more on win32 locale
by Adib Taraben 26 Mar '04

26 Mar '04

Hello, I found two other issues that addresses the win32 locale bug: 1. When drawing a polygon (the star) numbers in the points element are locale dependent, strange the star is drawn correctly. 2. The root document with and height are also locale dendent. I found the problem that causes #1 but I didn't found the source that writes the root width and height with the units. There are so many functions with printf that I must think some of them are never called? Adib. cvs diff sp-polygon.cpp (in directory C:\projekte\inkscape\src) Index: sp-polygon.cpp =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/sp-polygon.cpp,v retrieving revision 1.2 diff -r1.2 sp-polygon.cpp 20a21 > #include "stringstream.h" 99c100 < GString *result; --- > Inkscape::SVGOStringStream os; 101d101 < char *res; 105,106d104 < result = g_string_sized_new (40); < 112c110 < g_string_sprintfa (result, "%g,%g ", bpath [i].x3, bpath [i].y3); --- > os << bpath [i].x3 << "," << bpath [i].y3 << " "; 120,123c118,119 < res = result->str; < g_string_free (result, FALSE); < < return res; --- > > return g_strdup (os.str().c_str()); ***** CVS exited normally with code 1 *****

1 0

simplify (rect --> path) ???
by Adib Taraben 26 Mar '04

26 Mar '04

Hello, during my work on simplify output I found that simplify destroys the basic structure of the element. The output is always a path. simplify on a rect-object becomes a path-object. circle will be path. I think simplify should keep the element as it is. An rectangle should keep as a rectangle etc. Adib.

1 0

win32 locale bugs patches that work
by Adib Taraben 26 Mar '04

26 Mar '04

Hello, I have some patches for the win32 locale bugs (floating point output with komma instead point) I made the diffs diff -u4 oldfile nexfile > difffile I am using a german winXP. splivarot addresses simplify path repr-util addresses rect, circle output x and y etc. coordinates with komma instead point style addresses rect, cirlce output opacity etc. with komma instead point I don't have access to the bugs page, so I don't know the numbers yet. HTH, Adib. --- style.cpp 2004-03-26 16:16:46.000000000 +0100 +++ style.adib.cpp 2004-03-26 16:10:56.000000000 +0100 @@ -36,8 +36,9 @@ #include "marker-status.h" #include "uri-references.h" #include "sp-paint-server.h" #include "style.h" +#include "stringstream.h" namespace Inkscape { @@ -2044,14 +2045,17 @@ */ static gint sp_style_write_ifloat (gchar *p, gint len, const gchar *key, SPIFloat *val, SPIFloat *base, guint flags) { + Inkscape::SVGOStringStream os; + if (((flags & SP_STYLE_FLAG_IFSET) && val->set) || ((flags & SP_STYLE_FLAG_IFDIFF) && val->set && (val->value != base->value))) { if (val->inherit) { return g_snprintf (p, len, "%s:inherit;", key); } else { - return g_snprintf (p, len, "%s:%g;", key, val->value); + os << key << ":" << val->value << ";"; + return g_strlcpy (p, os.str().c_str(), len); } } return 0; } @@ -2062,15 +2066,17 @@ */ static gint sp_style_write_iscale24 (gchar *p, gint len, const gchar *key, SPIScale24 *val, SPIScale24 *base, guint flags) { + Inkscape::SVGOStringStream os; if (((flags & SP_STYLE_FLAG_IFSET) && val->set) || ((flags & SP_STYLE_FLAG_IFDIFF) && val->set && (val->value != base->value))) { if (val->inherit) { return g_snprintf (p, len, "%s:inherit;", key); } else { - return g_snprintf (p, len, "%s:%g;", key, SP_SCALE24_TO_FLOAT (val->value)); + os << key << ":" << SP_SCALE24_TO_FLOAT(val->value) << ";"; + return g_strlcpy (p, os.str().c_str(), len); } } return 0; } --- splivarot.cpp 2004-03-26 16:16:04.000000000 +0100 +++ splivarot.adib.cpp 2004-03-26 14:58:33.000000000 +0100 @@ -17,8 +17,9 @@ #include <libart_lgpl/art_misc.h> #include "xml/repr.h" #include "svg/svg.h" +#include "stringstream.h" #include "sp-path.h" #include "sp-text.h" #include "style.h" #include "inkscape.h" @@ -1544,24 +1545,23 @@ gchar * liv_svg_dump_path (Path * path) { - GString *result; - result = g_string_sized_new (40); + Inkscape::SVGOStringStream os; for (int i = 0; i < path->descr_nb; i++) { Path::path_descr theD = path->descr_cmd[i]; int typ = theD.flags & descr_type_mask; if (typ == descr_moveto) { Path::path_descr_moveto* nData=(Path::path_descr_moveto*)(path->descr_data+theD.dStart); - g_string_sprintfa (result, "M %lf %lf ", nData->p[0], nData->p[1]); + os << "M " << nData->p[0] << " " << nData->p[1] << " "; } else if (typ == descr_lineto) { Path::path_descr_lineto* nData=(Path::path_descr_lineto*)(path->descr_data+theD.dStart); - g_string_sprintfa (result, "L %lf %lf ", nData->p[0], nData->p[1]); + os << "L " << nData->p[0] << " " << nData->p[1] << " "; } else if (typ == descr_cubicto) { Path::path_descr_cubicto* nData=(Path::path_descr_cubicto*)(path->descr_data+theD.dStart); @@ -1570,32 +1570,34 @@ NR::Point tmp = path->PrevPoint (i - 1); lastX=tmp[0]; lastY=tmp[1]; } - g_string_sprintfa (result, "C %lf %lf %lf %lf %lf %lf ", - lastX + nData->stD[0] / 3, - lastY + nData->stD[1] / 3, - nData->p[0] - nData->enD[0] / 3, - nData->p[1] - nData->enD[1] / 3, nData->p[0],nData->p[1]); - } + os << "C " << lastX + nData->stD[0] / 3 << " " + << lastY + nData->stD[1] / 3 << " " + << nData->p[0] - nData->enD[0] / 3 << " " + << nData->p[1] - nData->enD[1] / 3 << " " + << nData->p[0] << " " + << nData->p[1] << " "; + } else if (typ == descr_arcto) { Path::path_descr_arcto* nData=(Path::path_descr_arcto*)(path->descr_data+theD.dStart); - // g_string_sprintfa (result, "L %lf %lf ",theD.d.a.x,theD.d.a.y); - g_string_sprintfa (result, "A %g %g %g %i %i %g %g ", nData->rx,nData->ry, nData->angle, - (nData->large) ? 1 : 0,(nData->clockwise) ? 0 : 1, nData->p[NR::X],nData->p[NR::Y]); + os << "A " << nData->rx << " " + << nData->ry << " " + << nData->angle << " " + << ((nData->large) ? "1" : "0") << " " + << ((nData->clockwise) ? "0" : "1") << " " + << nData->p[NR::X] << " " + << nData->p[NR::Y] << " "; } else if (typ == descr_close) { - g_string_sprintfa (result, "z "); + os << "z "; } else { } } - char *res; - res = result->str; - g_string_free (result, FALSE); - - return res; + return g_strdup (os.str().c_str()); + } --- repr-util.cpp 2004-03-26 16:24:02.000000000 +0100 +++ repr-util.adib.cpp 2004-03-26 15:35:13.000000000 +0100 @@ -29,8 +29,9 @@ #include <glib.h> #include "repr-private.h" +#include "stringstream.h" /*##################### # DEFINITIONS #####################*/ @@ -630,21 +631,16 @@ unsigned int sp_repr_set_double (SPRepr *repr, const gchar *key, double val) { - gchar c[32]; - + Inkscape::SVGOStringStream os; + g_return_val_if_fail (repr != NULL, FALSE); g_return_val_if_fail (key != NULL, FALSE); - //## This can be done in several ways. g_ascii_formatd() - //## might be the best for now. g_snprintf() can be - //## affected by LOCALE. g_ascii_formatd() is always "C" locale. - //g_snprintf (c, 32, "%.8f", val); - //sp_xml_dtoa (c, val, 8, 0, FALSE); - g_ascii_formatd (c, sizeof (c), "%.8f", val); - - return sp_repr_set_attr (repr, key, c); + os << val; + + return sp_repr_set_attr (repr, key, os.str().c_str()); } unsigned int sp_repr_set_double_default (SPRepr *repr, const gchar *key, double val, double def, double e)

1 0