- Inkscape Devel - Inkscape Mailman

Re: [Inkscape-devel] New contributor (we have new code!) that we need to help
by Ted Janeczko 24 Mar '13

24 Mar '13

Hi, Thank you so much for the very warm welcome! I look forward to working with you and contributing more code upstream! Josh, I subscribed to the mailing list, but for some reason I haven't been getting emails from it... I tried to resubscribe, hopefully that works! Tav, that sounds like a fantastic birthday party! I've done quite a bit of looking into the internal workings of SPObjects when I created the objects dialog, and I think I have a decent understanding of how everything is updated, but it does get very confusing due to gobject obscurities... If it would help out, I can take a closer look into this and start documenting the process so that it will be easier to work with in the future. When I created the objects dialog patch to submit upstream, I went through my code, added comments, reorganized, and fixed as many bugs as I could find. The blurring crash that you're referring to is most likely due to a linked-list error, which I also encountered in my testing and hopefully fixed in the patch. I also reworked styling the buttons, so the up/down arrows should hopefully now have tooltips (although it may still be unclear as to what they do, so a more descriptive tooltip may be needed). The random hiding of objects with drag-and-drop appears to be a weird side effect of the workaround for supporting multiple items. To fix this, I added a flag in the patch which gets set if the mouse-down event occurs over the visible column. When the mouse is released, if this flag is not set the visibility toggle will not be triggered. In my tests, it seemed that only the visibility column was being triggered, so I didn't add flags for the other columns, but they could easily be added if issues pop up in the future. In the latest Ponyscape release, there is an issue with re-selecting items when they've been moved via drag-and-drop that causes a lot of assertion errors (which may be the errors that you were seeing). I store the source SPItems in a vector, which I iterate over and move on a drop operation. I was also using this vector to select the items post-move, but they no longer referred to the correct SPItem (due to how SPObjects are built and moved). In the patch, I now store the ID's of the items before they're moved in a different vector and use that for fetching and selecting the items after the move. Moving items between layers and into and out of groups is currently only able to be done through drag-and-drop... It would be possible to add buttons similar to the XML editor, but that may overcrowd the UI. This functionality could also be added to the right-click menu, which might be a better solution. You can already group and ungroup items using the right-click menu (along with clipping and masking items). If you notice anything else or have any suggestions on improving things, let me know and I'll take a look into it! I am planning on doing the same process of reviewing, commenting, and bugfixing my code before creating a patch for the tags dialog, and will definitely be sure to keep in mind all of the points you brought up about it. In the top revision of Ponyscape I have already added the ability to rename objects in the tags dialog, and I will look into the rest of the items that you have brought up! I may eventually move Ponyscape development into a branch on launchpad... For the time being I am using a repository on a local server, which has been working out so far, but I can definitely see where it would be beneficial to have a public branch as well. Looking forward to working more with the development team! Ted Janeczko On Tue, Mar 19, 2013 at 12:13 PM, Josh Andler <scislac@...400...> wrote: > I'm sending this to you only because I don't know that you've > subscribed to our developer list yet. :) > > > ---------- Forwarded message ---------- > From: Tavmjong Bah <tavmjong@...8...> > Date: Tue, Mar 19, 2013 at 6:27 AM > Subject: Re: [Inkscape-devel] New contributor (we have new code!) that > we need to help > To: Josh Andler <scislac@...400...> > Cc: Inkscape Devel List <inkscape-devel(a)lists.sourceforge.net> > > > > Hi, > > First, let me say this really sounds great! Welcome Ted! I could have > used Ponyscape a couple of months ago when I was preparing a Pony party > for my older daughter's sixth birthday. The guests played pin the horn > on Fluttershy and the birthday cake was a Pony Carousel. > > Here are some random thoughts: > > Let's be honest, 0.49 isn't going to happen soon. There is no sign that > anybody is tackling the bitmap scaling problem from either the Inkscape > or the Cairo side. And even if Cairo were to have the API's needed today > it will be awhile before there is a Cairo release with them. > > Given that, I don't think we need to be overly worried about changes to > the Inkscape code base. (But I do think new features should be > reasonably complete.) > > I am intrigued by Ted's comment about using an XmlNodeObserver for > handling updates. It would be good to have someone really understand how > updates are handled by Inkscape. When I put in random print statements I > often see the same code being executed multiple times when it should > only be executed once. We seem to have quasi-circular loops going on. > > Playing with the Object dialog in Ponyscape: > > * Blurring an object crashes Ponyscape. > * It's not clear what all the icons are for... no tooltips. What are > the up/down icons for? > * Clicking on the "domino" shaped icon brings up a color picker which I > can't seem to get rid of. I have to restart the program. > * Layers and objects seem to be randomly hidden when dragging them up > and down. > * Can't move objects between layers using arrows. > * Not easy to move objects into and out of groups (like in the XML > editor). > * I see lots of error messages. > > In summary, it's a good start but needs polishing before merging (note: > I haven't tested the patch, just Ponyscape). > > Playing with the Tagging dialog: > > * Needs tooltips or other hints on how to use. > * The items list is auto opened... maybe should also be auto closed? > * Would be useful to be able to rename objects in dialog. > * Might be good to integrate with symbols dialog (create custom symbols > from tagged objects). > > If Ted plans on submitting patches routinely, it might make sense for > him to keep his code repository as a branch of Inkscape. It would make > it easier to follow his work. > > Tav > > > On Tue, 2013-03-19 at 00:18 -0700, Josh Andler wrote: > > Hey all, > > > > I submitted a new "report" based around a patch submitted from the > > primary developer of Ponyscape (an Inkscape derivative project focused > > on making life easier for artists interested in creating My Little > > Pony fan art). > > > > Check out the first new patch he has submitted upstream at: > > https://bugs.launchpad.net/inkscape/+bug/1157024 > > > > I've talked with him a bit and he's really doing some good work at a > > rapid pace, but as we know, we don't have the same leeway upstream to > > add features that may change on a regular basis. So, he sees Ponyscape > > as a good testing ground to let things have some time to mature and > > ripen and then he will submit patches upstream. He also doesn't want > > to step on any toes or anything. > > > > That first patch is for a long awaited feature. If others would be > > willing to test and do some code review, it will help us to establish > > a tighter relationship with Ted. He's already met the 2 patch > > requirement and has commit access, but he really wants feedback and to > > get things right before stuff is committed. > > > > My guess is with the amount of divergence and level of changes he > > makes, this patch vs direct commit paradigm might be around for a > > while (he has a lot of irons in the fire for new/improved features). > > My view is that I don't mind doing this side of things provided other > > devs will be willing to help test and give feedback. > > > > Cheers, > > Josh > > > > > ------------------------------------------------------------------------------ > > Everyone hates slow websites. So do we. > > Make your web apps faster with AppDynamics > > Download AppDynamics Lite for free today: > > http://p.sf.net/sfu/appdyn_d2d_mar > > _______________________________________________ > > Inkscape-devel mailing list > > Inkscape-devel(a)lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/inkscape-devel >

7 8

New/Update LPE Sketch
by Jabiertxo Arraiza Cenoz 23 Mar '13

23 Mar '13

The number of lines to draw can be get by tree ways: 1.- Changing the default value when alter the number of lines, im not sure if can be done, but is what like more. 2.-Search in the SVG the value of the widget number of lines in the first filter -last applied- of this LPE 3.-By preferences. I dont like this, not intuitive. Hi, Jabier.

1 0

New/Update LPE Sketch
by Jabiertxo Arraiza Cenoz 23 Mar '13

23 Mar '13

One thing more, maybe the fiter isnt necesary, by adding a button near spiro or in the combobox of siluette near ellipse.triangle in... Whith this combo youu can select for example Spiro+Sketch. Any body want to put name to this? Hi, Jabier.

1 0

New/Update LPE Sketch
by Jabiertxo Arraiza Cenoz 23 Mar '13

23 Mar '13

Hi to all. Im thinking in a aditional LPE based in Sketch LPE. The goal is: A simple LPE whith few widgets maybe only this one: Select the number of lines to draw. When you draw a pen stroke it create this numbrer of lines whith a random seed position of nodes. but cobering all path whith random ofset at start and at end. The finality is made a speed sketch tool, in the current Sketch LPE the calculations to made a rich "Sketch" slow the drawing speed because you neeed a lot of lines to cover the full path. By this way only need to calculate a delimited number of lines. This is like more lines more beauty but more slow, few lines faster redraw. Who thik this feature interesant? think is very easy to make, and it can go whith a filter Sketch layer, to select the number of lines and if you want Spriro or ?BSpline. This aditional live effects are because a live effect in a layer hide the filter effects of his children. But isnt a problem because is only to ?starting sketchs. It can be done in the pencil tool, but with Live Effect isnt "destructive" and maybe user can hide the effect, alter a path is more easy, and maybe more easy to made, but is only my opinion. Hi, Jabier.

1 0

Updates in Bspline branch.
by Jabiertxo Arraiza Cenoz 23 Mar '13

23 Mar '13

Hi to all. Y apply some fixes that Mauro give to me. *Simmetrical, smooth, auto, node toolbar now only give or a 0.3334 weight BSpline or a CUSP node. *Fixed a bad brehaviour continuing existing curves *Pencil mode work in bsline mode *Fixed widgets of LPE Mauro tell me about a problem/feature scaling some nodes and moving them, they reset to original position, it happens in the devel version? Now the widgets work better, i have some problems whith the button widget, some times is necesary press two times to update the scalar list. Mauro, coment me is a good point apply custom weight only to selected paths, whats is the best way to have a vector of selected nodes/points insde a LPE? By, Jabier.

1 0

"superdropper"
by Bric 23 Mar '13

23 Mar '13

Hi, guys: This just reached a critical "must-express" pressure in my head: I've been periodically, over the last few years, missing this (yet non-existent?) feature for a dropper, in Inkscape (as well as in other image editors). An enhanced version of a dropper, which does the following: It's able to "suck up" the attributes of an object (similar to what it's already doing), and then "drip them out" onto one OR MORE (multiple!) objects, as the user wishes. The sampled (sucked up) attributes could stay in the dropper buffer, indefinitely... until the user replaces them with another dropper "suction". In addition, it would be nice to expand the number of attribute types the dropper can disperse, and, of course, let the user check/uncheck the attributes that are being copied and dispersed. [x] fill [x] stroke color [x] stroke thickness - absolute units [x] stroke thickness - proportional/adjusted to the transform magnification (not sure about this one, just a thought) [x] opacity [x] alpha [x] a variety of other attributes, like roundness, etc. (limited to certain objects, perhaps) [x] funky, crazy user-assigned things, like "reduce to same number of nodes" -- OK, maybe i'm going too far here... [x] I might be missing many many other great additions to this list; i'm sure others would suggest more stuff. ------------------ So... with this superdropper I'd be able to click on a path/object, and then, holding down some drip/endow control key combo (like, "Ctrl+Alt[+click]", or some such) click on object(s) TO WHICH I WOULD PASS these attributes — as many objects as I like, in succession..., without re-sampling (without sucking in attributes) ------------------- It seems like code-wise, it shouldn't be that difficult. -------------------- I was checking out the 0.48 dropper, and it is already capable of copying either the stroke color or the fill color, distinctly, and there's already a button tool bar to go with it. (But it doesn't seem to be able to do a series of "drip-outs" onto many objects.) -------------------- As far as I know this is my original idea, and I'd like to "bequeath" it to Inkscape and other GPL-licensed applications. So, just to be sure no commercial app hijacks this feature (the concept/algorithm) and claims it as its own (and prevents open-source apps from acquiring it), I hereby declare the afore-mentioned feature to be under the GNU GENERAL PUBLIC LICENSE, v3, as spelled out by the Free Software Foundation. Again, this is just in case it hasn't been developed yet, although i'm actually hard-pressed to believe that it doesn't yet exist somewhere, and in case there's a looming threat of some commercial-venture grabbing the feature before it gets integrated into some GPL'ed app (hopefully into Inkscape) ------------------------------ Thanks!

4 16

New tools
by Dennis Coyle III 23 Mar '13

23 Mar '13

I'm not new to programming but definitely rusty. Coming back into it for the first time in c++ has been a bit jarring. I am looking to create a couple tools to experiment with and was wondering the best way to go about it. One will use a lot of functionality of knots but I'm not sure as to how hard it would be to subclass the knot and remove (what I believe is) the element constraint. (tell me if i'm mixing terms here). Any leads to a good subclassing refesher (i.e. what includes I really need in the subclass etc.) would be extremely beneficial. Thanks.

3 2

Spirolive+BSpline insert node fixed
by Jabier Arraiza 22 Mar '13

22 Mar '13

Hi to all. Fixed Spirolive+BSpline add node error and others fixings. Uncomented WITH_MESH; By, Jabier.

1 0

mesh branch test
by Jabiertxo Arraiza Cenoz 22 Mar '13

22 Mar '13

Hi to all, i have some free time while compiling and start testing other branch. I start whith mesh branch. Impresionant. Bravo Tav. Maybe some of your work can used for create a mesh based deformation system for images and all other staff in inkscape. Any other branch sugestions? Hi, Jabier.

3 4

New contributor (we have new code!) that we need to help
by Josh Andler 21 Mar '13

21 Mar '13

Hey all, I submitted a new "report" based around a patch submitted from the primary developer of Ponyscape (an Inkscape derivative project focused on making life easier for artists interested in creating My Little Pony fan art). Check out the first new patch he has submitted upstream at: https://bugs.launchpad.net/inkscape/+bug/1157024 I've talked with him a bit and he's really doing some good work at a rapid pace, but as we know, we don't have the same leeway upstream to add features that may change on a regular basis. So, he sees Ponyscape as a good testing ground to let things have some time to mature and ripen and then he will submit patches upstream. He also doesn't want to step on any toes or anything. That first patch is for a long awaited feature. If others would be willing to test and do some code review, it will help us to establish a tighter relationship with Ted. He's already met the 2 patch requirement and has commit access, but he really wants feedback and to get things right before stuff is committed. My guess is with the amount of divergence and level of changes he makes, this patch vs direct commit paradigm might be around for a while (he has a lot of irons in the fire for new/improved features). My view is that I don't mind doing this side of things provided other devs will be willing to help test and give feedback. Cheers, Josh

4 4