- Inkscape Devel - Inkscape Mailman

repr refactoring
by MenTaLguY 18 Jan '05

18 Jan '05

I just did something that should have been done a long time ago -- made all of SPRepr's data fields private. This shouldn't have affected anything, but it turns out a lot of code still was poking at the fields directly. I replaced direct accesses with calls to the appropriate accessors. In the process I moved most of the "real" functionality into SPRepr member functions; the sp_repr_* functions remain as thin wrappers for the moment. For reference: old-style direct access .... becomes: repr->parent repr->parent() or sp_repr_parent(repr) repr->next repr->next() or sp_repr_next(repr) repr->children repr->firstChild() or sp_repr_children() repr->doc repr->document() Long-term, SPRepr will become a public interface (abstract) class in repr.h, the current SPRepr will become SPReprImpl or similar, and the wrapper sp_repr_* functions will become inline, then go away entirely. -mental

1 0

trivial patch for clonetiler.cpp
by Alexandre Prokoudine 17 Jan '05

17 Jan '05

Hi, Here is a trivial patch for dialogs/clonetiler.cpp adding keyboard accessibility to tabs and three buttons (Reset, Remove, Create) in "Clone tiles" dialog. Please review and apply. Alexandre

3 2

join/cap icons
by bulia byak 17 Jan '05

17 Jan '05

1 Some of the icons have blurred fringes at the edges of the square, which happens because another icon is too close in icons.svg and its edge's antialiasing gets into the neighboring icon. Watch out for this. 2 I don't like the thick white "midline" in these icons. What does it represent? Why white? If you want to show the midline axis, just a single solid black stroke, solid or dashed, is enough. The white is too salient and confusing. 3 I also don't like the highlights on the icons. Hey, this is just strokes! They are not supposed to be highlighted or shaded in any way. It's just silly. I have to spend extra milliseconds every time I try to figure out the join shape, dazzled by all the highlights and the white thing in it. 3 The butt cap icon is wrong: the white midline (of whatever this is) must not and can not extend beyond the stroke itself. Never.

5 5

calligraphic icon
by bulia byak 17 Jan '05

17 Jan '05

I have decided I should not interfere with icon work, as I tend to be too critical sometimes. However the newest calligraphic icon on the toolbar is so ugly I wanted to speak up. The idea to replace pencil with a pen is OK, but that pen is too out of sync with the rest of the icons. It seems too heavy and black because of the stroke, thus almost obscuring the calligraphic line it's drawing, and the entire icon looks dirty and noisy. Whoever did it, please try to make it cleaner.

5 7

basically OT: Roadmap Question
by David Christian Berg 17 Jan '05

17 Jan '05

Maybe it's not quite nice to pose this question, but I just need some info to consider my plans. >From April 11th to 16th, the ESTIEM Spring Council Meeting will take place in Lyon, France. As the design coordinator I will be leading a PR working group. While a lot of time will be needed to work on the ESTIEM webpage, esp. it's content, I am thinking about introducing the working group to Inkscape, since so far vectors have badly been neglected for ESTIEM design tasks. Before having many people complain about some lacking functions, I'd like to know, where you think Inkscape will stand at that point of time. Any chance of my main issues being addressed by then? - On canvas text editing, including flowtext - Working ai/ps/eps(/pdf <- that'd be just great!) output, including transparency and gradients - Ability to add a node anywhere on a line -- via right-click - Real clipping paths for images (and svg objects) I'm not saying Inkscape was unusable without these functions. I think it's a wonderful piece of software, as you know, but it takes quite some personal effort to work with it, sometimes. So while I myself use Inkscape for basically everything graphical I'm doing, it will be hard to convince people without this special open source spirit. David

4 5

Re: Volunteer work and an idea how to get into existing code bases
by Thorsten Roggendorf 17 Jan '05

17 Jan '05

Hi > Might be interesting to see a UML diagram of the codebase if anyone > already has the tools setup to do it easily, generate it automatically > (Rational Rose, Visio, Autodia?) I'd suggest Doxygen. It does a decent job on automatic UMLing and helps in solving all other Documentation problems as well. Cheers Thorsten

1 0

Help needed verifying bugs on Win32
by Bryce Harrington 17 Jan '05

17 Jan '05

We need some Windows users to help us with some of the bugs that have been reported, that don't appear to be present on Linux. If you're a Windows user, this is really important, because when 0.41 comes out you'll have a more stable tool than you would otherwise. ;-) Basically, we need you to test out what's described in the bug report and see if you have the same problem, and then add a comment indicating whether or not you could reproduce it. Any additional information you can provide on these bugs will be helpful. See the Reporting Bugs page on the main website for details. Go to the Bug Tracker on SourceForge: http://sourceforge.net/tracker/?group_id=93438&atid=604306 Select "Status=Open", "SortBy=Priority/Descending", and test the bugs of priority 9. If you have a SourceForge account, please log in, so we can contact you if we need you to test something out. Or leave your name or email address if you don't have an account. Thanks, Bryce

1 0

xlink namespace bug
by bulia byak 17 Jan '05

17 Jan '05

I was going to close this bug as invalid: http://sourceforge.net/tracker/index.php?func=detail&aid=1102678&group_id=9… because the attached file indeed does not declare the xlink: prefix, which is invalid XML. However to my surprise both Batik and Adobe render it without a complaint. What am I missing? I thought that if a file is invalid XML it cannot be valid SVG. Are Batik/Adobe being unduly permissive? What are we supposed to do in this situation?

2 3

jabber room?
by bulia byak 16 Jan '05

16 Jan '05

Now when I log to conference.gristle.org I see no "inkscape" room listed. What has changed?

2 1

object binding changes
by MenTaLguY 16 Jan '05

16 Jan '05

In order to remove the last of the veto callbacks (the only one used, in only one place), I went ahead and rewrote SPDocument::getObjectByRepr() so it didn't rely on ID lookups, then removed the change attribute veto callback. Two side-effects of this: 1. it is now possible to remove the id attribute from an element This shouldn't cause any problems, as I laid the groundwork for id-less operation a long time ago (this has been planned for a while). Note that objects still get ids by default. 2. manually setting a conflicting id now causes the original object to get a new id, rather than disallowing the change This should always have been at least possible through the XML editor. I'm not as sure about the properties dialog; if we decide it's best to disallow setting a conflicting ID again we can implement a check in the dialog. I think both changes are more in line with user expectations anyway. Test and let me know if I missed any breakage. I tried to be conservative about the change. -mental

3 3