- Inkscape Devel - Inkscape Mailman

gtkmm .exe and Windows solved
by Hal Lorenz 05 Sep '05

05 Sep '05

Well it does seem I have a knack for asking obsolete questions, although I really was stuck with this problem and Google wasn't helping, it seems a fresh pair of eyes did the trick. The problem was that it was running in the console subsystem, as opposed to the GUI windows subsystem. Solved simply by adding the flag -mwindows to g++. Thanks for Inkscape anyway. ;) Kind regards, Hal

1 0

Re: [Inkscape-devel] commit warning
by Kees Cook 05 Sep '05

05 Sep '05

On Sun, Sep 04, 2005 at 05:03:56PM +0200, Ralf Stephan wrote: > for this reorganization. However, some issues are unresolved at the > moment, and I'll pursue them ASAP: > - slideshow is probably broken > in spite of five days of testing, so don't hesitate to report. I suspect that "slideshow" being broken probably means that the About box is dead too. Is that right? I get the following crash when opening the Help->About box now: (inkscape:17201): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GObject' (inkscape:17201): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed -- Kees Cook @outflux.net

3 3

SOC Mentors - Review process
by Bryce Harrington 05 Sep '05

05 Sep '05

Ted, Jon, and Peter, Here is what you need to do to complete the Google Summer of Code project. Go to this URL: http://code.google.com/grants/survey-m.html It sounds like they'd like to get these all collected by the 5th. Please let me know when you've filled it out (so we can make sure all the students get accounted for). Thanks, Bryce

4 5

Autorouting Connectors
by Michael Wybrow 04 Sep '05

04 Sep '05

Hello all, The Summer of Code has offically finished up. I've since caught up on some sleep and a few non-SoC things. I've also fixed up the obvious bugs, so this seems like a good time to announce what I actually achieved with the connector tool. Autorouting polyline connectors are in CVS and work well. However you manipulate them, they will avoid objects marked as 'avoided'. Objects can be marked as 'avoided' or 'ignored' via the connector context toolbar buttons. Tricky to explain, but easy to see and understand... just have to play with it. The following wiki page has instructions and further discussion: http://wiki.inkscape.org/cgi-bin/wiki.pl?UsingTheConnectorTool There are a couple of obvious problems: * Connectors are drawn to object's bounding boxes, rather than edges. I have a couple of ideas and some code to address this, so it shouldn't be too long till this is in the codebase. * Bounding boxes are used for the avoidance code, i.e., lines will route around a diamond as if it was a rectagle. The routing code deals with polygons so it's just a matter of me or someone else properly implementing the NR::ConvexHull class. There are plenty of other features I plan to add, some that have been requested by people already. Toolbar marker (arrow head) controls being one of these. See my TODO list on the wiki or in connector-context.cpp. Please have a look at the wiki page, and try out the connectors. Then add to the wiki page with ideas/problems or open bugs/RFEs. I've really enjoyed working on Inkscape the past two months, and as I said in an earlier mail, I feel like this time has got me over the initial hurdle of learning the codebase. I feel much better placed to comfortably contribute in the future. Basically, expect me to become a regular on the mailing list and Jabber. :-) Also, one of the things I've noticed as a result of the Summer of Code time is the real community aspect of the Inkscape project. It's a really open, welcoming community. I'd heard of students working for other projects who really didn't have much contact with their mentoring organisation, and were still waiting for accounts for CVS etc at the end of August. With Inkscape on the other hand, developers and users were always helpful and friendly. Just wanted to thank everyone for that! Cheers, Michael

2 2

Tree changes for DOM stuff
by Bob Jamison 04 Sep '05

04 Sep '05

With the help of Bryce, I am planning on (finally) adding the DOM code to the tree, even though it's not done. This will give people a chance to look at it while it is in progress. Some changes to the tree were necessary: /src/ecma and /src/xpath are gone /src/dom is created /src/extension/script/js is moved to /src/dom I updated the win32 Makedep files, and the win32 build works nicely. It looks like configure.ac has no missing dependencies, so hopefully the unix build won't be broken. If anyone has any problems like this, check out the makefiles listed at the bottom of configure.ac. No, xpath and ecma are not gone. xpath is now part of DOM. Since Swig no longer supports JS, is behooves us to bind JS directly to DOM, hence the move there. Hopefully as we begin hooking things up, we can have some fun with this. Bob

1 0

Gimp Conference 2006
by David Neary 04 Sep '05

04 Sep '05

Eat Frog's Legs and snails in garlic butter! Enjoy the refreshing taste of duck liver! Eat baked pig intestines (a local speciality)! Come to Lyon for the GIMP Conference, 2006! We're in the early stages of the planning - and now's the time to stand up & be counted. The GIMP conference, which may become a more general Free Graphics conference, if other people like the idea, will be held in CPE, Lyon, in March or April 2006. We have 4 possible weekends (Friday/Saturday/Sunday) available. The first is the weekend of St. Paddy's Day (the patron saint of Guinness), and David Odin's birthday - 17/18/19 March. The second is the weekend afterwards, when there's not much on - 24/25/26 March The third is the birthday of Dave Neary (me!), and April Fool's Day (think of the press release possibilities!) - 31 march/1/2 April. The last one - 7/8/9 April. We need to decide when the conference will be on soon, to reserve space in the university, get in contact with youth hostels, figure out what's going to happen, and work up some sponsorship. Once the dates are fixed, I'll send a follow-up announcement (if there are dates that are definitely out for you, let us know now). Everyone's welcome! Spread the word! Bring your dog! (But tie them on a leash outside) Bring your partner! (Lyon's lovely in March) We're looking forward to having you all. Cheers, Dave. -- Dave Neary bolsh@...85... Lyon, France

1 0

commit warning
by Ralf Stephan 04 Sep '05

04 Sep '05

hello, in case you're wondering, my recent commit moved SPDesktop from GObject to C++/sigc++. Fortunately, it was only necessary to touch about 80 files for this reorganization. However, some issues are unresolved at the moment, and I'll pursue them ASAP: - slideshow is probably broken - compiling inkboard was not tested, probably broken A crash on shutdown was removed in the last minute. There might be more, in spite of five days of testing, so don't hesitate to report. Regards, ralf

3 3

Re: Inkscape still does not work on FC
by Artur Rataj 04 Sep '05

04 Sep '05

It's some un-upgradeable FC3 -- yum upgrade shows some missing openssh deps or something -- with glib updated manually to 2.0. With the previous glib, Inkscape would not compile. I'll try to recompile Inkscape on FC4, or replace that distro with another one. Linux linux 2.6.10-1.760_FC3 #1 Wed Feb 2 00:14:23 EST 2005 i686 athlon i386 GNU/Linux The error was: *** glibc detected *** free(): invalid pointer: 0x09fced60 *** Valgrind output: ==19138== Memcheck, a memory error detector. ==19138== Copyright (C) 2002-2005, and GNU GPL'd, by Julian Seward et al. ==19138== Using LibVEX rev 1313, a library for dynamic binary translation. ==19138== Copyright (C) 2004-2005, and GNU GPL'd, by OpenWorks LLP. ==19138== Using valgrind-3.0.0, a dynamic binary instrumentation framework. ==19138== Copyright (C) 2000-2005, and GNU GPL'd, by Julian Seward et al. ==19138== For more details, rerun with: -v ==19138== ==19138== Syscall param write(buf) points to uninitialised byte(s) ==19138== at 0x1C110353: __write_nocancel (in /lib/tls/libpthread-2.3.5.so) ==19138== by 0x1C27704F: (within /usr/X11R6/lib/libX11.so.6.2) ==19138== by 0x1C277312: _X11TransWrite (in /usr/X11R6/lib/libX11.so.6.2) ==19138== by 0x1C25B3F2: (within /usr/X11R6/lib/libX11.so.6.2) ==19138== by 0x1C25B47A: _XReply (in /usr/X11R6/lib/libX11.so.6.2) ==19138== by 0x1C2471B7: XInternAtom (in /usr/X11R6/lib/libX11.so.6.2) ==19138== by 0x1C26408C: XSetWMProperties (in /usr/X11R6/lib/libX11.so.6.2) ==19138== by 0x1BF8498D: (within /usr/lib/libgdk-x11-2.0.so.0.400.14) ==19138== by 0x1BF8795E: gdk_window_new (in /usr/lib/libgdk-x11-2.0.so.0.400.14) ==19138== by 0x1BF667CD: gdk_display_open (in /usr/lib/libgdk-x11-2.0.so.0.400.14) ==19138== by 0x1BF473DC: gdk_display_open_default_libgtk_only (in /usr/lib/libgdk-x11-2.0.so.0.400.14) ==19138== by 0x1BD893FE: gtk_init_check (in /usr/lib/libgtk-x11-2.0.so.0.400.14) ==19138== Address 0x1CBE4288 is 128 bytes inside a block of size 16384 alloc'd ==19138== at 0x1B901B47: calloc (vg_replace_malloc.c:279) ==19138== by 0x1C24B835: XOpenDisplay (in /usr/X11R6/lib/libX11.so.6.2) ==19138== by 0x1BF666B3: gdk_display_open (in /usr/lib/libgdk-x11-2.0.so.0.400.14) ==19138== by 0x1BF473DC: gdk_display_open_default_libgtk_only (in /usr/lib/libgdk-x11-2.0.so.0.400.14) ==19138== by 0x1BD893FE: gtk_init_check (in /usr/lib/libgtk-x11-2.0.so.0.400.14) ==19138== by 0x1BD89431: gtk_init (in /usr/lib/libgtk-x11-2.0.so.0.400.14) ==19138== by 0x1BA7A17C: Gtk::Main::init(int*, char***, bool) (main.cc:376) ==19138== by 0x1BA79E57: Gtk::Main::Main(int*, char***, bool) (main.cc:333) ==19138== by 0x8112CA2: sp_main_gui(int, char const**) (main.cpp:514) ==19138== by 0x81D21EB: Inkscape::NSApplication::Application::run() (application.cpp:134) ==19138== by 0x8112966: main (main.cpp:431) ==19138== ==19138== Conditional jump or move depends on uninitialised value(s) ==19138== at 0x1C4B52E5: GC_push_all_eager (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B63EE: GC_push_current_stack (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4BD574: GC_generic_push_regs (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6532: GC_push_roots (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B40B5: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== ==19138== Conditional jump or move depends on uninitialised value(s) ==19138== at 0x1C4B52EA: GC_push_all_eager (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B63EE: GC_push_current_stack (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4BD574: GC_generic_push_regs (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6532: GC_push_roots (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B40B5: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== ==19138== Conditional jump or move depends on uninitialised value(s) ==19138== at 0x1C4B454E: GC_mark_from (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B41C8: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== by 0x8356930: sp_repr_svg_read_node(_xmlNode*, char const*, _GHashTable*) (repr-io.cpp:454) ==19138== by 0x8357D6C: sp_repr_do_read(_xmlDoc*, char const*) (repr-io.cpp:364) ==19138== by 0x8357E0E: sp_repr_read_mem(char const*, int, char const*) (repr-io.cpp:288) ==19138== ==19138== Conditional jump or move depends on uninitialised value(s) ==19138== at 0x1C4B4553: GC_mark_from (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B41C8: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== by 0x8356930: sp_repr_svg_read_node(_xmlNode*, char const*, _GHashTable*) (repr-io.cpp:454) ==19138== by 0x8357D6C: sp_repr_do_read(_xmlDoc*, char const*) (repr-io.cpp:364) ==19138== by 0x8357E0E: sp_repr_read_mem(char const*, int, char const*) (repr-io.cpp:288) ==19138== ==19138== Conditional jump or move depends on uninitialised value(s) ==19138== at 0x1C4B4568: GC_mark_from (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B41C8: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== by 0x8356930: sp_repr_svg_read_node(_xmlNode*, char const*, _GHashTable*) (repr-io.cpp:454) ==19138== by 0x8357D6C: sp_repr_do_read(_xmlDoc*, char const*) (repr-io.cpp:364) ==19138== by 0x8357E0E: sp_repr_read_mem(char const*, int, char const*) (repr-io.cpp:288) ==19138== ==19138== Conditional jump or move depends on uninitialised value(s) ==19138== at 0x1C4B456D: GC_mark_from (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B41C8: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== by 0x8356930: sp_repr_svg_read_node(_xmlNode*, char const*, _GHashTable*) (repr-io.cpp:454) ==19138== by 0x8357D6C: sp_repr_do_read(_xmlDoc*, char const*) (repr-io.cpp:364) ==19138== by 0x8357E0E: sp_repr_read_mem(char const*, int, char const*) (repr-io.cpp:288) ==19138== ==19138== Invalid read of size 4 ==19138== at 0x1C4B4543: GC_mark_from (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B41C8: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== by 0x8356930: sp_repr_svg_read_node(_xmlNode*, char const*, _GHashTable*) (repr-io.cpp:454) ==19138== by 0x8357D6C: sp_repr_do_read(_xmlDoc*, char const*) (repr-io.cpp:364) ==19138== by 0x8357E0E: sp_repr_read_mem(char const*, int, char const*) (repr-io.cpp:288) ==19138== Address 0x52C00030 is not stack'd, malloc'd or (recently) free'd ==19138== ==19138== Process terminating with default action of signal 11 (SIGSEGV) ==19138== Bad permissions for mapped region at address 0x52C00030 ==19138== at 0x1C4B4543: GC_mark_from (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B41C8: GC_mark_some (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD524: GC_stopped_mark (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4AD151: GC_try_to_collect_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B6EC9: GC_init_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2964: GC_generic_malloc_inner (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2AC0: GC_generic_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x1C4B2DB4: GC_malloc (in /usr/lib/libgc.so.1.0.2) ==19138== by 0x8359A40: sp_repr_new(char const*) (gc-core.h:72) ==19138== by 0x8356930: sp_repr_svg_read_node(_xmlNode*, char const*, _GHashTable*) (repr-io.cpp:454) ==19138== by 0x8357D6C: sp_repr_do_read(_xmlDoc*, char const*) (repr-io.cpp:364) ==19138== by 0x8357E0E: sp_repr_read_mem(char const*, int, char const*) (repr-io.cpp:288) ==19138== ==19138== ERROR SUMMARY: 552 errors from 8 contexts (suppressed: 140 from 3) ==19138== malloc/free: in use at exit: 300190 bytes in 5874 blocks. ==19138== malloc/free: 7914 allocs, 2040 frees, 603035 bytes allocated. ==19138== For counts of detected errors, rerun with: -v ==19138== searching for pointers to 5874 not-freed blocks. ==19138== checked 2931004 bytes. ==19138== ==19138== LEAK SUMMARY: ==19138== definitely lost: 0 bytes in 0 blocks. ==19138== possibly lost: 7136 bytes in 24 blocks. ==19138== still reachable: 293054 bytes in 5850 blocks. ==19138== suppressed: 0 bytes in 0 blocks. ==19138== Reachable blocks (those to which a pointer was found) are not shown. ==19138== To see them, rerun with: --show-reachable=yes On 8/28/05, Mike Hearn <mike@...869...> wrote: > On Sun, 28 Aug 2005 18:59:38 +0200, Artur Rataj wrote: > > Static binary 42.0 did not work, the latest sources 42.2 compiled but did > > not work. > > Do you mean the same error occurred? What version of Fedora is this and > did you upgrade from an earlier Fedora release? > > If you can run the program in valgrind that'd be good. > > thanks -mike > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > _______________________________________________ > Inkscape-devel mailing list > Inkscape-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/inkscape-devel >

2 1

Interesting OS X tidbits
by Jon A. Cruz 04 Sep '05

04 Sep '05

Here are a few interesting tidbits that came up in the latest mailing I got from the Apple Developer Connection Technical Note TN2137 Building Universal Binaries from "configure"-based Open Source Projects http://developer.apple.com/technotes/tn2005/tn2137.html Adopting Universal Binaries on Mac OS X http://developer.apple.com/macosx/adoptinguniversalbinaries.html Working with Xcode: Building Applications for the Future http://developer.apple.com/tools/xcode/xcodefuture.html

3 2

Exporting (was: Using Inkscape)
by Gavin Band 04 Sep '05

04 Sep '05

Hi Sorry, I split this topic off from the other one about zooming. Bulia Byak wrote: > Choosing export area is also bitmap-only. For vector export, we may > only select which _objects_ to export (though we don't currently have > code for this, always exporting the whole image), but not the export > area. That only makes sense for bitmaps. <snip> I see what you mean, but doesn't it also make sense to be able to export a region of the picture, or the whole picture, or the whole page, to postscript or encapsulated postscript? What if you want to print the bottom half of the picture, or send it somewhere else to be printed? You're right though - the current Export Bitmap pane is very easy to use (I hadn't noticed the selection-tracking behaviour, though on my machine it seems to get stuck on "Custom" and I have to click "Selection" again to make it update). So I suppose I'd like it to a) have a proper file browser (the same as the "Save as..." one) b) have a preview pane like you mentioned c) have a choice of file type. gav.

2 1